From: Christoph Hellwig <hch@infradead.org>
To: js1304@gmail.com
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Vlastimil Babka <vbabka@suse.cz>,
Laura Abbott <labbott@redhat.com>,
"Aneesh Kumar K . V" <aneesh.kumar@linux.ibm.com>,
Mel Gorman <mgorman@techsingularity.net>,
Michal Hocko <mhocko@suse.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Roman Gushchin <guro@fb.com>, Minchan Kim <minchan@kernel.org>,
Rik van Riel <riel@surriel.com>,
Christian Koenig <christian.koenig@amd.com>,
Huang Rui <ray.huang@amd.com>,
Eric Biederman <ebiederm@xmission.com>,
"Rafael J . Wysocki" <rjw@rjwysocki.net>,
Pavel Machek <pavel@ucw.cz>,
kernel-team@lge.com, Christoph Hellwig <hch@infradead.org>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>
Subject: Re: [PATCH v2 04/10] power: separate PageHighMem() and PageHighMemZone() use case
Date: Fri, 1 May 2020 05:22:45 -0700 [thread overview]
Message-ID: <20200501122245.GA21897@infradead.org> (raw)
In-Reply-To: <1588130803-20527-5-git-send-email-iamjoonsoo.kim@lge.com>
On Wed, Apr 29, 2020 at 12:26:37PM +0900, js1304@gmail.com wrote:
> index 6598001..be759a6 100644
> --- a/kernel/power/snapshot.c
> +++ b/kernel/power/snapshot.c
> @@ -1227,7 +1227,7 @@ static struct page *saveable_highmem_page(struct zone *zone, unsigned long pfn)
> if (!page || page_zone(page) != zone)
> return NULL;
>
> - BUG_ON(!PageHighMem(page));
> + BUG_ON(!PageHighMemZone(page));
The above check already checks for the highmem zone. So if we want
to keep the BUG_ON it needs stay PageHighMem to make sense. That being
said I'd rather remove it entirelẏ.
> - BUG_ON(PageHighMem(page));
> + BUG_ON(PageHighMemZone(page));
Same here.
> @@ -1529,7 +1529,7 @@ static unsigned long preallocate_image_pages(unsigned long nr_pages, gfp_t mask)
> if (!page)
> break;
> memory_bm_set_bit(©_bm, page_to_pfn(page));
> - if (PageHighMem(page))
> + if (PageHighMemZone(page))
> alloc_highmem++;
> else
> alloc_normal++;
I don't fully understand the log here. Can Pavel or Rafael clarify
why swsupst would care about the exact zone?
next prev parent reply other threads:[~2020-05-01 12:22 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-29 3:26 [PATCH v2 00/10] change the implementation of the PageHighMem() js1304
2020-04-29 3:26 ` [PATCH v2 01/10] mm/page-flags: introduce PageHighMemZone() js1304
2020-04-29 3:26 ` [PATCH v2 02/10] drm/ttm: separate PageHighMem() and PageHighMemZone() use case js1304
2020-04-29 3:26 ` [PATCH v2 03/10] kexec: " js1304
2020-05-01 14:03 ` Eric W. Biederman
2020-05-04 3:10 ` Joonsoo Kim
2020-05-04 14:03 ` Eric W. Biederman
2020-05-04 21:59 ` [RFC][PATCH] kexec: Teach indirect pages how to live in high memory Eric W. Biederman
2020-05-05 17:44 ` Hari Bathini
2020-05-05 18:39 ` Eric W. Biederman
2020-10-09 1:35 ` Joonsoo Kim
2020-05-06 5:23 ` [PATCH v2 03/10] kexec: separate PageHighMem() and PageHighMemZone() use case Joonsoo Kim
2020-04-29 3:26 ` [PATCH v2 04/10] power: " js1304
2020-05-01 12:22 ` Christoph Hellwig [this message]
2020-05-04 3:01 ` Joonsoo Kim
2020-04-29 3:26 ` [PATCH v2 05/10] mm/gup: " js1304
2020-05-01 12:24 ` Christoph Hellwig
2020-05-04 3:02 ` Joonsoo Kim
2020-04-29 3:26 ` [PATCH v2 06/10] mm/hugetlb: " js1304
2020-05-01 12:26 ` Christoph Hellwig
2020-05-04 3:03 ` Joonsoo Kim
2020-04-29 3:26 ` [PATCH v2 07/10] mm: " js1304
2020-05-01 12:30 ` Christoph Hellwig
2020-05-04 3:08 ` Joonsoo Kim
2020-04-29 3:26 ` [PATCH v2 08/10] mm/page_alloc: correct the use of is_highmem_idx() js1304
2020-04-29 3:26 ` [PATCH v2 09/10] mm/migrate: replace PageHighMem() with open-code js1304
2020-04-29 3:26 ` [PATCH v2 10/10] mm/page-flags: change the implementation of the PageHighMem() js1304
2020-04-30 1:47 ` [PATCH v2 00/10] " Andrew Morton
2020-05-01 10:52 ` Joonsoo Kim
2020-05-01 10:55 ` Christoph Hellwig
2020-05-01 12:15 ` Joonsoo Kim
2020-05-01 12:34 ` Christoph Hellwig
2020-05-04 3:09 ` Joonsoo Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200501122245.GA21897@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.ibm.com \
--cc=christian.koenig@amd.com \
--cc=ebiederm@xmission.com \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=js1304@gmail.com \
--cc=kernel-team@lge.com \
--cc=labbott@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@suse.com \
--cc=minchan@kernel.org \
--cc=pavel@ucw.cz \
--cc=ray.huang@amd.com \
--cc=riel@surriel.com \
--cc=rjw@rjwysocki.net \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).