From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA286C47257 for ; Fri, 1 May 2020 19:05:57 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7D48621835 for ; Fri, 1 May 2020 19:05:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="Pr5OeNBQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7D48621835 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 305678E0006; Fri, 1 May 2020 15:05:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2B5AD8E0001; Fri, 1 May 2020 15:05:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1A5478E0006; Fri, 1 May 2020 15:05:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0207.hostedemail.com [216.40.44.207]) by kanga.kvack.org (Postfix) with ESMTP id 042218E0001 for ; Fri, 1 May 2020 15:05:56 -0400 (EDT) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id C20373CF8 for ; Fri, 1 May 2020 19:05:56 +0000 (UTC) X-FDA: 76769079912.03.fire76_8b29dda26cf0e X-HE-Tag: fire76_8b29dda26cf0e X-Filterd-Recvd-Size: 5143 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf24.hostedemail.com (Postfix) with ESMTP for ; Fri, 1 May 2020 19:05:56 +0000 (UTC) Received: from paulmck-ThinkPad-P72.home (50-39-105-78.bvtn.or.frontiernet.net [50.39.105.78]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5BCE02173E; Fri, 1 May 2020 19:05:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588359955; bh=WFEAbiJuGiBc56bdGlx6e9LjlEwFLSX5UruuTUgU1Hw=; h=Date:From:To:Cc:Subject:Reply-To:References:In-Reply-To:From; b=Pr5OeNBQ9DlPdUbXC1upaqlySgvnzxf7IjJ5D1ZaEqkSSgYR5nbxiSxqKSifLtb5V cQ1pBuL2NKxRxDUjmzKtMC1S4QTm+2MJULv2G5TEcro1JUbSqLGtkVwRVhWafBzY87 yPfNfp7lIruW6+KsTw6sEcr8WyRKs0FGb6xhZg1w= Received: by paulmck-ThinkPad-P72.home (Postfix, from userid 1000) id 3E7503522690; Fri, 1 May 2020 12:05:55 -0700 (PDT) Date: Fri, 1 May 2020 12:05:55 -0700 From: "Paul E. McKenney" To: "Uladzislau Rezki (Sony)" Cc: LKML , linux-mm@kvack.org, Andrew Morton , "Theodore Y . Ts'o" , Matthew Wilcox , Joel Fernandes , RCU , Oleksiy Avramchenko Subject: Re: [PATCH 03/24] rcu/tree: Use consistent style for comments Message-ID: <20200501190555.GB7560@paulmck-ThinkPad-P72> Reply-To: paulmck@kernel.org References: <20200428205903.61704-1-urezki@gmail.com> <20200428205903.61704-4-urezki@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200428205903.61704-4-urezki@gmail.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Apr 28, 2020 at 10:58:42PM +0200, Uladzislau Rezki (Sony) wrote: > From: "Joel Fernandes (Google)" > > Simple clean up of comments in kfree_rcu() code to keep it consistent > with majority of commenting styles. > > Reviewed-by: Uladzislau Rezki > Signed-off-by: Joel Fernandes (Google) > Signed-off-by: Uladzislau Rezki (Sony) Hmmm... Exactly why is three additional characters per line preferable? Or in the case of block comments, either one or two additional lines, depending on /* */ style? I am (slowly) moving RCU to "//" for those reasons. ;-) Thanx, Paul > --- > kernel/rcu/tree.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c > index cd61649e1b00..1487af8e11e8 100644 > --- a/kernel/rcu/tree.c > +++ b/kernel/rcu/tree.c > @@ -3043,15 +3043,15 @@ static inline bool queue_kfree_rcu_work(struct kfree_rcu_cpu *krcp) > static inline void kfree_rcu_drain_unlock(struct kfree_rcu_cpu *krcp, > unsigned long flags) > { > - // Attempt to start a new batch. > + /* Attempt to start a new batch. */ > krcp->monitor_todo = false; > if (queue_kfree_rcu_work(krcp)) { > - // Success! Our job is done here. > + /* Success! Our job is done here. */ > raw_spin_unlock_irqrestore(&krcp->lock, flags); > return; > } > > - // Previous RCU batch still in progress, try again later. > + /* Previous RCU batch still in progress, try again later. */ > krcp->monitor_todo = true; > schedule_delayed_work(&krcp->monitor_work, KFREE_DRAIN_JIFFIES); > raw_spin_unlock_irqrestore(&krcp->lock, flags); > @@ -3151,14 +3151,14 @@ void kfree_call_rcu(struct rcu_head *head, rcu_callback_t func) > unsigned long flags; > struct kfree_rcu_cpu *krcp; > > - local_irq_save(flags); // For safely calling this_cpu_ptr(). > + local_irq_save(flags); /* For safely calling this_cpu_ptr(). */ > krcp = this_cpu_ptr(&krc); > if (krcp->initialized) > raw_spin_lock(&krcp->lock); > > - // Queue the object but don't yet schedule the batch. > + /* Queue the object but don't yet schedule the batch. */ > if (debug_rcu_head_queue(head)) { > - // Probable double kfree_rcu(), just leak. > + /* Probable double kfree_rcu(), just leak. */ > WARN_ONCE(1, "%s(): Double-freed call. rcu_head %p\n", > __func__, head); > goto unlock_return; > @@ -3176,7 +3176,7 @@ void kfree_call_rcu(struct rcu_head *head, rcu_callback_t func) > > WRITE_ONCE(krcp->count, krcp->count + 1); > > - // Set timer to drain after KFREE_DRAIN_JIFFIES. > + /* Set timer to drain after KFREE_DRAIN_JIFFIES. */ > if (rcu_scheduler_active == RCU_SCHEDULER_RUNNING && > !krcp->monitor_todo) { > krcp->monitor_todo = true; > @@ -3722,7 +3722,7 @@ int rcutree_offline_cpu(unsigned int cpu) > > rcutree_affinity_setting(cpu, cpu); > > - // nohz_full CPUs need the tick for stop-machine to work quickly > + /* nohz_full CPUs need the tick for stop-machine to work quickly */ > tick_dep_set(TICK_DEP_BIT_RCU); > return 0; > } > -- > 2.20.1 >