From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95004C28CBC for ; Mon, 4 May 2020 02:51:47 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 51981206EB for ; Mon, 4 May 2020 02:51:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="DWG7ZdI9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 51981206EB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D5C108E0005; Sun, 3 May 2020 22:51:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D0C908E0001; Sun, 3 May 2020 22:51:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C22548E0005; Sun, 3 May 2020 22:51:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0113.hostedemail.com [216.40.44.113]) by kanga.kvack.org (Postfix) with ESMTP id AAC278E0001 for ; Sun, 3 May 2020 22:51:46 -0400 (EDT) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 61E20180AD806 for ; Mon, 4 May 2020 02:51:46 +0000 (UTC) X-FDA: 76777511412.03.idea19_66bfe51c62c4c X-HE-Tag: idea19_66bfe51c62c4c X-Filterd-Recvd-Size: 3247 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by imf09.hostedemail.com (Postfix) with ESMTP for ; Mon, 4 May 2020 02:51:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1588560705; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3LaCbVlWjbzCuD40XLJY0jfLFr8/yA0ea/zELNcIVD4=; b=DWG7ZdI9Ijl+g/SQovrlveEjbLiXut6kdtiDaGIX7uAK+c/4wow8M0OK8goo8qglRSgZF+ 4bS6ssDcwDjXMLdHrrV4+hxc1fyrs6ozYMUWxVj6J8IOYtmcMUN5UJ463EAhTnhnngfGtZ C/LXlrS9TLcMnqsZl340/mo8sBGAuAU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-291-hfu3dCytO1GZC_r4ZmLjXA-1; Sun, 03 May 2020 22:51:43 -0400 X-MC-Unique: hfu3dCytO1GZC_r4ZmLjXA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D72141895A2A; Mon, 4 May 2020 02:51:41 +0000 (UTC) Received: from t490s (ovpn-112-64.phx2.redhat.com [10.3.112.64]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B74521001B30; Mon, 4 May 2020 02:51:40 +0000 (UTC) Date: Sun, 3 May 2020 22:51:38 -0400 From: Rafael Aquini To: Christopher Lameter Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, iamjoonsoo.kim@lge.com, rientjes@google.com, penberg@kernel.org Subject: Re: [PATCH] mm: slub: add panic_on_error to the debug facilities Message-ID: <20200504025138.GB18463@t490s> References: <20200501211540.71216-1-aquini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, May 02, 2020 at 11:16:30PM +0000, Christopher Lameter wrote: > On Fri, 1 May 2020, Rafael Aquini wrote: > > > Sometimes it is desirable to override SLUB's debug facilities > > default behavior upon stumbling on a cache or object error > > and just stop the execution in order to grab a coredump, at > > the error-spotting time, instead of trying to fix the issue > > and report in an attempt to keep the system rolling. > > The stopping of execution on an error is the default behavior. Usually > you get some OOPS somewhere when data is corrupted and that causes a core > dump. > > SLUB can fix the issue and continue if enabled by specifying special > options on boot. That is *not* the default. > It is the default behavior when slub_debug is turned on, which is what this patch is trying to override, when needed. We've been seeing the need for such feature as, most often than not, by letting the system running to crash somewhere else after hitting occurrences reported by slub_debug ends up clobbering clues to the original issue. -- Rafael