From: Michal Hocko <mhocko@kernel.org>
To: Yafang Shao <laoar.shao@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Shakeel Butt <shakeelb@google.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Roman Gushchin <guro@fb.com>, Greg Thelen <gthelen@google.com>,
Linux MM <linux-mm@kvack.org>
Subject: Re: [PATCH v2 2/2] mm, memcg: don't try to kill a process if memcg is not populated
Date: Mon, 4 May 2020 18:11:13 +0200 [thread overview]
Message-ID: <20200504161113.GV22838@dhcp22.suse.cz> (raw)
In-Reply-To: <CALOAHbBd6aUiqbg5ZTEQEiJH3s=E6anh6uP2wqAyXN_3UW8xxg@mail.gmail.com>
On Mon 04-05-20 23:24:35, Yafang Shao wrote:
> On Mon, May 4, 2020 at 8:46 PM Michal Hocko <mhocko@kernel.org> wrote:
[...]
> > But the oom situation and the oom report is simply something an admin
> > has to expect especially when the hard limit is set to 0. With kmem
> > accounting there is no guarantee that the target will be met.
>
> I'm always wondering that why not moving the kmem from this memcg to
> the root_mem_cgroup in this situation ?
> Then this memcg can be easily reclaimed.
Roman was playing with kmem charges reparenting. But please note that
this alone would be sufficient. Even LRU pages are not guaranteed to be
reclaimable - think of the full swap space, memory might be pinned etc.
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2020-05-04 16:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-04 4:26 [PATCH v2 0/2]memcg oom: don't try to kill a process if there is no process Yafang Shao
2020-05-04 4:26 ` [PATCH v2 1/2] mm, memcg: rename mem_cgroup_out_of_memory() Yafang Shao
2020-05-04 7:59 ` Michal Hocko
2020-05-04 15:50 ` Chris Down
2020-05-04 4:26 ` [PATCH v2 2/2] mm, memcg: don't try to kill a process if memcg is not populated Yafang Shao
2020-05-04 8:18 ` Michal Hocko
2020-05-04 12:34 ` Yafang Shao
2020-05-04 12:46 ` Michal Hocko
2020-05-04 15:24 ` Yafang Shao
2020-05-04 16:11 ` Michal Hocko [this message]
2020-05-04 17:04 ` Roman Gushchin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200504161113.GV22838@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=gthelen@google.com \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=laoar.shao@gmail.com \
--cc=linux-mm@kvack.org \
--cc=shakeelb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).