From: Andrew Morton <akpm@linux-foundation.org>
To: Walter Wu <walter-zh.wu@mediatek.com>
Cc: Bart Van Assche <bvanassche@acm.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>,
Josh Poimboeuf <jpoimboe@redhat.com>, <linux-mm@kvack.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>,
wsd_upstream <wsd_upstream@mediatek.com>
Subject: Re: [PATCH v2] stacktrace: cleanup inconsistent variable type
Date: Thu, 7 May 2020 17:04:48 -0700 [thread overview]
Message-ID: <20200507170448.661b1ef6cf8d870bb19e8cc6@linux-foundation.org> (raw)
In-Reply-To: <1588731504.7745.3.camel@mtksdccf07>
On Wed, 6 May 2020 10:18:24 +0800 Walter Wu <walter-zh.wu@mediatek.com> wrote:
> On Wed, 2020-04-22 at 18:21 -0700, Bart Van Assche wrote:
> > On 4/20/20 6:35 PM, Walter Wu wrote:
> > > Modify the variable type of 'skip' member of struct stack_trace.
> > > In theory, the 'skip' variable type should be unsigned int.
> > > There are two reasons:
> > > - The 'skip' only has two situation, 1)Positive value, 2)Zero
> > > - The 'skip' of struct stack_trace has inconsistent type with struct
> > > stack_trace_data, it makes a bit confusion in the relationship between
> > > struct stack_trace and stack_trace_data.
> >
> > Reviewed-by: Bart Van Assche <bvanassche@acm.org>
>
> Hi Andrew,
>
> Would you know why not to be picked up this patch yet?
> Do I miss somethings?
I'd decided to pass on this because it's so minor. We inappropriately
use signed types in soooo many places :(
prev parent reply other threads:[~2020-05-08 0:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-21 1:35 [PATCH v2] stacktrace: cleanup inconsistent variable type Walter Wu
2020-04-23 1:21 ` Bart Van Assche
2020-05-06 2:18 ` Walter Wu
2020-05-08 0:04 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200507170448.661b1ef6cf8d870bb19e8cc6@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=bvanassche@acm.org \
--cc=jpoimboe@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mm@kvack.org \
--cc=matthias.bgg@gmail.com \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=walter-zh.wu@mediatek.com \
--cc=wsd_upstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).