From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 496F8C38A2A for ; Thu, 7 May 2020 20:41:56 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id EF77F2497A for ; Thu, 7 May 2020 20:41:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cmpxchg-org.20150623.gappssmtp.com header.i=@cmpxchg-org.20150623.gappssmtp.com header.b="Nwem4RCa" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EF77F2497A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cmpxchg.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 88FBC900003; Thu, 7 May 2020 16:41:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 83F09900002; Thu, 7 May 2020 16:41:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 75427900003; Thu, 7 May 2020 16:41:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0250.hostedemail.com [216.40.44.250]) by kanga.kvack.org (Postfix) with ESMTP id 5C4F2900002 for ; Thu, 7 May 2020 16:41:55 -0400 (EDT) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 2406C180ACF75 for ; Thu, 7 May 2020 20:41:55 +0000 (UTC) X-FDA: 76791094590.12.van13_10b0e7d469a19 X-HE-Tag: van13_10b0e7d469a19 X-Filterd-Recvd-Size: 4234 Received: from mail-qt1-f194.google.com (mail-qt1-f194.google.com [209.85.160.194]) by imf08.hostedemail.com (Postfix) with ESMTP for ; Thu, 7 May 2020 20:41:54 +0000 (UTC) Received: by mail-qt1-f194.google.com with SMTP id j2so6019238qtr.12 for ; Thu, 07 May 2020 13:41:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=2sEB/hg7nI765KO+sGVWwlpeLWhkT2BGkQB6agKb2hg=; b=Nwem4RCafQxZA33I/DLrM69yNQA3krWl4ud0UnNMG9VzRbX1rvD+mOYuD9jq8gQtVM hm1F/6YeZSVOG/YCsce0dv+dEffsc/eU+lVTscpPG7eP2PfZa10dW6MWDhglGxaucNyC Wig6bmpO7u4wivFDSS1LpFdCu6EGCsWQ8CXryFVeqGh/giUrPy0jD2CcXqQFWaPesihT l16e2vDapQh6mqjA9/QHI48HmABDeBlYiZ3UHtY4IVulYJcM1AfSvd/2cZ1rCQgAVN2y Pcz/cuf2p0U1WGJW0UUJB0S57uDbXVgrLIthO6cBbGMzFmvwWDbfWD0qPuvo4NNor1WX 5hMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=2sEB/hg7nI765KO+sGVWwlpeLWhkT2BGkQB6agKb2hg=; b=CKITsNzPM/JbSotNvYDgIVKuhZSfDcduG7e8IX4w62gIYUStrBj8eTJ8KeG93DQmdH Efrqet/xXnntlcCx3yZFGaIzuxwg7XbqBtxnagLYe4Tb+Nc2MfbVxi9pclhJbkg1Sqhp Z4oqY3mQSCoLXQcpzKB1u9IRlCWKqjxAD3QzJocxRoj+Igt8Fmf9YoSh7RSwAZxmpJL3 ZksreNeZB01f0I+qbuJJjqq8qx1fHfNTx5OMWDXv99qOOETLKf4L5XdSw3dwIrH5sqZc GFH1viv6+CD7snu6CHYELtpv0PcUSl6VNZc3hiF0YLJGxCdZ+jWi9S0xMVmN9ORbNd4D q3ZQ== X-Gm-Message-State: AGi0PubQwV9pIdSoziZj4zRqCz08kDMLVIYkkNcd6YGd6JzYkVoCML74 3RCp+saLhhm7aU//y/S/lH4krQ== X-Google-Smtp-Source: APiQypKszgJEMRP8Wa0a+vGtxubxhiQ2T7LYaAqJ2CJ4vo+zNuL6wJK0NFwLDuRPylFmT2sYsTlGYg== X-Received: by 2002:ac8:120a:: with SMTP id x10mr16458805qti.127.1588884113745; Thu, 07 May 2020 13:41:53 -0700 (PDT) Received: from localhost (70.44.39.90.res-cmts.bus.ptd.net. [70.44.39.90]) by smtp.gmail.com with ESMTPSA id v130sm5056159qkb.39.2020.05.07.13.41.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 May 2020 13:41:53 -0700 (PDT) Date: Thu, 7 May 2020 16:41:37 -0400 From: Johannes Weiner To: Roman Gushchin Cc: Andrew Morton , Michal Hocko , linux-mm@kvack.org, kernel-team@fb.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 03/19] mm: memcg: convert vmstat slab counters to bytes Message-ID: <20200507204137.GC161043@cmpxchg.org> References: <20200422204708.2176080-1-guro@fb.com> <20200422204708.2176080-4-guro@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200422204708.2176080-4-guro@fb.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Apr 22, 2020 at 01:46:52PM -0700, Roman Gushchin wrote: > In order to prepare for per-object slab memory accounting, convert > NR_SLAB_RECLAIMABLE and NR_SLAB_UNRECLAIMABLE vmstat items to bytes. > > To make it obvious, rename them to NR_SLAB_RECLAIMABLE_B and > NR_SLAB_UNRECLAIMABLE_B (similar to NR_KERNEL_STACK_KB). > > Internally global and per-node counters are stored in pages, > however memcg and lruvec counters are stored in bytes. > This scheme may look weird, but only for now. As soon as slab > pages will be shared between multiple cgroups, global and > node counters will reflect the total number of slab pages. > However memcg and lruvec counters will be used for per-memcg > slab memory tracking, which will take separate kernel objects > in the account. Keeping global and node counters in pages helps > to avoid additional overhead. > > The size of slab memory shouldn't exceed 4Gb on 32-bit machines, > so it will fit into atomic_long_t we use for vmstats. > > Signed-off-by: Roman Gushchin Acked-by: Johannes Weiner Thanks for splitting this out, it makes both this and the previous patch easier to read.