From: Mike Rapoport <rppt@linux.ibm.com>
To: qiwuchen55@gmail.com
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
chenqiwu <chenqiwu@xiaomi.com>
Subject: Re: [PATCH] mm: memblock: fix minor typo and unclear comment
Date: Sat, 9 May 2020 19:01:37 +0300 [thread overview]
Message-ID: <20200509160137.GA801504@linux.ibm.com> (raw)
In-Reply-To: <1588846952-32166-1-git-send-email-qiwuchen55@gmail.com>
On Thu, May 07, 2020 at 06:22:32PM +0800, qiwuchen55@gmail.com wrote:
> From: chenqiwu <chenqiwu@xiaomi.com>
>
> Fix a minor typo "usabe->usable" for the current discription
> of member variable "memory" in struct memblock.
>
> BTW, I think it's unclear the member variable "base" in
> struct memblock_type is currently described as the physical
> address of memory region, change it to base address of the
> region is clearer since the variable is decorated as phys_addr_t.
>
> Signed-off-by: chenqiwu <chenqiwu@xiaomi.com>
Reviewed-by: Mike Rapoport <rppt@linux.ibm.com>
> ---
> include/linux/memblock.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/memblock.h b/include/linux/memblock.h
> index 6bc37a7..b594e0b 100644
> --- a/include/linux/memblock.h
> +++ b/include/linux/memblock.h
> @@ -41,7 +41,7 @@ enum memblock_flags {
>
> /**
> * struct memblock_region - represents a memory region
> - * @base: physical address of the region
> + * @base: base address of the region
> * @size: size of the region
> * @flags: memory region attributes
> * @nid: NUMA node id
> @@ -75,7 +75,7 @@ struct memblock_type {
> * struct memblock - memblock allocator metadata
> * @bottom_up: is bottom up direction?
> * @current_limit: physical address of the current allocation limit
> - * @memory: usabe memory regions
> + * @memory: usable memory regions
> * @reserved: reserved memory regions
> * @physmem: all physical memory
> */
> --
> 1.9.1
>
--
Sincerely yours,
Mike.
prev parent reply other threads:[~2020-05-09 16:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-07 10:22 [PATCH] mm: memblock: fix minor typo and unclear comment qiwuchen55
2020-05-09 16:01 ` Mike Rapoport [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200509160137.GA801504@linux.ibm.com \
--to=rppt@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=chenqiwu@xiaomi.com \
--cc=linux-mm@kvack.org \
--cc=qiwuchen55@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).