From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D65FC54E4A for ; Mon, 11 May 2020 13:49:58 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D51E72080C for ; Mon, 11 May 2020 13:49:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="fTLHNSai" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D51E72080C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 516DA900055; Mon, 11 May 2020 09:49:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4C707900036; Mon, 11 May 2020 09:49:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 38F20900055; Mon, 11 May 2020 09:49:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0207.hostedemail.com [216.40.44.207]) by kanga.kvack.org (Postfix) with ESMTP id 1DB0B900036 for ; Mon, 11 May 2020 09:49:57 -0400 (EDT) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id C6F7C181AEF09 for ; Mon, 11 May 2020 13:49:56 +0000 (UTC) X-FDA: 76804571592.06.fly39_90fd448ce521f X-HE-Tag: fly39_90fd448ce521f X-Filterd-Recvd-Size: 5395 Received: from mail-qk1-f193.google.com (mail-qk1-f193.google.com [209.85.222.193]) by imf42.hostedemail.com (Postfix) with ESMTP for ; Mon, 11 May 2020 13:49:56 +0000 (UTC) Received: by mail-qk1-f193.google.com with SMTP id n14so9729383qke.8 for ; Mon, 11 May 2020 06:49:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=4rPpMLzUp9bspNeARk829RL9zhdg6LdCbnWGM4mXn5M=; b=fTLHNSaidCTBTVafRZ88/JPpZndAW4JKAiqp+xUjmlcGq11JBx+zkoc/gLYyuRZMpU 8huyG7Lesc6lj13AkjhSbtSdyaW0HhfFpl0iYlVpDT1IiP7SHlaVI+MZSY7RwrTYhtBq RQNBgrM8IvriB2Mvvs4e8HQwdfhdtIbJbykV3RNu3vDxx3lnpyWu6MdARnOn+R62z8Jc KN8rcWegPekMEUZip8kruV0JwYQbPzQPKIlrCHz/KHExck9xbphKWhwcVarhbGi64Uoa alGo+ohiWuSyQC8pRj3oZO/AC0G930Xueg4XAOk+AAPwsMsi4evR7ZHEiIxrpqeKQKyH 7Trg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=4rPpMLzUp9bspNeARk829RL9zhdg6LdCbnWGM4mXn5M=; b=U98f1s3lF1IwFs1ie89YyzZvBLbJ4FKDS6Iyk50AubpxCxykQkTXaVmMwu818dviHi RrRFcgrKPKgnO1NBJ3el0w0MYY426GIPqKalUiQhWyEmsT/q9HZbGOhLF6TT/qY79n7B jRttjLQJOKyt+CM1kQ2urjH10MHmKDKB/vaN/q+p49XheMcTOaXDjhEv3qSyv/9Hl/O5 PtZE++k6rM3C/973YlSWG8RzoCZi7QgKnOjzp+WGZNLkzEn186jdjPB9dCnF3MDKWQT+ g6gnYPne9xBpU5upZmGgoJJ55QQslFZuUBib4bXa4hwvEoZle+z+uKaK1VZmoMTioYRO QmXg== X-Gm-Message-State: AGi0PuZDCTq4xxrraEQpawHy39Tg/9lto/mcV3Y25RIb0A9p5A21nYZU O9Wo1HcweDpvr8G6JfkZp6cnQA== X-Google-Smtp-Source: APiQypJNAQ0/U/AQ7HD5Ea1GoiCuDrCNke0sGrNZi0ZXjdmU+vdOsV+r7iIZyEfm/aW74L1CSMAM/Q== X-Received: by 2002:a05:620a:2019:: with SMTP id c25mr15376455qka.320.1589204995576; Mon, 11 May 2020 06:49:55 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-68-57-212.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.68.57.212]) by smtp.gmail.com with ESMTPSA id i10sm1542178qkk.128.2020.05.11.06.49.54 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 11 May 2020 06:49:55 -0700 (PDT) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1jY8oc-0005UB-FF; Mon, 11 May 2020 10:49:54 -0300 Date: Mon, 11 May 2020 10:49:54 -0300 From: Jason Gunthorpe To: Andrew Morton Cc: linux-mm@kvack.org, Ralph Campbell , Alex Deucher , amd-gfx@lists.freedesktop.org, Ben Skeggs , Christian =?utf-8?B?S8O2bmln?= , "David (ChunMing) Zhou" , dri-devel@lists.freedesktop.org, Felix Kuehling , Christoph Hellwig , intel-gfx@lists.freedesktop.org, =?utf-8?B?SsOpcsO0bWU=?= Glisse , John Hubbard , linux-kernel@vger.kernel.org, Niranjana Vishwanathapura , nouveau@lists.freedesktop.org, "Yang, Philip" Subject: Re: [PATCH hmm v2 1/5] mm/hmm: make CONFIG_DEVICE_PRIVATE into a select Message-ID: <20200511134954.GS26002@ziepe.ca> References: <0-v2-b4e84f444c7d+24f57-hmm_no_flags_jgg@mellanox.com> <1-v2-b4e84f444c7d+24f57-hmm_no_flags_jgg@mellanox.com> <20200509171612.94ee332ad4f494521d911ac0@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200509171612.94ee332ad4f494521d911ac0@linux-foundation.org> User-Agent: Mutt/1.9.4 (2018-02-28) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, May 09, 2020 at 05:16:12PM -0700, Andrew Morton wrote: > On Fri, 1 May 2020 15:20:44 -0300 Jason Gunthorpe wrote: > > > From: Jason Gunthorpe > > > > There is no reason for a user to select this or not directly - it should > > be selected by drivers that are going to use the feature, similar to how > > CONFIG_HMM_MIRROR works. > > > > Currently all drivers provide a feature kconfig that will disable use of > > DEVICE_PRIVATE in that driver, allowing users to avoid enabling this if > > they don't want the overhead. > > > > I'm not too sure what's going on here, but i386 allmodconfig broke. > > kernel/resource.c: In function '__request_free_mem_region': > kernel/resource.c:1653:28: error: 'PA_SECTION_SHIFT' undeclared (first use in this function); did you mean 'SECTIONS_PGSHIFT'? > size = ALIGN(size, 1UL << PA_SECTION_SHIFT); > > because in current mainline, allmodconfig produces > CONFIG_DEVICE_PRIVATE=n but in current linux-next, allmodconfig > produces CONFIG_DEVICE_PRIVATE=y. But CONFIG_SPARSEMEM=n so the build > breaks. I think Arnd identified this, let us just revet the patch that caused it. > Bisection fingers this commit, but reverting it doesn't seem to fix > things. Could you take a look please? There is a latter patch adding a 'select DEVICE_PRIVATE' so reverting this needs to swap that to 'depends on'. I've done both and updated git Regards, Jason