From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8578C433E1 for ; Thu, 14 May 2020 02:24:14 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7653C20671 for ; Thu, 14 May 2020 02:24:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="id1EXOEF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7653C20671 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C4D2F80049; Wed, 13 May 2020 22:24:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BFCB88003E; Wed, 13 May 2020 22:24:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B12B280049; Wed, 13 May 2020 22:24:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0241.hostedemail.com [216.40.44.241]) by kanga.kvack.org (Postfix) with ESMTP id 9E3AE8003E for ; Wed, 13 May 2020 22:24:13 -0400 (EDT) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 598C08248D7C for ; Thu, 14 May 2020 02:24:13 +0000 (UTC) X-FDA: 76813729986.21.tree09_7b646d195a61 X-HE-Tag: tree09_7b646d195a61 X-Filterd-Recvd-Size: 2085 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf13.hostedemail.com (Postfix) with ESMTP for ; Thu, 14 May 2020 02:24:12 +0000 (UTC) Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7B9DB205CB; Thu, 14 May 2020 02:24:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589423051; bh=UVerhlpWBnLUUTLMgvH5z644AkRhrk9PQ0XJpWm7g8M=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=id1EXOEFsd9NC1A7aiFHA4gSUodqeY9yIpipJA6+7ELcRpMpRB/0ELix/ATkp7ZYI uj/3MThBJaNdh/tCdE9dQXzNGxGaifQDvK/jm4mvju7sX15Fr+uQHHwhdFMr93qak1 4meo2CK7yOV361bnxPMBb/8OGWnWGNJZmdtAfK1c= Date: Wed, 13 May 2020 19:24:10 -0700 From: Andrew Morton To: Johannes Weiner Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Dave Chinner , Yafang Shao , Michal Hocko , Roman Gushchin , Linus Torvalds , Al Viro , kernel-team@fb.com Subject: Re: [PATCH] vfs: keep inodes with page cache off the inode shrinker LRU Message-Id: <20200513192410.157747af4dee2da5aa0a50b1@linux-foundation.org> In-Reply-To: <20200512212936.GA450429@cmpxchg.org> References: <20200211175507.178100-1-hannes@cmpxchg.org> <20200512212936.GA450429@cmpxchg.org> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 12 May 2020 17:29:36 -0400 Johannes Weiner wrote: > + inode_pages_clear(mapping->inode); > + else if (populated == 1) > + inode_pages_set(mapping->inode); mapping->host... I have to assume this version wasn't runtime tested, so I'll drop it.