From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CAFD0C433DF for ; Fri, 15 May 2020 08:29:59 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 876B7206F1 for ; Fri, 15 May 2020 08:29:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 876B7206F1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D443E90000C; Fri, 15 May 2020 04:29:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CF50E8E0005; Fri, 15 May 2020 04:29:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C0A4C90000C; Fri, 15 May 2020 04:29:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0147.hostedemail.com [216.40.44.147]) by kanga.kvack.org (Postfix) with ESMTP id A85A48E0005 for ; Fri, 15 May 2020 04:29:58 -0400 (EDT) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 6A6D7181AEF00 for ; Fri, 15 May 2020 08:29:58 +0000 (UTC) X-FDA: 76818280476.04.bag76_39ee771783e62 X-HE-Tag: bag76_39ee771783e62 X-Filterd-Recvd-Size: 6247 Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by imf49.hostedemail.com (Postfix) with ESMTP for ; Fri, 15 May 2020 08:29:57 +0000 (UTC) Received: by mail-wm1-f66.google.com with SMTP id w64so1651812wmg.4 for ; Fri, 15 May 2020 01:29:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=AffiWICTihWrD0jhH/25k+Jany7wx9bJeNI7R897D5A=; b=D8pi4RbF0b0APuzz6NS2N1JzkIKXfkzJe3hsAa1C7oDMjzlH2ILQeSPvo59Tl+sRZu qqzeA8YFy6zY4bcD/agJ8wGsbYsp76uczbEomp2TR0aY2dPcCMGfasvH6f1Kdu2DZeTq MqFVCEDR3o0uAdRrQmoYF37eiqJjP+tP3vZ3P/C7d/MAL4j9mw82ZOjSjOP1x2898NAr SIzJwqd5hcE+7Mi3Z5FArwKkHO8/GiTlhZHDS84OKJb+RBQdhH1bWx3lbMDycUcV4wE3 l7DW4wgKwTQSd04jZS9YmkDYecNsobhW+uFHqKxgRWSdJhp7wJ+0MisLqJnso8DZXpcF axKw== X-Gm-Message-State: AOAM531qp6Jfw7t22rxw5L4iycn8UNhQKYLwZ3Esxb8xH5EPIvCxOh8J xjokzKr+uinbC9Dlz7ouYuY= X-Google-Smtp-Source: ABdhPJwIeOGeKtkO402/Kz2PFC3Ze6Zk4Xt5gmJSEXDWr6dlaKMniPW1X/R4tk3nopbtZrNkt/8Dyg== X-Received: by 2002:a05:600c:231a:: with SMTP id 26mr2882752wmo.59.1589531396993; Fri, 15 May 2020 01:29:56 -0700 (PDT) Received: from localhost (ip-37-188-249-36.eurotel.cz. [37.188.249.36]) by smtp.gmail.com with ESMTPSA id h137sm54689649wme.0.2020.05.15.01.29.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 May 2020 01:29:56 -0700 (PDT) Date: Fri, 15 May 2020 10:29:55 +0200 From: Michal Hocko To: Shakeel Butt Cc: Johannes Weiner , Mel Gorman , Roman Gushchin , Andrew Morton , Yafang Shao , Linux MM , Cgroups , LKML Subject: Re: [PATCH] memcg: expose root cgroup's memory.stat Message-ID: <20200515082955.GJ29153@dhcp22.suse.cz> References: <20200508170630.94406-1-shakeelb@google.com> <20200508214405.GA226164@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat 09-05-20 07:06:38, Shakeel Butt wrote: > On Fri, May 8, 2020 at 2:44 PM Johannes Weiner wrote: > > > > On Fri, May 08, 2020 at 10:06:30AM -0700, Shakeel Butt wrote: > > > One way to measure the efficiency of memory reclaim is to look at the > > > ratio (pgscan+pfrefill)/pgsteal. However at the moment these stats are > > > not updated consistently at the system level and the ratio of these are > > > not very meaningful. The pgsteal and pgscan are updated for only global > > > reclaim while pgrefill gets updated for global as well as cgroup > > > reclaim. > > > > > > Please note that this difference is only for system level vmstats. The > > > cgroup stats returned by memory.stat are actually consistent. The > > > cgroup's pgsteal contains number of reclaimed pages for global as well > > > as cgroup reclaim. So, one way to get the system level stats is to get > > > these stats from root's memory.stat, so, expose memory.stat for the root > > > cgroup. > > > > > > from Johannes Weiner: > > > There are subtle differences between /proc/vmstat and > > > memory.stat, and cgroup-aware code that wants to watch the full > > > hierarchy currently has to know about these intricacies and > > > translate semantics back and forth. Can we have those subtle differences documented please? > > > > > > Generally having the fully recursive memory.stat at the root > > > level could help a broader range of usecases. > > > > The changelog begs the question why we don't just "fix" the > > system-level stats. It may be useful to include the conclusions from > > that discussion, and why there is value in keeping the stats this way. > > > > Right. Andrew, can you please add the following para to the changelog? > > Why not fix the stats by including both the global and cgroup reclaim > activity instead of exposing root cgroup's memory.stat? The reason is > the benefit of having metrics exposing the activity that happens > purely due to machine capacity rather than localized activity that > happens due to the limits throughout the cgroup tree. Additionally > there are userspace tools like sysstat(sar) which reads these stats to > inform about the system level reclaim activity. So, we should not > break such use-cases. > > > > Signed-off-by: Shakeel Butt > > > Suggested-by: Johannes Weiner > > > > Acked-by: Johannes Weiner > > Thanks a lot. I was quite surprised that the patch is so simple TBH. For some reason I've still had memories that we do not account for root memcg (likely because mem_cgroup_is_root(memcg) bail out in the try_charge. But stats are slightly different here. I have started looking at different stat counters because they are not really all the same. E.g. - mem_cgroup_charge_statistics accounts for each memcg - memcg_charge_kernel_stack relies on pages being associated with a memcg and that in turn relies on __memcg_kmem_charge_page which bails out on root memcg - memcg_charge_slab (NR_SLAB*) skips over root memcg as well - __mod_lruvec_page_state relies on page->mem_cgroup as well but this one is ok for paths which go through commit_charge path. That being said we should really double check which stats are accounted properly. At least MEMCG_KERNEL_STACK_KB won't unless I am misreading the code. I do not mind displaying the root's memcg stats but a) a closer look had to be done for each counter and b) a clarification of differences from the global vmstat counters would be really handy. -- Michal Hocko SUSE Labs