From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4409FC433E1 for ; Tue, 19 May 2020 05:46:12 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id F26A620872 for ; Tue, 19 May 2020 05:46:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F26A620872 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 44FB4900003; Tue, 19 May 2020 01:46:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3D9A5900002; Tue, 19 May 2020 01:46:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2C839900003; Tue, 19 May 2020 01:46:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0130.hostedemail.com [216.40.44.130]) by kanga.kvack.org (Postfix) with ESMTP id 10FA4900002 for ; Tue, 19 May 2020 01:46:11 -0400 (EDT) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id BBAFC180AD81A for ; Tue, 19 May 2020 05:46:10 +0000 (UTC) X-FDA: 76832382900.29.spoon30_18c92b8219523 X-HE-Tag: spoon30_18c92b8219523 X-Filterd-Recvd-Size: 1763 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf36.hostedemail.com (Postfix) with ESMTP for ; Tue, 19 May 2020 05:46:10 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id F31C968B02; Tue, 19 May 2020 07:46:06 +0200 (CEST) Date: Tue, 19 May 2020 07:46:06 +0200 From: Christoph Hellwig To: Masami Hiramatsu Cc: Christoph Hellwig , x86@kernel.org, Alexei Starovoitov , Daniel Borkmann , Linus Torvalds , Andrew Morton , linux-parisc@vger.kernel.org, linux-um@lists.infradead.org, netdev@vger.kernel.org, bpf@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 10/18] maccess: unify the probe kernel arch hooks Message-ID: <20200519054606.GA23853@lst.de> References: <20200513160038.2482415-1-hch@lst.de> <20200513160038.2482415-11-hch@lst.de> <20200514101318.1c14647e41b7038b99b91fcd@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200514101318.1c14647e41b7038b99b91fcd@kernel.org> User-Agent: Mutt/1.5.17 (2007-11-01) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000006, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, May 14, 2020 at 10:13:18AM +0900, Masami Hiramatsu wrote: > > + bool strict) > > { > > long ret; > > mm_segment_t old_fs = get_fs(); > > > > + if (!probe_kernel_read_allowed(dst, src, size, strict)) > > + return -EFAULT; > > Could you make this return -ERANGE instead of -EFAULT so that > the caller can notice that the address might be user space? That is clearly a behavior change, so I don't want to mix it into this patch. But I can add it as another patch at the end.