From: Jakub Kicinski <kuba@kernel.org>
To: akpm@linux-foundation.org
Cc: linux-mm@kvack.org, kernel-team@fb.com, tj@kernel.org,
hannes@cmpxchg.org, chris@chrisdown.name,
cgroups@vger.kernel.org, shakeelb@google.com, mhocko@kernel.org,
Jakub Kicinski <kuba@kernel.org>
Subject: [PATCH mm v4 1/4] mm: prepare for swap over-high accounting and penalty calculation
Date: Tue, 19 May 2020 10:19:35 -0700 [thread overview]
Message-ID: <20200519171938.3569605-2-kuba@kernel.org> (raw)
In-Reply-To: <20200519171938.3569605-1-kuba@kernel.org>
Slice the memory overage calculation logic a little bit so we can
reuse it to apply a similar penalty to the swap. The logic which
accesses the memory-specific fields (use and high values) has to
be taken out of calculate_high_delay().
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
mm/memcontrol.c | 62 ++++++++++++++++++++++++++++---------------------
1 file changed, 35 insertions(+), 27 deletions(-)
diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index 2df9510b7d64..0d05e6a593f5 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -2302,41 +2302,48 @@ static void high_work_func(struct work_struct *work)
#define MEMCG_DELAY_PRECISION_SHIFT 20
#define MEMCG_DELAY_SCALING_SHIFT 14
-/*
- * Get the number of jiffies that we should penalise a mischievous cgroup which
- * is exceeding its memory.high by checking both it and its ancestors.
- */
-static unsigned long calculate_high_delay(struct mem_cgroup *memcg,
- unsigned int nr_pages)
+static u64 calculate_overage(unsigned long usage, unsigned long high)
{
- unsigned long penalty_jiffies;
- u64 max_overage = 0;
-
- do {
- unsigned long usage, high;
- u64 overage;
+ u64 overage;
- usage = page_counter_read(&memcg->memory);
- high = READ_ONCE(memcg->high);
+ if (usage <= high)
+ return 0;
- if (usage <= high)
- continue;
+ /*
+ * Prevent division by 0 in overage calculation by acting as if
+ * it was a threshold of 1 page
+ */
+ high = max(high, 1UL);
- /*
- * Prevent division by 0 in overage calculation by acting as if
- * it was a threshold of 1 page
- */
- high = max(high, 1UL);
+ overage = usage - high;
+ overage <<= MEMCG_DELAY_PRECISION_SHIFT;
+ return div64_u64(overage, high);
+}
- overage = usage - high;
- overage <<= MEMCG_DELAY_PRECISION_SHIFT;
- overage = div64_u64(overage, high);
+static u64 mem_find_max_overage(struct mem_cgroup *memcg)
+{
+ u64 overage, max_overage = 0;
- if (overage > max_overage)
- max_overage = overage;
+ do {
+ overage = calculate_overage(page_counter_read(&memcg->memory),
+ READ_ONCE(memcg->high));
+ max_overage = max(overage, max_overage);
} while ((memcg = parent_mem_cgroup(memcg)) &&
!mem_cgroup_is_root(memcg));
+ return max_overage;
+}
+
+/*
+ * Get the number of jiffies that we should penalise a mischievous cgroup which
+ * is exceeding its memory.high by checking both it and its ancestors.
+ */
+static unsigned long calculate_high_delay(struct mem_cgroup *memcg,
+ unsigned int nr_pages,
+ u64 max_overage)
+{
+ unsigned long penalty_jiffies;
+
if (!max_overage)
return 0;
@@ -2392,7 +2399,8 @@ void mem_cgroup_handle_over_high(void)
* memory.high is breached and reclaim is unable to keep up. Throttle
* allocators proactively to slow down excessive growth.
*/
- penalty_jiffies = calculate_high_delay(memcg, nr_pages);
+ penalty_jiffies = calculate_high_delay(memcg, nr_pages,
+ mem_find_max_overage(memcg));
/*
* Don't sleep if the amount of jiffies this memcg owes us is so low
--
2.25.4
next prev parent reply other threads:[~2020-05-19 17:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-19 17:19 [PATCH mm v4 0/4] memcg: Slow down swap allocation as the available space gets depleted Jakub Kicinski
2020-05-19 17:19 ` Jakub Kicinski [this message]
2020-05-20 1:38 ` [PATCH mm v4 1/4] mm: prepare for swap over-high accounting and penalty calculation Shakeel Butt
2020-05-19 17:19 ` [PATCH mm v4 2/4] mm: move penalty delay clamping out of calculate_high_delay() Jakub Kicinski
2020-05-20 1:40 ` Shakeel Butt
2020-05-19 17:19 ` [PATCH mm v4 3/4] mm: move cgroup high memory limit setting into struct page_counter Jakub Kicinski
2020-05-19 22:15 ` Shakeel Butt
2020-05-19 23:14 ` Jakub Kicinski
2020-05-20 0:21 ` Shakeel Butt
2020-05-19 17:19 ` [PATCH mm v4 4/4] mm: automatically penalize tasks with high swap use Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200519171938.3569605-2-kuba@kernel.org \
--to=kuba@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=chris@chrisdown.name \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@fb.com \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=shakeelb@google.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).