From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 135C5C433DF for ; Fri, 22 May 2020 15:43:11 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C3EE02070A for ; Fri, 22 May 2020 15:43:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C3EE02070A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 46F2580008; Fri, 22 May 2020 11:43:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3F8D880007; Fri, 22 May 2020 11:43:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 30E3F80008; Fri, 22 May 2020 11:43:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0103.hostedemail.com [216.40.44.103]) by kanga.kvack.org (Postfix) with ESMTP id 15A7C80007 for ; Fri, 22 May 2020 11:43:10 -0400 (EDT) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id C65D6180AD80F for ; Fri, 22 May 2020 15:43:09 +0000 (UTC) X-FDA: 76844773698.08.pump13_1b8fbd2889a24 X-HE-Tag: pump13_1b8fbd2889a24 X-Filterd-Recvd-Size: 2783 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf37.hostedemail.com (Postfix) with ESMTP for ; Fri, 22 May 2020 15:43:09 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6B4E555D; Fri, 22 May 2020 08:43:08 -0700 (PDT) Received: from gaia (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 901663F305; Fri, 22 May 2020 08:43:00 -0700 (PDT) Date: Fri, 22 May 2020 16:42:55 +0100 From: Catalin Marinas To: Zhenyu Ye Cc: peterz@infradead.org, mark.rutland@arm.com, will@kernel.org, aneesh.kumar@linux.ibm.com, akpm@linux-foundation.org, npiggin@gmail.com, arnd@arndb.de, rostedt@goodmis.org, maz@kernel.org, suzuki.poulose@arm.com, tglx@linutronix.de, yuzhao@google.com, Dave.Martin@arm.com, steven.price@arm.com, broonie@kernel.org, guohanjun@huawei.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, arm@kernel.org, xiexiangyou@huawei.com, prime.zeng@hisilicon.com, zhangshaokun@hisilicon.com, kuhn.chenqun@huawei.com Subject: Re: [PATCH v2 5/6] mm: tlb: Provide flush_*_tlb_range wrappers Message-ID: <20200522154254.GD26492@gaia> References: <20200423135656.2712-1-yezhenyu2@huawei.com> <20200423135656.2712-6-yezhenyu2@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200423135656.2712-6-yezhenyu2@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Apr 23, 2020 at 09:56:55PM +0800, Zhenyu Ye wrote: > diff --git a/mm/pgtable-generic.c b/mm/pgtable-generic.c > index 3d7c01e76efc..3eff199d3507 100644 > --- a/mm/pgtable-generic.c > +++ b/mm/pgtable-generic.c > @@ -101,6 +101,28 @@ pte_t ptep_clear_flush(struct vm_area_struct *vma, unsigned long address, > > #ifdef CONFIG_TRANSPARENT_HUGEPAGE > > +#ifndef __HAVE_ARCH_FLUSH_PMD_TLB_RANGE > + > +#define FLUSH_Pxx_TLB_RANGE(_pxx) \ > +void flush_##_pxx##_tlb_range(struct vm_area_struct *vma, \ > + unsigned long addr, unsigned long end) \ > +{ \ > + struct mmu_gather tlb; \ > + \ > + tlb_gather_mmu(&tlb, vma->vm_mm, addr, end); \ > + tlb_start_vma(&tlb, vma); \ > + tlb_flush_##_pxx##_range(&tlb, addr, end - addr); \ > + tlb_end_vma(&tlb, vma); \ > + tlb_finish_mmu(&tlb, addr, end); \ > +} I may have confused myself (flush_p??_tlb_* vs. tlb_flush_p??_*) but do actually need this whole tlb_gather thing here? IIUC (by grep'ing), flush_p?d_tlb_range() is only called on huge pages, so we should know the level already. -- Catalin