From: Mike Rapoport <email@example.com> To: Linus Torvalds <firstname.lastname@example.org> Cc: Andrew Morton <email@example.com>, David Miller <firstname.lastname@example.org>, Linux-MM <email@example.com>, kernel test robot <firstname.lastname@example.org>, Anatoly Pugachev <email@example.com>, firstname.lastname@example.org, stable <email@example.com> Subject: Re: [patch 09/11] sparc32: use PUD rather than PGD to get PMD in srmmu_nocache_init() Date: Sat, 23 May 2020 22:57:15 +0300 Message-ID: <20200523195715.GY1059226@linux.ibm.com> (raw) In-Reply-To: <CAHk-=wisORTa7QVPnFqNw9pFs62UiwgsD4C4d=MtYy1o4JPyGQ@mail.gmail.com> On Sat, May 23, 2020 at 12:10:27PM -0700, Linus Torvalds wrote: > On Sat, May 23, 2020 at 12:02 PM Mike Rapoport <firstname.lastname@example.org> wrote: > > > > Unfortunately, this fixes a compile warning but breaks the boot :( > > Argh. I delayed applying/merging this overnight to see if there were > any reports, but this came in after I'd already merged Andrew's > patches and pushed them out. Actually, it's really by chance I noticed it tonight, although still it was too late :) > So it's in my tree now as commit c2bc26f7ca1f ("sparc32: use PUD > rather than PGD to get PMD in srmmu_nocache_init()") > > > The correcteted patch is below, boot tested with qemu-systems-sparc. > > Mind sending a patch relative to the previous one that already got merged? Sure. > Also, would it perhaps be worth it to just make __nocache_fix() not > throw the type away? IOW, make it do something like > > #define __nocache_fix(VADDR) \ > ((__typeof__(VADDR))__va(__nocache_pa(VADDR))) > > or whatever? Wouldn't that show when those pgd/p4d/pud pointers get > mis-used because they don't end up dropping the type info.. Yes, I'll look into it. > Linus -- Sincerely yours, Mike.
next prev parent reply index Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-05-23 5:22 incoming Andrew Morton 2020-05-23 5:22 ` [patch 01/11] device-dax: don't leak kernel memory to user space after unloading kmem Andrew Morton 2020-05-23 5:22 ` [patch 02/11] x86: bitops: fix build regression Andrew Morton 2020-05-23 5:22 ` [patch 03/11] rapidio: fix an error in get_user_pages_fast() error handling Andrew Morton 2020-05-23 5:22 ` [patch 04/11] selftests/vm/.gitignore: add mremap_dontunmap Andrew Morton 2020-05-23 5:22 ` [patch 05/11] selftests/vm/write_to_hugetlbfs.c: fix unused variable warning Andrew Morton 2020-05-23 5:22 ` [patch 06/11] kasan: disable branch tracing for core runtime Andrew Morton 2020-05-23 5:23 ` [patch 07/11] sh: include linux/time_types.h for sockios Andrew Morton 2020-05-23 5:23 ` [patch 08/11] MAINTAINERS: update email address for Naoya Horiguchi Andrew Morton 2020-05-23 5:23 ` [patch 09/11] sparc32: use PUD rather than PGD to get PMD in srmmu_nocache_init() Andrew Morton 2020-05-23 19:01 ` Mike Rapoport 2020-05-23 19:10 ` Linus Torvalds 2020-05-23 19:57 ` Mike Rapoport [this message] 2020-05-23 5:23 ` [patch 10/11] z3fold: fix use-after-free when freeing handles Andrew Morton 2020-05-23 5:23 ` [patch 11/11] MAINTAINERS: add files related to kdump Andrew Morton 2020-05-25 5:10 ` mmotm 2020-05-24-22-09 uploaded Andrew Morton 2020-05-25 23:57 ` mmotm 2020-05-25-16-56 uploaded Andrew Morton 2020-05-26 3:49 ` mmotm 2020-05-25-16-56 uploaded (drm/nouveau) Randy Dunlap 2020-05-26 4:23 ` Dave Airlie 2020-05-26 4:31 ` Randy Dunlap 2020-05-26 6:56 ` mmotm 2020-05-25-16-56 uploaded (mtd/nand/raw/arasan-nand-controller) Randy Dunlap
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200523195715.GY1059226@linux.ibm.com \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux-mm Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linux-mm/0 linux-mm/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-mm linux-mm/ https://lore.kernel.org/linux-mm \ firstname.lastname@example.org public-inbox-index linux-mm Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kvack.linux-mm AGPL code for this site: git clone https://public-inbox.org/public-inbox.git