From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1CFAC433E1 for ; Tue, 26 May 2020 14:52:53 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4535820776 for ; Tue, 26 May 2020 14:52:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4535820776 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B0597800B0; Tue, 26 May 2020 10:52:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AB69980061; Tue, 26 May 2020 10:52:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9CD00800B0; Tue, 26 May 2020 10:52:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0150.hostedemail.com [216.40.44.150]) by kanga.kvack.org (Postfix) with ESMTP id 8612580061 for ; Tue, 26 May 2020 10:52:52 -0400 (EDT) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 43B463CE9 for ; Tue, 26 May 2020 14:52:52 +0000 (UTC) X-FDA: 76859162184.19.cord69_704eeafc5a530 X-HE-Tag: cord69_704eeafc5a530 X-Filterd-Recvd-Size: 4766 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf46.hostedemail.com (Postfix) with ESMTP for ; Tue, 26 May 2020 14:52:51 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D055F30E; Tue, 26 May 2020 07:52:50 -0700 (PDT) Received: from gaia (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8BE253F7C3; Tue, 26 May 2020 07:52:47 -0700 (PDT) Date: Tue, 26 May 2020 15:52:45 +0100 From: Catalin Marinas To: Zhenyu Ye Cc: peterz@infradead.org, mark.rutland@arm.com, will@kernel.org, aneesh.kumar@linux.ibm.com, akpm@linux-foundation.org, npiggin@gmail.com, arnd@arndb.de, rostedt@goodmis.org, maz@kernel.org, suzuki.poulose@arm.com, tglx@linutronix.de, yuzhao@google.com, Dave.Martin@arm.com, steven.price@arm.com, broonie@kernel.org, guohanjun@huawei.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, arm@kernel.org, xiexiangyou@huawei.com, prime.zeng@hisilicon.com, zhangshaokun@hisilicon.com, kuhn.chenqun@huawei.com Subject: Re: [PATCH v2 5/6] mm: tlb: Provide flush_*_tlb_range wrappers Message-ID: <20200526145244.GG17051@gaia> References: <20200423135656.2712-1-yezhenyu2@huawei.com> <20200423135656.2712-6-yezhenyu2@huawei.com> <20200522154254.GD26492@gaia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, May 25, 2020 at 03:19:42PM +0800, Zhenyu Ye wrote: > On 2020/5/22 23:42, Catalin Marinas wrote: > > On Thu, Apr 23, 2020 at 09:56:55PM +0800, Zhenyu Ye wrote: > >> diff --git a/mm/pgtable-generic.c b/mm/pgtable-generic.c > >> index 3d7c01e76efc..3eff199d3507 100644 > >> --- a/mm/pgtable-generic.c > >> +++ b/mm/pgtable-generic.c > >> @@ -101,6 +101,28 @@ pte_t ptep_clear_flush(struct vm_area_struct *vma, unsigned long address, > >> > >> #ifdef CONFIG_TRANSPARENT_HUGEPAGE > >> > >> +#ifndef __HAVE_ARCH_FLUSH_PMD_TLB_RANGE > >> + > >> +#define FLUSH_Pxx_TLB_RANGE(_pxx) \ > >> +void flush_##_pxx##_tlb_range(struct vm_area_struct *vma, \ > >> + unsigned long addr, unsigned long end) \ > >> +{ \ > >> + struct mmu_gather tlb; \ > >> + \ > >> + tlb_gather_mmu(&tlb, vma->vm_mm, addr, end); \ > >> + tlb_start_vma(&tlb, vma); \ > >> + tlb_flush_##_pxx##_range(&tlb, addr, end - addr); \ > >> + tlb_end_vma(&tlb, vma); \ > >> + tlb_finish_mmu(&tlb, addr, end); \ > >> +} > > > > I may have confused myself (flush_p??_tlb_* vs. tlb_flush_p??_*) but do > > actually need this whole tlb_gather thing here? IIUC (by grep'ing), > > flush_p?d_tlb_range() is only called on huge pages, so we should know > > the level already. > > tlb_flush_##_pxx##_range() is used to set tlb->cleared_*, > flush_##_pxx##_tlb_range() will actually flush the TLB entry. > > In arch64, tlb_flush_p?d_range() is defined as: > > #define flush_pmd_tlb_range(vma, addr, end) flush_tlb_range(vma, addr, end) > #define flush_pud_tlb_range(vma, addr, end) flush_tlb_range(vma, addr, end) Currently, flush_p??_tlb_range() are generic and defined as above. I think in the generic code they can remain an alias for flush_tlb_range(). On arm64, we can redefine them as: #define flush_pte_tlb_range(vma, addr, end) __flush_tlb_range(vma, addr, end, 3) #define flush_pmd_tlb_range(vma, addr, end) __flush_tlb_range(vma, addr, end, 2) #define flush_pud_tlb_range(vma, addr, end) __flush_tlb_range(vma, addr, end, 1) #define flush_p4d_tlb_range(vma, addr, end) __flush_tlb_range(vma, addr, end, 0) (unless the compiler optimises away all the mmu_gather stuff in your macro above but they don't look trivial to me) Also, I don't see the new flush_pte_* and flush_p4d_* macros used anywhere and I don't think they are needed. The pte equivalent is flush_tlb_page() (we need to make sure it's not used on a pmd in the hugetlb context). > So even if we know the level here, we can not pass the value to tlbi > instructions (flush_tlb_range() is a common kernel interface and retro-fit it > needs lots of changes), according to Peter's suggestion, I finally decide to > pass the value of TTL by the tlb_gather_* frame.[1] My comment was about the generic implementation using mmu_gather as you are proposing. We don't need to change the flush_tlb_range() interface, nor do we need to rewrite flush_p??_tlb_range(). -- Catalin