From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9554DC433DF for ; Tue, 26 May 2020 19:51:51 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4DCC02088E for ; Tue, 26 May 2020 19:51:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=kernel-dk.20150623.gappssmtp.com header.i=@kernel-dk.20150623.gappssmtp.com header.b="BAnRbAHj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4DCC02088E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 53F82800C2; Tue, 26 May 2020 15:51:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4CAB880010; Tue, 26 May 2020 15:51:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3B86E800C2; Tue, 26 May 2020 15:51:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 23F9B80010 for ; Tue, 26 May 2020 15:51:45 -0400 (EDT) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id D15DC52B3 for ; Tue, 26 May 2020 19:51:44 +0000 (UTC) X-FDA: 76859915328.30.year36_6685eaafe7c4b X-HE-Tag: year36_6685eaafe7c4b X-Filterd-Recvd-Size: 8366 Received: from mail-pl1-f195.google.com (mail-pl1-f195.google.com [209.85.214.195]) by imf16.hostedemail.com (Postfix) with ESMTP for ; Tue, 26 May 2020 19:51:44 +0000 (UTC) Received: by mail-pl1-f195.google.com with SMTP id k22so9112118pls.10 for ; Tue, 26 May 2020 12:51:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Yu5b4WPlNLJ4FShHKrav5N/oC/rLKGyUa0V1npLkROk=; b=BAnRbAHjptEKaSP7aORnMOMvcRRwJYbUJCnBMqSaZ5LExh/WyjZAx0kpm9bGHRNipQ c9xKOXLv3vjiGsiBY1sSp47ys77lF0zegk2Z/RxBhYkJ+oizHWibDzDtaVyKsqqZtscm FwEZma7bB2podeT+bwe2UFoh0El2zE5bb2ykyavUywEuTB1tSqo2t2I71EDQL0x1hfyY EpM1AheRzrX3I6SAVuYiX/AKHnQYJkQtPWkZ9rw2ptTOJVNcB9NTHSHihcMpSOsbvfIi +n+bRE/L+0dLet27JP+fhpHeclePFF8u5DEjtYpBV85c3CaIk2/0DZUoZRk4tv9rWv1y zZ+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Yu5b4WPlNLJ4FShHKrav5N/oC/rLKGyUa0V1npLkROk=; b=KGkSbQTUBJ+PZSsGCglfkhJj/PyVswv0eNWC7Qpg5XUOoVIoGZz3ulijpXvb4RLh5B vTNUbS4RCNaSKvHufIE6CEXDgks4+ATgw9qhE/3SKo42TQP/hiW7Zh9U6ZQ8Lip8EA12 Z7zvIy0gGxLhIQOJmkpcP/RJ7lyVqOhGLLvR3BM8SmsF+AbKF3RVRmg8M2e88+R/RaSj XjWDAI6skx29vwXwHm9JQRgHvyTmGhSKzF3GbrUDkRyQnq1gomj4OPEHDdMZBhc0ULAV 9/vESpLJLI3KbVNdMG56zdA6ZEZQtaWo7QtdtYjsIsALWEXLipuZnCmlTNaugP3xOM4K 0UgA== X-Gm-Message-State: AOAM530XB3brgnEL8bENhxOpwQQ9eREStF3nXzGBSTWbgNUgsc/+lDoZ IrhTNrZm1rGNtjvbyPWuOT7GRQ== X-Google-Smtp-Source: ABdhPJyp1ndQMqu6aI+tmLSQqXTreoaTLldbZ84COMrIiZ1LVkC/ujNtpmTAZp5Rn4xnmw8iMWAw9Q== X-Received: by 2002:a17:902:228:: with SMTP id 37mr2636599plc.105.1590522703244; Tue, 26 May 2020 12:51:43 -0700 (PDT) Received: from x1.lan ([2605:e000:100e:8c61:94bb:59d2:caf6:70e1]) by smtp.gmail.com with ESMTPSA id c184sm313943pfc.57.2020.05.26.12.51.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 May 2020 12:51:42 -0700 (PDT) From: Jens Axboe To: io-uring@vger.kernel.org Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, Jens Axboe Subject: [PATCH 12/12] io_uring: support true async buffered reads, if file provides it Date: Tue, 26 May 2020 13:51:23 -0600 Message-Id: <20200526195123.29053-13-axboe@kernel.dk> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200526195123.29053-1-axboe@kernel.dk> References: <20200526195123.29053-1-axboe@kernel.dk> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: If the file is flagged with FMODE_BUF_RASYNC, then we don't have to punt the buffered read to an io-wq worker. Instead we can rely on page unlocking callbacks to support retry based async IO. This is a lot more efficient than doing async thread offload. The retry is done similarly to how we handle poll based retry. From the unlock callback, we simply queue the retry to a task_work based handler. Signed-off-by: Jens Axboe --- fs/io_uring.c | 130 ++++++++++++++++++++++++++++++++++++++++++++++++-- 1 file changed, 126 insertions(+), 4 deletions(-) diff --git a/fs/io_uring.c b/fs/io_uring.c index e6865afa8467..95df63b0b2ce 100644 --- a/fs/io_uring.c +++ b/fs/io_uring.c @@ -79,6 +79,7 @@ #include #include #include +#include =20 #define CREATE_TRACE_POINTS #include @@ -498,6 +499,8 @@ struct io_async_rw { struct iovec *iov; ssize_t nr_segs; ssize_t size; + struct wait_page_queue wpq; + struct callback_head task_work; }; =20 struct io_async_ctx { @@ -2568,6 +2571,119 @@ static int io_read_prep(struct io_kiocb *req, con= st struct io_uring_sqe *sqe, return 0; } =20 +static void io_async_buf_cancel(struct callback_head *cb) +{ + struct io_async_rw *rw; + struct io_ring_ctx *ctx; + struct io_kiocb *req; + + rw =3D container_of(cb, struct io_async_rw, task_work); + req =3D rw->wpq.wait.private; + ctx =3D req->ctx; + + spin_lock_irq(&ctx->completion_lock); + io_cqring_fill_event(req, -ECANCELED); + io_commit_cqring(ctx); + spin_unlock_irq(&ctx->completion_lock); + + io_cqring_ev_posted(ctx); + req_set_fail_links(req); + io_double_put_req(req); +} + +static void io_async_buf_retry(struct callback_head *cb) +{ + struct io_async_rw *rw; + struct io_ring_ctx *ctx; + struct io_kiocb *req; + + rw =3D container_of(cb, struct io_async_rw, task_work); + req =3D rw->wpq.wait.private; + ctx =3D req->ctx; + + __set_current_state(TASK_RUNNING); + mutex_lock(&ctx->uring_lock); + __io_queue_sqe(req, NULL); + mutex_unlock(&ctx->uring_lock); +} + +static int io_async_buf_func(struct wait_queue_entry *wait, unsigned mod= e, + int sync, void *arg) +{ + struct wait_page_queue *wpq; + struct io_kiocb *req =3D wait->private; + struct io_async_rw *rw =3D &req->io->rw; + struct wait_page_key *key =3D arg; + struct task_struct *tsk; + int ret; + + wpq =3D container_of(wait, struct wait_page_queue, wait); + + ret =3D wake_page_match(wpq, key); + if (ret !=3D 1) + return ret; + + list_del_init(&wait->entry); + + init_task_work(&rw->task_work, io_async_buf_retry); + /* submit ref gets dropped, acquire a new one */ + refcount_inc(&req->refs); + tsk =3D req->task; + ret =3D task_work_add(tsk, &rw->task_work, true); + if (unlikely(ret)) { + /* queue just for cancelation */ + init_task_work(&rw->task_work, io_async_buf_cancel); + tsk =3D io_wq_get_task(req->ctx->io_wq); + task_work_add(tsk, &rw->task_work, true); + } + wake_up_process(tsk); + return 1; +} + +static bool io_rw_should_retry(struct io_kiocb *req) +{ + struct kiocb *kiocb =3D &req->rw.kiocb; + int ret; + + /* never retry for NOWAIT, we just complete with -EAGAIN */ + if (req->flags & REQ_F_NOWAIT) + return false; + + /* already tried, or we're doing O_DIRECT */ + if (kiocb->ki_flags & (IOCB_DIRECT | IOCB_WAITQ)) + return false; + /* + * just use poll if we can, and don't attempt if the fs doesn't + * support callback based unlocks + */ + if (file_can_poll(req->file) || !(req->file->f_mode & FMODE_BUF_RASYNC)= ) + return false; + + /* + * If request type doesn't require req->io to defer in general, + * we need to allocate it here + */ + if (!req->io && __io_alloc_async_ctx(req)) + return false; + + ret =3D kiocb_wait_page_queue_init(kiocb, &req->io->rw.wpq, + io_async_buf_func, req); + if (!ret) { + get_task_struct(current); + req->task =3D current; + return true; + } + + return false; +} + +static int io_iter_do_read(struct io_kiocb *req, struct iov_iter *iter) +{ + if (req->file->f_op->read_iter) + return call_read_iter(req->file, &req->rw.kiocb, iter); + return loop_rw_iter(READ, req->file, &req->rw.kiocb, iter); +} + static int io_read(struct io_kiocb *req, bool force_nonblock) { struct iovec inline_vecs[UIO_FASTIOV], *iovec =3D inline_vecs; @@ -2601,10 +2717,7 @@ static int io_read(struct io_kiocb *req, bool forc= e_nonblock) if (!ret) { ssize_t ret2; =20 - if (req->file->f_op->read_iter) - ret2 =3D call_read_iter(req->file, kiocb, &iter); - else - ret2 =3D loop_rw_iter(READ, req->file, kiocb, &iter); + ret2 =3D io_iter_do_read(req, &iter); =20 /* Catch -EAGAIN return for forced non-blocking submission */ if (!force_nonblock || ret2 !=3D -EAGAIN) { @@ -2619,6 +2732,15 @@ static int io_read(struct io_kiocb *req, bool forc= e_nonblock) if (!(req->flags & REQ_F_NOWAIT) && !file_can_poll(req->file)) req->flags |=3D REQ_F_MUST_PUNT; + /* if we can retry, do so with the callbacks armed */ + if (io_rw_should_retry(req)) { + ret2 =3D io_iter_do_read(req, &iter); + if (ret2 !=3D -EAGAIN) { + kiocb_done(kiocb, ret2); + goto out_free; + } + } + kiocb->ki_flags &=3D ~IOCB_WAITQ; return -EAGAIN; } } --=20 2.26.2