From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F109AC433E0 for ; Wed, 27 May 2020 15:52:13 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id AE41D20776 for ; Wed, 27 May 2020 15:52:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cmpxchg-org.20150623.gappssmtp.com header.i=@cmpxchg-org.20150623.gappssmtp.com header.b="gkwcO4Fh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AE41D20776 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cmpxchg.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 552A9800B6; Wed, 27 May 2020 11:52:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5297780010; Wed, 27 May 2020 11:52:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 43E9B800B6; Wed, 27 May 2020 11:52:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0253.hostedemail.com [216.40.44.253]) by kanga.kvack.org (Postfix) with ESMTP id 2D56480010 for ; Wed, 27 May 2020 11:52:13 -0400 (EDT) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id DD2A3E5BA1 for ; Wed, 27 May 2020 15:52:12 +0000 (UTC) X-FDA: 76862940504.18.bear86_0200bdd26d53 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin18.hostedemail.com (Postfix) with ESMTP id C61971023DE51 for ; Wed, 27 May 2020 15:52:12 +0000 (UTC) X-HE-Tag: bear86_0200bdd26d53 X-Filterd-Recvd-Size: 5315 Received: from mail-qt1-f193.google.com (mail-qt1-f193.google.com [209.85.160.193]) by imf41.hostedemail.com (Postfix) with ESMTP for ; Wed, 27 May 2020 15:52:12 +0000 (UTC) Received: by mail-qt1-f193.google.com with SMTP id c12so9670646qtq.11 for ; Wed, 27 May 2020 08:52:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=rdavmOiaMpGhs7wGJxDamxnJAYZBuYUhq0aVlsOCRyA=; b=gkwcO4FhZgIhYZsPq0f06YlHsoXzZTZD4TVMFnSEJkWPeA9sHjZUXP6LqDRXrFByd3 bpkQeH86yIluEzmWNr4jcXijjYwxnwPkG6/eNLkx9SqCD4gTIdChRNBbAOO3TrdVhR4a XD5KwE9LvRhJPfvYJIaUtCMjIIaJ15va4wLU8VeM0JpBtqDJKbphSy7WWmuhvJGt0edS sWuJlI2k79/88yc9j1dy9VpBs/vk6JSegkfvqmRkjZ4qkZnzIv6fra1YCa4B/t+Vy0A0 La7L5qUCLlpEhE5HT95drazFP1fL+jFlnNTHluO7f4pD776bkG2cWledK26hTkqE5rdW +9dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=rdavmOiaMpGhs7wGJxDamxnJAYZBuYUhq0aVlsOCRyA=; b=NWHCqKqxRZpYCHesAGxZJK8ACCzPZiKvDWYJrp515+aLAum9hmYYyBfyQGlz+H/Npn riA4/gsPcUWPw9vr216LMGc1EkDKtAG+BKlA1DFDP2DNENs7PFPPyK1cjf6ZUG5lxqLo tsxnB9dTLb/EtqsJGDexsL3bJcNnrJilq9TnNnSc137cnLrHL31o09q8NQkoIZecF8sR tuY2w2B0M/XRKdYpbwjAQvu1Zz5KwSxUg3psDtmb29Jzu2PXk6vG8mkbxE3DZDcmzl8R ZBoIILR+NViBfc0ePGSbHNnRhJg8P5GFUpI1U8GIsyCQHVmchgQuip8/0ZwDb9n8KPrZ fInA== X-Gm-Message-State: AOAM533yLQ4BPpnNoaT2cvIzJcfli62ty1HIu0KhrsLQDovWVJ532NYa sgRqv7iOxPccLPBRAVFrv481mQ== X-Google-Smtp-Source: ABdhPJyrSTROePSMbQ/B5rMJZyiqNj24TJYNMmjay84uQk055AedPAx2sXoVMMIROe4isndGOd7xjg== X-Received: by 2002:ac8:c09:: with SMTP id k9mr5244596qti.264.1590594730621; Wed, 27 May 2020 08:52:10 -0700 (PDT) Received: from localhost ([2620:10d:c091:480::1:2535]) by smtp.gmail.com with ESMTPSA id m82sm2611261qke.3.2020.05.27.08.52.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 May 2020 08:52:09 -0700 (PDT) Date: Wed, 27 May 2020 11:51:45 -0400 From: Johannes Weiner To: Jakub Kicinski Cc: akpm@linux-foundation.org, linux-mm@kvack.org, kernel-team@fb.com, tj@kernel.org, chris@chrisdown.name, cgroups@vger.kernel.org, shakeelb@google.com, mhocko@kernel.org Subject: Re: [PATCH mm v5 RESEND 4/4] mm: automatically penalize tasks with high swap use Message-ID: <20200527155145.GA42293@cmpxchg.org> References: <20200521002411.3963032-1-kuba@kernel.org> <20200521002411.3963032-5-kuba@kernel.org> <20200526153309.GD848026@cmpxchg.org> <20200526131157.79c17940@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200526131157.79c17940@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> X-Rspamd-Queue-Id: C61971023DE51 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 26, 2020 at 01:11:57PM -0700, Jakub Kicinski wrote: > On Tue, 26 May 2020 11:33:09 -0400 Johannes Weiner wrote: > > On Wed, May 20, 2020 at 05:24:11PM -0700, Jakub Kicinski wrote: > > > + penalty_jiffies += calculate_high_delay(memcg, nr_pages, > > > + swap_find_max_overage(memcg)); > > > + > > > /* > > > * Clamp the max delay per usermode return so as to still keep the > > > * application moving forwards and also permit diagnostics, albeit > > > @@ -2585,12 +2608,25 @@ static int try_charge(struct mem_cgroup *memcg, gfp_t gfp_mask, > > > * reclaim, the cost of mismatch is negligible. > > > */ > > > do { > > > - if (page_counter_is_above_high(&memcg->memory)) { > > > - /* Don't bother a random interrupted task */ > > > - if (in_interrupt()) { > > > + bool mem_high, swap_high; > > > + > > > + mem_high = page_counter_is_above_high(&memcg->memory); > > > + swap_high = page_counter_is_above_high(&memcg->swap); > > > > Please open-code these checks instead - we don't really do getters and > > predicates for these, and only have the setters because they are more > > complicated operations. > > I added this helper because the calculation doesn't fit into 80 chars. > > In particular reclaim_high will need a temporary variable or IMHO > questionable line split. > > static void reclaim_high(struct mem_cgroup *memcg, > unsigned int nr_pages, > gfp_t gfp_mask) > { > do { > if (!page_counter_is_above_high(&memcg->memory)) > continue; > memcg_memory_event(memcg, MEMCG_HIGH); > try_to_free_mem_cgroup_pages(memcg, nr_pages, gfp_mask, true); > } while ((memcg = parent_mem_cgroup(memcg)) && > !mem_cgroup_is_root(memcg)); > } > > What's your preference? Mine is a helper, but I'm probably not > sensitive enough to the ontology here :) if (page_counter_read(&memcg->memory) < READ_ONCE(memcg->memory.high)) continue; should work fine. It's the same formatting in mem_cgroup_swap_full(): if (page_counter_read(&memcg->swap) * 2 >= READ_ONCE(memcg->swap.max))