From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6CDDC433E3 for ; Thu, 28 May 2020 00:55:50 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4EE0B20DD4 for ; Thu, 28 May 2020 00:55:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="jv37Devl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4EE0B20DD4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id DD4668001A; Wed, 27 May 2020 20:55:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D87B780010; Wed, 27 May 2020 20:55:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C9AEA8001A; Wed, 27 May 2020 20:55:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0025.hostedemail.com [216.40.44.25]) by kanga.kvack.org (Postfix) with ESMTP id AF6BA80010 for ; Wed, 27 May 2020 20:55:49 -0400 (EDT) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 5F22C8B4A0 for ; Thu, 28 May 2020 00:55:49 +0000 (UTC) X-FDA: 76864310418.19.power71_32ca580441d4e Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin19.hostedemail.com (Postfix) with ESMTP id 443211AD1B5 for ; Thu, 28 May 2020 00:55:49 +0000 (UTC) X-HE-Tag: power71_32ca580441d4e X-Filterd-Recvd-Size: 2476 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf28.hostedemail.com (Postfix) with ESMTP for ; Thu, 28 May 2020 00:55:48 +0000 (UTC) Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A70B8207CB; Thu, 28 May 2020 00:55:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590627348; bh=LVt+v07eAhhKUzT7NqWt/6bOrLAfS45SVvYmNSlojo4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=jv37DevlwxDmCOqr9Zb5+P2Xeq5ZWKgzCjORE0J9RBB7bJfqb3n8CvDivIWERcESE VM38R5KdZwFEAuJzap4U8cYrCW2Bkn8bZDTrxsIVze5ZoSzUpmeMIKrR/RqWTuadrt WomSlE/Kd+KPBoOd1wYzuXZRNXU+tR00icpmem+o= Date: Wed, 27 May 2020 17:55:47 -0700 From: Andrew Morton To: Christoph Hellwig Cc: x86@kernel.org, Alexei Starovoitov , Daniel Borkmann , Masami Hiramatsu , Linus Torvalds , linux-parisc@vger.kernel.org, linux-um@lists.infradead.org, netdev@vger.kernel.org, bpf@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 10/23] maccess: unify the probe kernel arch hooks Message-Id: <20200527175547.0260fb90d76734d4e0f56def@linux-foundation.org> In-Reply-To: <20200521152301.2587579-11-hch@lst.de> References: <20200521152301.2587579-1-hch@lst.de> <20200521152301.2587579-11-hch@lst.de> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 443211AD1B5 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 21 May 2020 17:22:48 +0200 Christoph Hellwig wrote: > Currently architectures have to override every routine that probes > kernel memory, which includes a pure read and strcpy, both in strict > and not strict variants. Just provide a single arch hooks instead to > make sure all architectures cover all the cases. Fix a buildo. --- a/arch/x86/mm/maccess.c~maccess-unify-the-probe-kernel-arch-hooks-fix +++ a/arch/x86/mm/maccess.c @@ -29,6 +29,6 @@ bool probe_kernel_read_allowed(const voi { if (!strict) return true; - return (unsigned long)vaddr >= TASK_SIZE_MAX; + return (unsigned long)unsafe_src >= TASK_SIZE_MAX; } #endif _