From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B777BC433E0 for ; Wed, 27 May 2020 19:42:17 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7EC3F2088E for ; Wed, 27 May 2020 19:42:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cmpxchg-org.20150623.gappssmtp.com header.i=@cmpxchg-org.20150623.gappssmtp.com header.b="RlxA8nhx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7EC3F2088E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cmpxchg.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 12AB78001A; Wed, 27 May 2020 15:42:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0DBCB80010; Wed, 27 May 2020 15:42:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F0D118001A; Wed, 27 May 2020 15:42:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0180.hostedemail.com [216.40.44.180]) by kanga.kvack.org (Postfix) with ESMTP id D762C80010 for ; Wed, 27 May 2020 15:42:16 -0400 (EDT) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 8D529181AC9CC for ; Wed, 27 May 2020 19:42:16 +0000 (UTC) X-FDA: 76863520272.10.nest87_02028cc26d54 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin10.hostedemail.com (Postfix) with ESMTP id 5B0151923E for ; Wed, 27 May 2020 19:42:16 +0000 (UTC) X-HE-Tag: nest87_02028cc26d54 X-Filterd-Recvd-Size: 3827 Received: from mail-qt1-f194.google.com (mail-qt1-f194.google.com [209.85.160.194]) by imf30.hostedemail.com (Postfix) with ESMTP for ; Wed, 27 May 2020 19:42:15 +0000 (UTC) Received: by mail-qt1-f194.google.com with SMTP id h9so10043976qtj.7 for ; Wed, 27 May 2020 12:42:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=y/I/vYOeWDaLgdvChn7OrIXfp4eLue4GU8kN/nhBY2M=; b=RlxA8nhxtnbe+M7ZmnAYSboT5jXDfDT3lRgHDb3QDO3TptnDvqzSH740c9GLdH/Y93 omLhViyqr9nb//4nmPJ4HJcm8/TnvQaL5CGLPvU4kkejJwSNUnm7Nz5t4S8CkrnHBIaA +mWFD2PvRFwBkBvzsfrPIZWinsBvUkoMK5XF5BTr/bTLDk/PpGSjMiqrg5FyKiTCq28j y3B1plMcOn7oSf1nhOTOzvoUBAgp11763/xU8eouz+Q6vV9EGtUYjyc32wepuZPMd8al RWnsMFh8khsCbK8upqC1wfzet39Ti0hyVtDbH6wH+XPHilIv/Cfrn1EH+VwpxKfcsH9O /ODw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=y/I/vYOeWDaLgdvChn7OrIXfp4eLue4GU8kN/nhBY2M=; b=k2IZCk0Jxf3eR44C8PxskBR+Q6voc+vMN98MBL6Ycs6Z0S11iLbugZE6BBVd8sgqtd QqB5s6SCqWYTHExT6hnz5+2Pr276ner6cnrcQJfFfPUl1H4WvHOT6gFV/bWcLs8jfY73 wEcx6jk/tlpYqIrFwkRmZsq7nusaCAdgSGK7/ec/bPqAXCys+ZL/lgIUhWRf5GB0W3Bq VocB23bsTQT/wkXRBUSEhFCKRUx5eXuQGbS/2BrKmp3Dg5R6R1MjCC6TqX+dwUIzcYSy rilkmAu/aQh+Dp7PfHfEEIcGEYUfq9gJ6nZLNXrj9GGpqqV+HOwRnMv9VNmN7AC54l8j 8Xmg== X-Gm-Message-State: AOAM530fz3Ot5wkeia+47kRpbfjesYr7GlPtFgir1TMQEjn7MPWGHWkh /6UUaENnjbA7dG0H1Yp57B/MiA== X-Google-Smtp-Source: ABdhPJwkT/j72pG3A4CaMBtW17UHMziTMfasgq+/mkgPkKOHVgWgZr8k8tkH6Zt7dSQl+w/lh/x4+A== X-Received: by 2002:aed:3b56:: with SMTP id q22mr5925119qte.345.1590608534781; Wed, 27 May 2020 12:42:14 -0700 (PDT) Received: from localhost ([2620:10d:c091:480::1:2535]) by smtp.gmail.com with ESMTPSA id m10sm3236312qtg.94.2020.05.27.12.42.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 May 2020 12:42:13 -0700 (PDT) Date: Wed, 27 May 2020 15:41:48 -0400 From: Johannes Weiner To: Shakeel Butt Cc: Mel Gorman , Roman Gushchin , Michal Hocko , Andrew Morton , Minchan Kim , Rik van Riel , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH resend 3/3] mm: fix LRU balancing effect of new transparent huge pages Message-ID: <20200527194148.GA47905@cmpxchg.org> References: <20200527182958.252402-1-shakeelb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200527182958.252402-1-shakeelb@google.com> X-Rspamd-Queue-Id: 5B0151923E X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, May 27, 2020 at 11:29:58AM -0700, Shakeel Butt wrote: > From: Johannes Weiner > > Currently, THP are counted as single pages until they are split right > before being swapped out. However, at that point the VM is already in > the middle of reclaim, and adjusting the LRU balance then is useless. > > Always account THP by the number of basepages, and remove the fixup > from the splitting path. > > Signed-off-by: Johannes Weiner > Signed-off-by: Shakeel Butt This is now already in mm as part of the "mm: balance LRU lists based on relative thrashing" series that I sent out last week and where it was originally from.