From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DBF9C433DF for ; Thu, 28 May 2020 12:49:31 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2330B206F1 for ; Thu, 28 May 2020 12:49:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="iYIBU1YT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2330B206F1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id AF46E8001A; Thu, 28 May 2020 08:49:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ACB3E80010; Thu, 28 May 2020 08:49:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9B90B8001A; Thu, 28 May 2020 08:49:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0068.hostedemail.com [216.40.44.68]) by kanga.kvack.org (Postfix) with ESMTP id 7D98380010 for ; Thu, 28 May 2020 08:49:30 -0400 (EDT) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 3FADD180AD804 for ; Thu, 28 May 2020 12:49:30 +0000 (UTC) X-FDA: 76866108900.25.stage33_18975a3897834 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin25.hostedemail.com (Postfix) with ESMTP id 18E301804E3B5 for ; Thu, 28 May 2020 12:49:30 +0000 (UTC) X-HE-Tag: stage33_18975a3897834 X-Filterd-Recvd-Size: 4248 Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by imf42.hostedemail.com (Postfix) with ESMTP for ; Thu, 28 May 2020 12:49:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1590670168; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=N44YvMNoS2XEf8I1F7cjr6cLz8BwzDvWheszxZeZLbQ=; b=iYIBU1YTpKOobY9E3wYT90uHa6L36NCmdxWZYXktXry3//ON0W6sR01x0qWZuZcsOqZeAa fzzZuYBfac4zBgRPo4WvwSJ4WMF8eprYKeCpMLdmDKZT8uQe3LWEF2QV7mU1mYSIXLF53I b+UCQat62pSlkpctqF0c3dscMdnEh5c= Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-283-N7O9YPsyND21KVqHugSJsg-1; Thu, 28 May 2020 08:49:24 -0400 X-MC-Unique: N7O9YPsyND21KVqHugSJsg-1 Received: by mail-qt1-f197.google.com with SMTP id p31so29386655qte.1 for ; Thu, 28 May 2020 05:49:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=N44YvMNoS2XEf8I1F7cjr6cLz8BwzDvWheszxZeZLbQ=; b=kyVzBjH4TEKb9CHbjHWmvRIg9jWOModA/OB6vgWyCz8aTqJtZe4Gzv9rCfoGZP1ZJ4 XOzkn3/6LccVOEl6cGvgVorji3s6x0zMiLbBeoOPKNPTygiJ8A7pVuG7NoAbhc4wKIeI acfqMVXzBtQR0ulgEezZxuFNkyZgO9y6Yyl2pt0kKaNZV1Q5x9gK3gWitwYbo5QhYmIZ 4MEKcgm8NrEDLXoSGPyg/cPC39haZAZb/dMKHkKM6U7aob6luONyu3nlhaESx5SxDNNu LNiFJFE+ePCavpLN2Mr26T5quIneeA6qAT5qAuzUfLtTdcy+aUG51t5jsMfJGBKnQp0/ jhGQ== X-Gm-Message-State: AOAM533iMAA78Js+9KG3/HTpXRl+xrvN5iCsAGhd/FP8p4xqknZGaeeM C/V0/ngUsp41TKSeIpx7At1IESxyeKfXu8w70IP+fxluHE0hS1eWTts1/aZDbckUL3H41UT0q73 XRE/0KqLVx2M= X-Received: by 2002:ad4:44e3:: with SMTP id p3mr2862076qvt.166.1590670164170; Thu, 28 May 2020 05:49:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwovYH78tr5tgBrTOAWggHNiKsHz8eXOmiGYvJVn+7sSN5nHeoV8F9duhW1+pF2zVYv321wCA== X-Received: by 2002:ad4:44e3:: with SMTP id p3mr2862037qvt.166.1590670163851; Thu, 28 May 2020 05:49:23 -0700 (PDT) Received: from xz-x1 ([2607:9880:19c0:32::2]) by smtp.gmail.com with ESMTPSA id d56sm5440421qtb.54.2020.05.28.05.49.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 May 2020 05:49:23 -0700 (PDT) Date: Thu, 28 May 2020 08:49:19 -0400 From: Peter Xu To: Xiaoming Ni Cc: aarcange@redhat.com, akpm@linux-foundation.org, cracauer@cons.org, dplotnikov@virtuozzo.com, gokhale2@llnl.gov, hannes@cmpxchg.org, hughd@google.com, jglisse@redhat.com, kirill@shutemov.name, linux-kernel@vger.kernel.org, linux-mm@kvack.org, maxime.coquelin@redhat.com, mcfadden8@llnl.gov, mcgrof@kernel.org, mgorman@suse.de, mike.kravetz@oracle.com, pbonzini@redhat.com, rppt@linux.vnet.ibm.com, xemul@virtuozzo.com, keescook@chromium.org Subject: Re: [PATCH v2 1/1] userfaultfd/sysctl: add vm.unprivileged_userfaultfd Message-ID: <20200528124919.GK1194141@xz-x1> References: <3b64de85-beb4-5a07-0093-cad6e8f2a8d8@huawei.com> <20200527142143.GC1194141@xz-x1> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Queue-Id: 18E301804E3B5 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, May 28, 2020 at 04:50:49PM +0800, Xiaoming Ni wrote: > Since userfaultfd and vm are more closely related, will there be > consideration to move fs/userfaultfd.c to the mm directory in the future? Xiaoming, I don't think so - userfaultfd is still interfacing the userspace as a file object, so I think it's proper to have fs/userfaultfd.c handles the fs part of userfaultfd. There's also an mm/userfaultfd.c which handles some internal logic of userfaultfd syscalls, please feel free to have a look. Thanks, -- Peter Xu