From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73068C433E1 for ; Thu, 28 May 2020 13:55:30 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2B89420814 for ; Thu, 28 May 2020 13:55:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="h4u0/E9S" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2B89420814 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C65E3800B8; Thu, 28 May 2020 09:55:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C149380010; Thu, 28 May 2020 09:55:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AB602800B8; Thu, 28 May 2020 09:55:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0048.hostedemail.com [216.40.44.48]) by kanga.kvack.org (Postfix) with ESMTP id 94E2080010 for ; Thu, 28 May 2020 09:55:29 -0400 (EDT) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 488A3180AD81D for ; Thu, 28 May 2020 13:55:29 +0000 (UTC) X-FDA: 76866275178.02.shoe71_12ba8a4c07914 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin02.hostedemail.com (Postfix) with ESMTP id 2B5F114D3B for ; Thu, 28 May 2020 13:55:29 +0000 (UTC) X-HE-Tag: shoe71_12ba8a4c07914 X-Filterd-Recvd-Size: 6908 Received: from mail-qk1-f193.google.com (mail-qk1-f193.google.com [209.85.222.193]) by imf19.hostedemail.com (Postfix) with ESMTP for ; Thu, 28 May 2020 13:55:28 +0000 (UTC) Received: by mail-qk1-f193.google.com with SMTP id b6so3061944qkh.11 for ; Thu, 28 May 2020 06:55:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=9ISW/6WZX64f8daVPvqFY1okl3lTrypxE++ROsAseMc=; b=h4u0/E9SlBDy7zE004Yhxe8LFwdOtd/jFTly/4kG0sMKrxsLJsPoCxK54qreUYkgK0 C7cJedYKAPzO3C9CgbPInsWb60fQVA87E8pw9r3OCXO6/RdKCiWz0P/I5ky0SXIoK6Np FgDjlPbtoIcn+pghJNAbepTGyjd439k78xyFR0UCJNyeKLtQ34HEVGUzpBT6SQIcXTxx SB6GW0ZCD8aukfdRP7gHYESpCupUZPqclUUE56uX1JeF01D5TlDgQoSBacTd+mNHWqrs X4aAD6XHrrLpVwXd0q0oefEXI3hWih+JKTC6LIMXUF+d4MC1P5dMj2sKms1rjVY264nS PKAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=9ISW/6WZX64f8daVPvqFY1okl3lTrypxE++ROsAseMc=; b=LdajfWmf5Lpqaymx4x/e3FWFRDdhV6SEbknpGLf5p0dIGVHotK/Eg80gqmyz7ZIwiq +rcJzn59IMWFS1Hr6t7asWdNnpe5kEPPKQDGMzCYvIBD4uK9KA3tJtOX17F5CHpINCAb /Q44UUPDgsokuYeLo6IR15PC/QKmeOgezbLeaQiTbe2Du+AxIfH4KcSssosF57qwNFWz BJw+wbdF173bo5LLFA7nkQis83N4CLXT+WccvymWrdfxkafMH5cwFXNLWd+/UnSSExGJ 7KFELOKAxHRmFoGEIIz0dZVHrwkBs+OMyrX7KtAvZ32ciqKfBXhqNvLKqC+NzjQ5kGn4 gOnw== X-Gm-Message-State: AOAM530dRFj25gG0JHH+v1UR3iKjAiSOmQlBIPf7FrynRhA+xCV/asWe 7XBLgYyZWAyeD9uf43r3jNw= X-Google-Smtp-Source: ABdhPJzrlVywN4JlmAU2ZM/nC5B3Ll644kitWP/9qECB6fQhLzh4HwCgQpi3FHH9/Li3NZeoEl/LKA== X-Received: by 2002:ae9:e901:: with SMTP id x1mr2717709qkf.131.1590674127957; Thu, 28 May 2020 06:55:27 -0700 (PDT) Received: from dschatzberg-fedora-PC0Y6AEN.thefacebook.com ([2620:10d:c091:480::1:1cb7]) by smtp.gmail.com with ESMTPSA id l186sm4890889qkf.89.2020.05.28.06.55.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 May 2020 06:55:26 -0700 (PDT) From: Dan Schatzberg To: Cc: Dan Schatzberg , Johannes Weiner , Tejun Heo , Chris Down , Shakeel Butt , Jens Axboe , Alexander Viro , Jan Kara , Amir Goldstein , Li Zefan , Michal Hocko , Vladimir Davydov , Andrew Morton , Hugh Dickins , Roman Gushchin , Yang Shi , Thomas Gleixner , Ingo Molnar , "Peter Zijlstra (Intel)" , Mathieu Desnoyers , Andrea Arcangeli , linux-block@vger.kernel.org (open list:BLOCK LAYER), linux-kernel@vger.kernel.org (open list), linux-fsdevel@vger.kernel.org (open list:FILESYSTEMS (VFS and infrastructure)), cgroups@vger.kernel.org (open list:CONTROL GROUP (CGROUP)), linux-mm@kvack.org (open list:CONTROL GROUP - MEMORY RESOURCE CONTROLLER (MEMCG)) Subject: [PATCH 3/4] mm: Charge active memcg when no mm is set Date: Thu, 28 May 2020 09:54:38 -0400 Message-Id: <20200528135444.11508-4-schatzberg.dan@gmail.com> X-Mailer: git-send-email 2.21.3 In-Reply-To: <20200528135444.11508-1-schatzberg.dan@gmail.com> References: <20200528135444.11508-1-schatzberg.dan@gmail.com> MIME-Version: 1.0 X-Rspamd-Queue-Id: 2B5F114D3B X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: memalloc_use_memcg() worked for kernel allocations but was silently ignored for user pages. This patch establishes a precedence order for who gets charged: 1. If there is a memcg associated with the page already, that memcg is charged. This happens during swapin. 2. If an explicit mm is passed, mm->memcg is charged. This happens during page faults, which can be triggered in remote VMs (eg gup). 3. Otherwise consult the current process context. If it has configured a current->active_memcg, use that. Otherwise, current->mm->memcg. Previously, if a NULL mm was passed to mem_cgroup_try_charge (case 3) it would always charge the root cgroup. Now it looks up the current active_memcg first (falling back to charging the root cgroup if not set). Signed-off-by: Dan Schatzberg Acked-by: Johannes Weiner Acked-by: Tejun Heo Acked-by: Chris Down Reviewed-by: Shakeel Butt --- mm/memcontrol.c | 11 ++++++++--- mm/shmem.c | 4 ++-- 2 files changed, 10 insertions(+), 5 deletions(-) diff --git a/mm/memcontrol.c b/mm/memcontrol.c index a3b97f103966..383d88c1c105 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -6438,7 +6438,8 @@ enum mem_cgroup_protection mem_cgroup_protected(str= uct mem_cgroup *root, * @compound: charge the page as compound or small page * * Try to charge @page to the memcg that @mm belongs to, reclaiming - * pages according to @gfp_mask if necessary. + * pages according to @gfp_mask if necessary. if @mm is NULL, try to + * charge to the active memcg. * * Returns 0 on success, with *@memcgp pointing to the charged memcg. * Otherwise, an error code is returned. @@ -6482,8 +6483,12 @@ int mem_cgroup_try_charge(struct page *page, struc= t mm_struct *mm, } } =20 - if (!memcg) - memcg =3D get_mem_cgroup_from_mm(mm); + if (!memcg) { + if (!mm) + memcg =3D get_mem_cgroup_from_current(); + else + memcg =3D get_mem_cgroup_from_mm(mm); + } =20 ret =3D try_charge(memcg, gfp_mask, nr_pages); =20 diff --git a/mm/shmem.c b/mm/shmem.c index bd8840082c94..d2efa1a44311 100644 --- a/mm/shmem.c +++ b/mm/shmem.c @@ -1618,7 +1618,7 @@ static int shmem_swapin_page(struct inode *inode, p= goff_t index, { struct address_space *mapping =3D inode->i_mapping; struct shmem_inode_info *info =3D SHMEM_I(inode); - struct mm_struct *charge_mm =3D vma ? vma->vm_mm : current->mm; + struct mm_struct *charge_mm =3D vma ? vma->vm_mm : NULL; struct mem_cgroup *memcg; struct page *page; swp_entry_t swap; @@ -1753,7 +1753,7 @@ static int shmem_getpage_gfp(struct inode *inode, p= goff_t index, } =20 sbinfo =3D SHMEM_SB(inode->i_sb); - charge_mm =3D vma ? vma->vm_mm : current->mm; + charge_mm =3D vma ? vma->vm_mm : NULL; =20 page =3D find_lock_entry(mapping, index); if (xa_is_value(page)) { --=20 2.24.1