From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23EBEC433E1 for ; Fri, 29 May 2020 03:37:45 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D6C2B20721 for ; Fri, 29 May 2020 03:37:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="p/4mTPXO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D6C2B20721 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id ABB9B800BC; Thu, 28 May 2020 23:37:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A1AD280010; Thu, 28 May 2020 23:37:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 90A0B800BC; Thu, 28 May 2020 23:37:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0199.hostedemail.com [216.40.44.199]) by kanga.kvack.org (Postfix) with ESMTP id 7802F80010 for ; Thu, 28 May 2020 23:37:40 -0400 (EDT) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 45A6D181AEF1E for ; Fri, 29 May 2020 03:37:40 +0000 (UTC) X-FDA: 76868347080.03.fear93_42ee7294f1e3a Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin03.hostedemail.com (Postfix) with ESMTP id 2467D28A4E8 for ; Fri, 29 May 2020 03:37:40 +0000 (UTC) X-HE-Tag: fear93_42ee7294f1e3a X-Filterd-Recvd-Size: 2688 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf50.hostedemail.com (Postfix) with ESMTP for ; Fri, 29 May 2020 03:37:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=9KvoeAFnUpEm6vX6aegi31mfb0B48oh6WJ2ZQb46Eg0=; b=p/4mTPXO84eibr5G7Cu/wwQ2MD YvkRRfwMid53APEQ2o5vgnZ78ThzJG8WRW6grAOH2iOxUfqaRXQav8wS8Z3xQ3gF8aX7z9cYPtgDC +8dpO3u9RkcacbYIrK0ymtv+TyfCbve3PYAZjhlx+EV82bve/GiWlPZwUTzvZJKvvAARUtj0NRpLR 7ls1OnMgh4TxOT9aeFbcBQ0aLQ/JYhZcqkplRZYlKoulVWYl0gi6f5sSU6w5EZWtKe087RpTlPt0H jstu2fTWAj1lZG44qMRm4Ksp4l6MLiiYhbpV72AjXtob4Hzm3VzZwyUy61AlT4ltWfgAKi4sluNCH te/IC+ag==; Received: from willy by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jeVE3-0008Rb-84; Fri, 29 May 2020 02:58:27 +0000 From: Matthew Wilcox To: linux-fsdevel@vger.kernel.org Cc: "Matthew Wilcox (Oracle)" , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Christoph Hellwig Subject: [PATCH v5 18/39] iomap: Inline data shouldn't see large pages Date: Thu, 28 May 2020 19:58:03 -0700 Message-Id: <20200529025824.32296-19-willy@infradead.org> X-Mailer: git-send-email 2.21.1 In-Reply-To: <20200529025824.32296-1-willy@infradead.org> References: <20200529025824.32296-1-willy@infradead.org> MIME-Version: 1.0 X-Rspamd-Queue-Id: 2467D28A4E8 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam04 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: "Matthew Wilcox (Oracle)" Assert that we're not seeing large pages in functions that read/write inline data, rather than zeroing out the tail. Signed-off-by: Matthew Wilcox (Oracle) Reviewed-by: Christoph Hellwig --- fs/iomap/buffered-io.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/iomap/buffered-io.c b/fs/iomap/buffered-io.c index 8767241ae535..5b37844b7d97 100644 --- a/fs/iomap/buffered-io.c +++ b/fs/iomap/buffered-io.c @@ -221,6 +221,7 @@ iomap_read_inline_data(struct inode *inode, struct pa= ge *page, return; =20 BUG_ON(page->index); + BUG_ON(PageCompound(page)); BUG_ON(size > PAGE_SIZE - offset_in_page(iomap->inline_data)); =20 addr =3D kmap_atomic(page); @@ -736,6 +737,7 @@ iomap_write_end_inline(struct inode *inode, struct pa= ge *page, void *addr; =20 WARN_ON_ONCE(!PageUptodate(page)); + BUG_ON(PageCompound(page)); BUG_ON(pos + copied > PAGE_SIZE - offset_in_page(iomap->inline_data)); =20 addr =3D kmap_atomic(page); --=20 2.26.2