From: Daniel Jordan <daniel.m.jordan@oracle.com>
To: John Hubbard <jhubbard@nvidia.com>
Cc: Anshuman Khandual <anshuman.khandual@arm.com>,
Daniel Jordan <daniel.m.jordan@oracle.com>,
linux-mm@kvack.org, hughd@google.com,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
Zi Yan <ziy@nvidia.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/vmstat: Add events for PMD based THP migration without split
Date: Tue, 2 Jun 2020 10:52:08 -0400 [thread overview]
Message-ID: <20200602145208.qucum52lwslhiqff@ca-dmjordan1.us.oracle.com> (raw)
In-Reply-To: <274be3bf-2206-5e98-8114-1d91fac472c9@nvidia.com>
On Mon, Jun 01, 2020 at 09:48:09PM -0700, John Hubbard wrote:
> However, the fact that this is under discussion hints at the need for a
> bit of documentation help. What do you think about adding some notes about
> all of this to, say, Documentation/vm/page_migration.rst ?
Yes, that would be good. I understand the intent better now but still think
the 'failure' event could be misinterpreted as outright failure instead of
splitting followed by successfully moving the constituent pages.
It might help to clarify in the changelog as well.
next prev parent reply other threads:[~2020-06-02 14:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-22 3:34 [PATCH] mm/vmstat: Add events for PMD based THP migration without split Anshuman Khandual
2020-06-01 16:57 ` Daniel Jordan
2020-06-02 3:20 ` John Hubbard
2020-06-02 4:20 ` Anshuman Khandual
2020-06-02 4:48 ` John Hubbard
2020-06-02 5:30 ` Anshuman Khandual
2020-06-02 14:52 ` Daniel Jordan [this message]
2020-06-03 4:36 ` Anshuman Khandual
2020-06-03 16:08 ` Daniel Jordan
2020-06-02 15:01 ` Matthew Wilcox
2020-06-03 1:26 ` Anshuman Khandual
2020-06-03 2:57 ` Matthew Wilcox
2020-06-03 4:58 ` Anshuman Khandual
2020-06-03 11:09 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200602145208.qucum52lwslhiqff@ca-dmjordan1.us.oracle.com \
--to=daniel.m.jordan@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=hughd@google.com \
--cc=jhubbard@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).