linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: SeongJae Park <sjpark@amazon.com>
To: SeongJae Park <sjpark@amazon.com>
Cc: <akpm@linux-foundation.org>, SeongJae Park <sjpark@amazon.de>,
	<Jonathan.Cameron@Huawei.com>, <aarcange@redhat.com>,
	<acme@kernel.org>, <alexander.shishkin@linux.intel.com>,
	<amit@kernel.org>, <benh@kernel.crashing.org>,
	<brendan.d.gregg@gmail.com>, <brendanhiggins@google.com>,
	<cai@lca.pw>, <colin.king@canonical.com>, <corbet@lwn.net>,
	<dwmw@amazon.com>, <irogers@google.com>, <jolsa@redhat.com>,
	<kirill@shutemov.name>, <mark.rutland@arm.com>, <mgorman@suse.de>,
	<minchan@kernel.org>, <mingo@redhat.com>, <namhyung@kernel.org>,
	<peterz@infradead.org>, <rdunlap@infradead.org>,
	<riel@surriel.com>, <rientjes@google.com>, <rostedt@goodmis.org>,
	<sblbir@amazon.com>, <shakeelb@google.com>, <shuah@kernel.org>,
	<sj38.park@gmail.com>, <snu@amazon.de>, <vbabka@suse.cz>,
	<vdavydov.dev@gmail.com>, <yang.shi@linux.alibaba.com>,
	<ying.huang@intel.com>, <linux-damon@amazon.com>,
	<linux-mm@kvack.org>, <linux-doc@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [RFC v9 4/8] mm/damon/schemes: Implement a debugfs interface
Date: Thu, 4 Jun 2020 13:17:57 +0200	[thread overview]
Message-ID: <20200604111757.7659-1-sjpark@amazon.com> (raw)
In-Reply-To: <20200526075702.27339-5-sjpark@amazon.com> (raw)

On Tue, 26 May 2020 09:56:58 +0200 SeongJae Park <sjpark@amazon.com> wrote:

> From: SeongJae Park <sjpark@amazon.de>
> 
> This commit implements a debugfs interface for the data access
> monitoring oriented memory management schemes.  It is supposed to be
> used by administrators and/or privileged user space programs.  Users can
> read and update the rules using ``<debugfs>/damon/schemes`` file.  The
> format is::
> 
>     <min/max size> <min/max access frequency> <min/max age> <action>
> 
> Signed-off-by: SeongJae Park <sjpark@amazon.de>
> ---
>  mm/damon.c | 176 ++++++++++++++++++++++++++++++++++++++++++++++++++++-
>  1 file changed, 174 insertions(+), 2 deletions(-)
> 
> diff --git a/mm/damon.c b/mm/damon.c
> index 6a07649d1f5d..bcc732e8735c 100644
> --- a/mm/damon.c
> +++ b/mm/damon.c
> @@ -173,6 +173,29 @@ static void damon_destroy_task(struct damon_task *t)
>  	damon_free_task(t);
>  }
> +
> +/*
> + * Converts a string into an array of struct damos pointers
> + *
> + * Returns an array of struct damos pointers that converted if the conversion
> + * success, or NULL otherwise.
> + */
> +static struct damos **str_to_schemes(const char *str, ssize_t len,
> +				ssize_t *nr_schemes)
> +{
> +	struct damos *scheme, **schemes;
> +	const int max_nr_schemes = 256;
> +	int pos = 0, parsed, ret;
> +	unsigned int min_sz, max_sz, min_nr_a, max_nr_a, min_age, max_age;
> +	unsigned int action;
> +
> +	schemes = kmalloc_array(max_nr_schemes, sizeof(scheme),
> +			GFP_KERNEL);
> +	if (!schemes)
> +		return NULL;
> +
> +	*nr_schemes = 0;
> +	while (pos < len && *nr_schemes < max_nr_schemes) {
> +		ret = sscanf(&str[pos], "%u %u %u %u %u %u %u%n",
> +				&min_sz, &max_sz, &min_nr_a, &max_nr_a,
> +				&min_age, &max_age, &action, &parsed);
> +		if (ret != 7)
> +			break;
> +		if (action >= DAMOS_ACTION_LEN) {
> +			pr_err("wrong action %d\n", action);
> +			goto fail;
> +		}
> +
> +		pos += parsed;
> +		scheme = damon_new_scheme(min_sz, max_sz, min_nr_a, max_nr_a,
> +				min_age, max_age, action);
> +		if (!scheme)
> +			goto fail;
> +
> +		schemes[*nr_schemes] = scheme;
> +		*nr_schemes += 1;
> +	}
> +	if (!*nr_schemes)
> +		goto fail;
> +	return schemes;
> +fail:
> +	free_schemes_arr(schemes, *nr_schemes);
> +	return NULL;
> +}
> +
> +static ssize_t debugfs_schemes_write(struct file *file, const char __user *buf,
> +		size_t count, loff_t *ppos)
> +{
> +	struct damon_ctx *ctx = &damon_user_ctx;
> +	char *kbuf;
> +	struct damos **schemes;
> +	ssize_t nr_schemes = 0, ret;
> +	int err;
> +
> +	if (*ppos)
> +		return -EINVAL;
> +
> +	kbuf = kmalloc(count, GFP_KERNEL);
> +	if (!kbuf)
> +		return -ENOMEM;
> +
> +	ret = simple_write_to_buffer(kbuf, count, ppos, buf, count);
> +	if (ret < 0)
> +		goto out;
> +
> +	schemes = str_to_schemes(kbuf, ret, &nr_schemes);

In case of wrong input, 'str_to_schemes()' could return NULL with non-zero
nr_schemes, but the case is not handled here.  I will properly handle the case
in the next spin.


Thanks,
SeongJae Park

> +
> +	mutex_lock(&ctx->kdamond_lock);
> +	if (ctx->kdamond) {
> +		ret = -EBUSY;
> +		goto unlock_out;
> +	}
> +
> +	err = damon_set_schemes(ctx, schemes, nr_schemes);
> +	if (err)
> +		ret = err;
> +	else
> +		nr_schemes = 0;
> +unlock_out:
> +	mutex_unlock(&ctx->kdamond_lock);
> +	free_schemes_arr(schemes, nr_schemes);
> +out:
> +	kfree(kbuf);
> +	return ret;
> +}
> +


  reply	other threads:[~2020-06-04 11:18 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-26  7:56 [RFC v9 0/8] Implement Data Access Monitoring-based Memory Operation Schemes SeongJae Park
2020-05-26  7:56 ` [RFC v9 1/8] mm/madvise: Export do_madvise() to external GPL modules SeongJae Park
2020-05-26  7:56 ` [RFC v9 2/8] mm/damon: Account age of target regions SeongJae Park
2020-05-26  7:56 ` [RFC v9 3/8] mm/damon: Implement data access monitoring-based operation schemes SeongJae Park
2020-05-26  7:56 ` [RFC v9 4/8] mm/damon/schemes: Implement a debugfs interface SeongJae Park
2020-06-04 11:17   ` SeongJae Park [this message]
2020-05-26  7:56 ` [RFC v9 5/8] mm/damon/schemes: Implement statistics feature SeongJae Park
2020-05-26  7:57 ` [RFC v9 6/8] mm/damon/selftests: Add 'schemes' debugfs tests SeongJae Park
2020-05-26  8:08 ` [RFC v9 7/8] damon/tools: Support more human friendly 'schemes' control SeongJae Park
2020-05-26  8:08 ` [RFC v9 8/8] Documentation/admin-guide/mm: Document DAMON-based operation schemes SeongJae Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200604111757.7659-1-sjpark@amazon.com \
    --to=sjpark@amazon.com \
    --cc=Jonathan.Cameron@Huawei.com \
    --cc=aarcange@redhat.com \
    --cc=acme@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=amit@kernel.org \
    --cc=benh@kernel.crashing.org \
    --cc=brendan.d.gregg@gmail.com \
    --cc=brendanhiggins@google.com \
    --cc=cai@lca.pw \
    --cc=colin.king@canonical.com \
    --cc=corbet@lwn.net \
    --cc=dwmw@amazon.com \
    --cc=irogers@google.com \
    --cc=jolsa@redhat.com \
    --cc=kirill@shutemov.name \
    --cc=linux-damon@amazon.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mark.rutland@arm.com \
    --cc=mgorman@suse.de \
    --cc=minchan@kernel.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=rdunlap@infradead.org \
    --cc=riel@surriel.com \
    --cc=rientjes@google.com \
    --cc=rostedt@goodmis.org \
    --cc=sblbir@amazon.com \
    --cc=shakeelb@google.com \
    --cc=shuah@kernel.org \
    --cc=sj38.park@gmail.com \
    --cc=sjpark@amazon.de \
    --cc=snu@amazon.de \
    --cc=vbabka@suse.cz \
    --cc=vdavydov.dev@gmail.com \
    --cc=yang.shi@linux.alibaba.com \
    --cc=ying.huang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).