From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEB89C433DF for ; Mon, 8 Jun 2020 04:40:10 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 836BE20801 for ; Mon, 8 Jun 2020 04:40:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="Ix9B3cZW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 836BE20801 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 0FA496B0005; Mon, 8 Jun 2020 00:40:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 05C376B0006; Mon, 8 Jun 2020 00:40:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E68876B0007; Mon, 8 Jun 2020 00:40:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0169.hostedemail.com [216.40.44.169]) by kanga.kvack.org (Postfix) with ESMTP id CAAD36B0005 for ; Mon, 8 Jun 2020 00:40:09 -0400 (EDT) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 8F40718128BD8 for ; Mon, 8 Jun 2020 04:40:09 +0000 (UTC) X-FDA: 76904792538.04.cart20_4713ee226db7 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin04.hostedemail.com (Postfix) with ESMTP id 6E9DA80AB81C for ; Mon, 8 Jun 2020 04:40:09 +0000 (UTC) X-HE-Tag: cart20_4713ee226db7 X-Filterd-Recvd-Size: 2772 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf42.hostedemail.com (Postfix) with ESMTP for ; Mon, 8 Jun 2020 04:40:08 +0000 (UTC) Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F306520810; Mon, 8 Jun 2020 04:40:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591591208; bh=u4QsmAcaddT05hd5kL2CQmnfdoqVzvVu1mx885IbIzY=; h=Date:From:To:Subject:In-Reply-To:From; b=Ix9B3cZWwOnNcgyezvktAN00RJN5/H/beE8fAZ++ZtFQqimlEAZ5cnqKZeMhJ5W6S KXspQ98ZCxtlJSwxMPb1tFpqk54ZcaI+qXW2vZg/Y25rvdMDIGaqDhJ156KW6B305B FyRh5ArUJwHEFV27YpjCpBlue4Cv97lCpkCdoCj4= Date: Sun, 07 Jun 2020 21:40:07 -0700 From: Andrew Morton To: akpm@linux-foundation.org, boqun.feng@gmail.com, dave@stgolabs.net, jbi.octave@gmail.com, linux-mm@kvack.org, manfred@colorfullife.com, mm-commits@vger.kernel.org, natechancellor@gmail.com, shuaibinglu@126.com, torvalds@linux-foundation.org Subject: [patch 02/54] ipc/msg: add missing annotation for freeque() Message-ID: <20200608044007.facFrVHN2%akpm@linux-foundation.org> In-Reply-To: <20200607212615.b050e41fac139a1e16fe00bd@linux-foundation.org> User-Agent: s-nail v14.8.16 X-Rspamd-Queue-Id: 6E9DA80AB81C X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam04 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Jules Irenge Subject: ipc/msg: add missing annotation for freeque() Sparse reports a warning at freeque() warning: context imbalance in freeque() - unexpected unlock The root cause is the missing annotation at freeque() Add the missing __releases(RCU) annotation Add the missing __releases(&msq->q_perm) annotation Link: http://lkml.kernel.org/r/20200403160505.2832-2-jbi.octave@gmail.com Signed-off-by: Jules Irenge Reviewed-by: Andrew Morton Cc: Boqun Feng Cc: Lu Shuaibing Cc: Nathan Chancellor Cc: Manfred Spraul Cc: Davidlohr Bueso Signed-off-by: Andrew Morton --- ipc/msg.c | 2 ++ 1 file changed, 2 insertions(+) --- a/ipc/msg.c~ipc-msg-add-missing-annotation-for-freeque +++ a/ipc/msg.c @@ -268,6 +268,8 @@ static void expunge_all(struct msg_queue * before freeque() is called. msg_ids.rwsem remains locked on exit. */ static void freeque(struct ipc_namespace *ns, struct kern_ipc_perm *ipcp) + __releases(RCU) + __releases(&msq->q_perm) { struct msg_msg *msg, *t; struct msg_queue *msq = container_of(ipcp, struct msg_queue, q_perm); _