From: Luis Chamberlain <mcgrof@kernel.org> To: axboe@kernel.dk, viro@zeniv.linux.org.uk, bvanassche@acm.org, gregkh@linuxfoundation.org, rostedt@goodmis.org, mingo@redhat.com, jack@suse.cz, ming.lei@redhat.com, nstange@suse.de, akpm@linux-foundation.org Cc: mhocko@suse.com, yukuai3@huawei.com, martin.petersen@oracle.com, jejb@linux.ibm.com, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Luis Chamberlain <mcgrof@kernel.org>, Christoph Hellwig <hch@lst.de> Subject: [PATCH v6 5/6] loop: be paranoid on exit and prevent new additions / removals Date: Mon, 8 Jun 2020 17:01:25 +0000 [thread overview] Message-ID: <20200608170127.20419-6-mcgrof@kernel.org> (raw) In-Reply-To: <20200608170127.20419-1-mcgrof@kernel.org> Be pedantic on removal as well and hold the mutex. This should prevent uses of addition while we exit. Reviewed-by: Ming Lei <ming.lei@redhat.com> Reviewed-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Luis Chamberlain <mcgrof@kernel.org> --- drivers/block/loop.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/block/loop.c b/drivers/block/loop.c index c33bbbfd1bd9..d55e1b52f076 100644 --- a/drivers/block/loop.c +++ b/drivers/block/loop.c @@ -2402,6 +2402,8 @@ static void __exit loop_exit(void) range = max_loop ? max_loop << part_shift : 1UL << MINORBITS; + mutex_lock(&loop_ctl_mutex); + idr_for_each(&loop_index_idr, &loop_exit_cb, NULL); idr_destroy(&loop_index_idr); @@ -2409,6 +2411,8 @@ static void __exit loop_exit(void) unregister_blkdev(LOOP_MAJOR, "loop"); misc_deregister(&loop_misc); + + mutex_unlock(&loop_ctl_mutex); } module_init(loop_init); -- 2.26.2
next prev parent reply other threads:[~2020-06-08 17:01 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-06-08 17:01 [PATCH v6 0/8] block: fix blktrace debugfs use after free Luis Chamberlain 2020-06-08 17:01 ` [PATCH v6 1/6] block: add docs for gendisk / request_queue refcount helpers Luis Chamberlain 2020-06-08 17:01 ` [PATCH v6 2/6] block: clarify context for refcount increment helpers Luis Chamberlain 2020-06-08 17:01 ` [PATCH v6 3/6] block: revert back to synchronous request_queue removal Luis Chamberlain 2020-06-13 1:53 ` Bart Van Assche 2020-06-19 20:23 ` Luis Chamberlain 2020-06-08 17:01 ` [PATCH v6 4/6] blktrace: annotate required lock on do_blk_trace_setup() Luis Chamberlain 2020-06-09 14:18 ` Christoph Hellwig 2020-06-13 1:54 ` Bart Van Assche 2020-06-08 17:01 ` Luis Chamberlain [this message] 2020-06-08 17:01 ` [PATCH v6 6/6] blktrace: fix debugfs use after free Luis Chamberlain 2020-06-09 15:06 ` Christoph Hellwig 2020-06-09 17:29 ` Luis Chamberlain 2020-06-09 17:32 ` Christoph Hellwig 2020-06-09 17:53 ` Luis Chamberlain 2020-06-10 6:42 ` Christoph Hellwig 2020-06-10 21:09 ` Luis Chamberlain 2020-06-10 21:52 ` Luis Chamberlain 2020-06-10 23:31 ` Luis Chamberlain 2020-06-11 5:40 ` Christoph Hellwig 2020-06-13 2:42 ` Bart Van Assche 2020-06-19 15:36 ` Luis Chamberlain
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200608170127.20419-6-mcgrof@kernel.org \ --to=mcgrof@kernel.org \ --cc=akpm@linux-foundation.org \ --cc=axboe@kernel.dk \ --cc=bvanassche@acm.org \ --cc=gregkh@linuxfoundation.org \ --cc=hch@lst.de \ --cc=jack@suse.cz \ --cc=jejb@linux.ibm.com \ --cc=linux-block@vger.kernel.org \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=martin.petersen@oracle.com \ --cc=mhocko@suse.com \ --cc=ming.lei@redhat.com \ --cc=mingo@redhat.com \ --cc=nstange@suse.de \ --cc=rostedt@goodmis.org \ --cc=viro@zeniv.linux.org.uk \ --cc=yukuai3@huawei.com \ --subject='Re: [PATCH v6 5/6] loop: be paranoid on exit and prevent new additions / removals' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).