From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 085B4C433E2 for ; Tue, 9 Jun 2020 13:43:15 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C76D020760 for ; Tue, 9 Jun 2020 13:43:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C76D020760 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 4F0B66B0003; Tue, 9 Jun 2020 09:43:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4A1546B000D; Tue, 9 Jun 2020 09:43:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3685D6B000E; Tue, 9 Jun 2020 09:43:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0222.hostedemail.com [216.40.44.222]) by kanga.kvack.org (Postfix) with ESMTP id 1C3206B0003 for ; Tue, 9 Jun 2020 09:43:14 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id CD23718197626 for ; Tue, 9 Jun 2020 13:43:13 +0000 (UTC) X-FDA: 76909789866.22.coil05_1b1211726dc3 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin22.hostedemail.com (Postfix) with ESMTP id AB25418038C25 for ; Tue, 9 Jun 2020 13:43:13 +0000 (UTC) X-HE-Tag: coil05_1b1211726dc3 X-Filterd-Recvd-Size: 3691 Received: from mail-ed1-f66.google.com (mail-ed1-f66.google.com [209.85.208.66]) by imf03.hostedemail.com (Postfix) with ESMTP for ; Tue, 9 Jun 2020 13:43:13 +0000 (UTC) Received: by mail-ed1-f66.google.com with SMTP id m21so16367369eds.13 for ; Tue, 09 Jun 2020 06:43:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=tDta39kY0KD/UCX5IqkzMlRDHf+tP30+naJxD+kt06Q=; b=Gipb39A0SeRfFk/PI9VpLJnMI1kOgB+uVofJyXanMqnfwpsHloas10nsDN4shMomDr mCNvocao7xKlLF5m//McbeahesOZvuLEQaR1OgYcshhxnfh+ymGWL4LLS3nPItYM/N2i rt/ZeZcP7gxuiKor8+LAOZ2lddX1sRg8IMSZwAxPzjDTwMzWeLnKRk5zcg12vniZaoua lwngItqLNsb6sY2Ql3cjffzbQBYpYc3QjIWZinmmgtvHJC5iNuHvOor5R3oOUxptQcJh gJeTuGBqtnEsPHnLrGZ9VBrtisPkl4xw4LSBUj61ClolL6idR5cTvyPraYl0gGnH/xUG hwSA== X-Gm-Message-State: AOAM532552ASOHYhUyx9neJdxzkCTTMX/ND5i19W1d/ZZ3chyQFjoMO7 BjEQpnf+V7NMM67lOc87tvw= X-Google-Smtp-Source: ABdhPJz+oNcGe2WzhWETpnlzI4CI5Vqr6XnKJBcnd8A69F1kji+h8swMtpeYP1ajEvMvYUnBdUw2gA== X-Received: by 2002:aa7:c2c7:: with SMTP id m7mr26587825edp.148.1591710192306; Tue, 09 Jun 2020 06:43:12 -0700 (PDT) Received: from localhost (ip-37-188-174-195.eurotel.cz. [37.188.174.195]) by smtp.gmail.com with ESMTPSA id q14sm15832047edj.47.2020.06.09.06.43.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jun 2020 06:43:11 -0700 (PDT) Date: Tue, 9 Jun 2020 15:43:09 +0200 From: Michal Hocko To: js1304@gmail.com Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@lge.com, Vlastimil Babka , Christoph Hellwig , Roman Gushchin , Mike Kravetz , Naoya Horiguchi , Joonsoo Kim Subject: Re: [PATCH v2 05/12] mm/hugetlb: unify hugetlb migration callback function Message-ID: <20200609134309.GG22623@dhcp22.suse.cz> References: <1590561903-13186-1-git-send-email-iamjoonsoo.kim@lge.com> <1590561903-13186-6-git-send-email-iamjoonsoo.kim@lge.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1590561903-13186-6-git-send-email-iamjoonsoo.kim@lge.com> X-Rspamd-Queue-Id: AB25418038C25 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam04 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed 27-05-20 15:44:56, Joonsoo Kim wrote: [...] > -/* page migration callback function */ > struct page *alloc_huge_page_nodemask(struct hstate *h, > struct alloc_control *ac) > { > ac->gfp_mask |= htlb_alloc_mask(h); > + if (ac->nid == NUMA_NO_NODE) > + ac->gfp_mask &= ~__GFP_THISNODE; Is this really needed? alloc_huge_page_node is currently only called from numa migration code and the target node should be always defined. > > spin_lock(&hugetlb_lock); > if (h->free_huge_pages - h->resv_huge_pages > 0) { > diff --git a/mm/mempolicy.c b/mm/mempolicy.c > index 3b6b551..e705efd 100644 > --- a/mm/mempolicy.c > +++ b/mm/mempolicy.c > @@ -1073,9 +1073,10 @@ struct page *alloc_new_node_page(struct page *page, unsigned long node) > struct alloc_control ac = { > .nid = node, > .nmask = NULL, > + .gfp_mask = __GFP_THISNODE, > }; > > - return alloc_huge_page_node(h, &ac); > + return alloc_huge_page_nodemask(h, &ac); > } else if (PageTransHuge(page)) { > struct page *thp; > > -- > 2.7.4 > -- Michal Hocko SUSE Labs