From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3876C433E0 for ; Tue, 9 Jun 2020 14:04:44 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B1A9820737 for ; Tue, 9 Jun 2020 14:04:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B1A9820737 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 55E716B0002; Tue, 9 Jun 2020 10:04:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 535D26B0003; Tue, 9 Jun 2020 10:04:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 44C036B0005; Tue, 9 Jun 2020 10:04:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0223.hostedemail.com [216.40.44.223]) by kanga.kvack.org (Postfix) with ESMTP id 2CB346B0002 for ; Tue, 9 Jun 2020 10:04:44 -0400 (EDT) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id E29BD181AEF32 for ; Tue, 9 Jun 2020 14:04:43 +0000 (UTC) X-FDA: 76909844046.18.run48_170893d26dc3 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin18.hostedemail.com (Postfix) with ESMTP id 419C01004F22D for ; Tue, 9 Jun 2020 14:04:24 +0000 (UTC) X-HE-Tag: run48_170893d26dc3 X-Filterd-Recvd-Size: 3223 Received: from mail-ej1-f66.google.com (mail-ej1-f66.google.com [209.85.218.66]) by imf09.hostedemail.com (Postfix) with ESMTP for ; Tue, 9 Jun 2020 14:04:21 +0000 (UTC) Received: by mail-ej1-f66.google.com with SMTP id p20so2530329ejd.13 for ; Tue, 09 Jun 2020 07:04:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=rADE/GPer5pfmlG1o046PpkI8Ugu5r7+dgrjwwvPKsw=; b=ZHLIVTvTUMtB4OdiuUPSH0gzDLmadb1ClNwInA5oLYoFj+eyeywna4uZD12woGFPrd LQF5JYINPW3YqdLsGwIliJACQSkjg4oTtsXvLUg/6t9CHSmhglFNnKSSGasT6sT3DDV5 obHTxvSZ3tQ0OJ934pQ6WojZyLF4Y6K+rSBTfH0BLUo7LrSXez8+EdwWJxEUX7XeL1z1 YVUv1cXG9VM5KqSveoxmkWN50/oIL5u80Kwqf7mwF7KeiMTglvE+/1gmE/igJh7gN1G4 t9MTYwbaOFsbqz9jE3OePg0IqvDRGRcIhshs4xbCKS++bIydnttlFtPjF814/1ONzWbW 60QQ== X-Gm-Message-State: AOAM532i4hPqc9h2QinZqj/uF30mg8s7UAHJjgTrdezB+dyHEzDPvsmj 62orBUSweqAERW6A+dxenZk= X-Google-Smtp-Source: ABdhPJye3E4nF9Tfgq0sYEhkY/VSEO4GQ036arOykcbaFKSmVp+Ky5eyQGTAiB8RhWhxG/9yKBVBCw== X-Received: by 2002:a17:906:dbda:: with SMTP id yc26mr18056921ejb.82.1591711460158; Tue, 09 Jun 2020 07:04:20 -0700 (PDT) Received: from localhost (ip-37-188-174-195.eurotel.cz. [37.188.174.195]) by smtp.gmail.com with ESMTPSA id cx13sm15237750edb.20.2020.06.09.07.04.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jun 2020 07:04:19 -0700 (PDT) Date: Tue, 9 Jun 2020 16:04:18 +0200 From: Michal Hocko To: js1304@gmail.com Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@lge.com, Vlastimil Babka , Christoph Hellwig , Roman Gushchin , Mike Kravetz , Naoya Horiguchi , Joonsoo Kim Subject: Re: [PATCH v2 08/12] mm/migrate: change the interface of the migration target alloc/free functions Message-ID: <20200609140418.GJ22623@dhcp22.suse.cz> References: <1590561903-13186-1-git-send-email-iamjoonsoo.kim@lge.com> <1590561903-13186-9-git-send-email-iamjoonsoo.kim@lge.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1590561903-13186-9-git-send-email-iamjoonsoo.kim@lge.com> X-Rspamd-Queue-Id: 419C01004F22D X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed 27-05-20 15:44:59, Joonsoo Kim wrote: > From: Joonsoo Kim > > To prepare unifying duplicated functions in following patches, this patch > changes the interface of the migration target alloc/free functions. > Functions now use struct alloc_control as an argument. It also pulls private argument into alloc_control and keeps it that way. Wouldn't it be better to use explicit types and names in a union? Each allocation callback has to understant the meaning anyway. I would consider the resulting code cleaner that way. What do you think? -- Michal Hocko SUSE Labs