From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93012C433E0 for ; Tue, 9 Jun 2020 22:26:10 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 610A62076A for ; Tue, 9 Jun 2020 22:26:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="ssSgTXw4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 610A62076A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id BA6316B0002; Tue, 9 Jun 2020 18:26:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B577B6B0005; Tue, 9 Jun 2020 18:26:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A6C7A6B0006; Tue, 9 Jun 2020 18:26:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0197.hostedemail.com [216.40.44.197]) by kanga.kvack.org (Postfix) with ESMTP id 909AA6B0002 for ; Tue, 9 Jun 2020 18:26:08 -0400 (EDT) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 5A928180995F5 for ; Tue, 9 Jun 2020 22:26:08 +0000 (UTC) X-FDA: 76911107616.17.stick37_3f1136e26dc6 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin17.hostedemail.com (Postfix) with ESMTP id 303A71801C424 for ; Tue, 9 Jun 2020 22:26:08 +0000 (UTC) X-HE-Tag: stick37_3f1136e26dc6 X-Filterd-Recvd-Size: 4264 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf26.hostedemail.com (Postfix) with ESMTP for ; Tue, 9 Jun 2020 22:26:07 +0000 (UTC) Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 784ED2076A; Tue, 9 Jun 2020 22:26:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591741566; bh=y3CrSu5AtvCVTv3II11wDNLsV7c/5U65GQroY6N6NyU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ssSgTXw4paOP0dBgnbWySldNVV76N5BOf5AwoKNmNpjkAUJHDATtOagEEu+Gu6CKK IGP6YQcW/Z+SNW7uqq0vCcp0VLNViDvL5gzcBPzME3Xvb/rrFs/GO9kBZSR3RUniUr bO3p3eWEE1Jb0xT13LjvLePAy0McYYy4qWU3hNHc= Date: Tue, 9 Jun 2020 15:26:06 -0700 From: Andrew Morton To: kernel test robot Cc: Mike Rapoport , kbuild-all@lists.01.org, Johannes Weiner , Linux Memory Management List Subject: Re: [hnaz-linux-mm:master 60/194] include/linux/pgtable.h:74:27: error: redefinition of 'pte_offset_kernel' Message-Id: <20200609152606.b08651fe680ee9c6e94540ad@linux-foundation.org> In-Reply-To: <202006100010.WRBnCFU1%lkp@intel.com> References: <202006100010.WRBnCFU1%lkp@intel.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 303A71801C424 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam03 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 10 Jun 2020 00:12:12 +0800 kernel test robot wrote: > tree: https://github.com/hnaz/linux-mm master > head: a017b085735719105714da692a82a6eeb8830718 > commit: f48b9eb10f8c3f378ea4552fee58db3dea980e62 [60/194] mm: consolidate pte_index() and pte_offset_*() definitions > config: sparc-defconfig (attached as .config) > compiler: sparc-linux-gcc (GCC) 9.3.0 > reproduce (this is a W=1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > git checkout f48b9eb10f8c3f378ea4552fee58db3dea980e62 > # save the attached .config to linux build tree > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sparc > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > > All error/warnings (new ones prefixed by >>, old ones prefixed by <<): > > In file included from include/linux/mm.h:31, > from include/linux/memblock.h:13, > from arch/sparc/mm/srmmu.c:14: > >> include/linux/pgtable.h:74:27: error: redefinition of 'pte_offset_kernel' > 74 | #define pte_offset_kernel pte_offset_kernel > | ^~~~~~~~~~~~~~~~~ > >> arch/sparc/mm/srmmu.c:144:8: note: in expansion of macro 'pte_offset_kernel' > 144 | pte_t *pte_offset_kernel(pmd_t *dir, unsigned long address) > | ^~~~~~~~~~~~~~~~~ > include/linux/pgtable.h:70:22: note: previous definition of 'pte_offset_kernel' was here > 70 | static inline pte_t *pte_offset_kernel(pmd_t *pmd, unsigned long address) > | ^~~~~~~~~~~~~~~~~ > arch/sparc/mm/srmmu.c: In function 'poke_hypersparc': > arch/sparc/mm/srmmu.c:1093:25: error: variable 'clear' set but not used [-Werror=unused-but-set-variable] > 1093 | volatile unsigned long clear; Well dang. The function was supposed to have been removed but obviously this was lost during all the merging messes. Mike, can you please confirm that this is still good? --- a/arch/sparc/mm/srmmu.c~a +++ a/arch/sparc/mm/srmmu.c @@ -140,16 +140,6 @@ void pmd_set(pmd_t *pmdp, pte_t *ptep) set_pte((pte_t *)&pmd_val(*pmdp), __pte(SRMMU_ET_PTD | ptp)); } -/* Find an entry in the third-level page table.. */ -pte_t *pte_offset_kernel(pmd_t *dir, unsigned long address) -{ - void *pte; - - pte = __nocache_va((pmd_val(*dir) & SRMMU_PTD_PMASK) << 4); - return (pte_t *) pte + - ((address >> PAGE_SHIFT) & (PTRS_PER_PTE - 1)); -} - /* * size: bytes to allocate in the nocache area. * align: bytes, number to align at. _