From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1403BC433DF for ; Wed, 10 Jun 2020 20:39:51 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C109B206A4 for ; Wed, 10 Jun 2020 20:39:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="F4zTFIQB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C109B206A4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B8EB58D0030; Wed, 10 Jun 2020 16:39:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AF49C8D002D; Wed, 10 Jun 2020 16:39:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 882058D0030; Wed, 10 Jun 2020 16:39:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0082.hostedemail.com [216.40.44.82]) by kanga.kvack.org (Postfix) with ESMTP id 5BCD28D002D for ; Wed, 10 Jun 2020 16:39:32 -0400 (EDT) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 231D88019DD7 for ; Wed, 10 Jun 2020 20:39:32 +0000 (UTC) X-FDA: 76914467784.16.sign81_00151bc26dce Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin16.hostedemail.com (Postfix) with ESMTP id E828010272E24 for ; Wed, 10 Jun 2020 20:39:31 +0000 (UTC) X-HE-Tag: sign81_00151bc26dce X-Filterd-Recvd-Size: 2688 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf02.hostedemail.com (Postfix) with ESMTP for ; Wed, 10 Jun 2020 20:39:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=33n6uHIDU/xwgJxMoeJs++K6GI7dTUyUJxhDT49yQow=; b=F4zTFIQBmlQAqxKjoc16EhcY4g VDaIF7Tnc7ZuUPpoYpIo4Hs+R4wqGUFkQFSMA5eilS6i+6eHGnqeaZqDu/0FcdTIY4pvRjcJURHeZ hxQ4WaKXHesAjK4W6g7UOoRUHkeVt/mQr1tOQGEqz2tTyHYMcVYczOnssY+QZkP9XFIK/8gfm0SSY 0mJFXwxZA4noGIpK3rBov1HwCkm8HCsZw+8SKbXOpAdVUrb5fOtzQxE2v15zudkDTyySSAveZ4QGF KBBADkbLpfr8h+l4/EUjBTxJKKZoMDc4gXlhrO/i12MaLUXcUiHZwK4MxzISo3xA4SzV/KFSJWIxS XLKP1Cpw==; Received: from willy by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jj76a-0003W9-F4; Wed, 10 Jun 2020 20:13:48 +0000 From: Matthew Wilcox To: linux-fsdevel@vger.kernel.org Cc: "Matthew Wilcox (Oracle)" , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Christoph Hellwig Subject: [PATCH v6 30/51] iomap: Inline data shouldn't see THPs Date: Wed, 10 Jun 2020 13:13:24 -0700 Message-Id: <20200610201345.13273-31-willy@infradead.org> X-Mailer: git-send-email 2.21.1 In-Reply-To: <20200610201345.13273-1-willy@infradead.org> References: <20200610201345.13273-1-willy@infradead.org> MIME-Version: 1.0 X-Rspamd-Queue-Id: E828010272E24 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: "Matthew Wilcox (Oracle)" Assert that we're not seeing THPs in functions that read/write inline data, rather than zeroing out the tail. Signed-off-by: Matthew Wilcox (Oracle) Reviewed-by: Christoph Hellwig --- fs/iomap/buffered-io.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/iomap/buffered-io.c b/fs/iomap/buffered-io.c index 9275268ea97e..318c1ecc18c0 100644 --- a/fs/iomap/buffered-io.c +++ b/fs/iomap/buffered-io.c @@ -215,6 +215,7 @@ iomap_read_inline_data(struct inode *inode, struct pa= ge *page, return; =20 BUG_ON(page->index); + BUG_ON(PageCompound(page)); BUG_ON(size > PAGE_SIZE - offset_in_page(iomap->inline_data)); =20 addr =3D kmap_atomic(page); @@ -728,6 +729,7 @@ static size_t iomap_write_end_inline(struct inode *in= ode, struct page *page, void *addr; =20 WARN_ON_ONCE(!PageUptodate(page)); + BUG_ON(PageCompound(page)); BUG_ON(pos + copied > PAGE_SIZE - offset_in_page(iomap->inline_data)); =20 addr =3D kmap_atomic(page); --=20 2.26.2