From: Minchan Kim <minchan@kernel.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
arjunroy@google.com, Brian Geffon <bgeffon@google.com>,
Christian Brauner <christian.brauner@ubuntu.com>,
Daniel Colascione <dancol@google.com>,
Johannes Weiner <hannes@cmpxchg.org>,
joaodias@google.com, Joel Fernandes <joel@joelfernandes.org>,
Linux-MM <linux-mm@kvack.org>, Michal Hocko <mhocko@suse.com>,
mm-commits@vger.kernel.org,
Oleksandr Natalenko <oleksandr@redhat.com>,
David Rientjes <rientjes@google.com>,
Shakeel Butt <shakeelb@google.com>,
sj38.park@gmail.com, Sonny Rao <sonnyrao@google.com>,
sspatil@google.com, Suren Baghdasaryan <surenb@google.com>,
Tim Murray <timmurray@google.com>,
Vlastimil Babka <vbabka@suse.cz>
Subject: Re: [patch 24/25] mm: use only pidfd for process_madvise syscall
Date: Wed, 10 Jun 2020 20:10:06 -0700 [thread overview]
Message-ID: <20200611031006.GA137891@google.com> (raw)
In-Reply-To: <CAHk-=wgx=-vbxpDqsunkMTqQDD+oqcU9JQeW+MApGQeZD6hr6Q@mail.gmail.com>
On Wed, Jun 10, 2020 at 07:09:16PM -0700, Linus Torvalds wrote:
> On Wed, Jun 10, 2020 at 6:42 PM Andrew Morton <akpm@linux-foundation.org> wrote:
> >
> > From: Minchan Kim <minchan@kernel.org>
> > Subject: mm: use only pidfd for process_madvise syscall
>
> No.
>
> I'm not taking this crazy series.
>
> First we have patch 18/25, which introduces process_madvise() that
> takes a pidfd.
>
> Then we have patch 21/25, which says
>
> "There is a demand[1] to support pid as well pidfd for process_madvise.."
>
> and points to
>
> https://lore.kernel.org/linux-mm/9d849087-3359-c4ab-fbec-859e8186c509@virtuozzo.com/
>
> And then finally we have patch 24/25, which says
>
> "Based on discussion[1], people didn't feel we need to support both
> pid and pidfd for every new coming API[2] so this patch keeps only
> pidfd"
>
> and points to
>
> https://lore.kernel.org/linux-mm/20200509124817.xmrvsrq3mla6b76k@wittgenstein/
>
> Fine. Discussion is good. But this patch-series is crazy, and I refuse
> to take this kind of schizophrenic patches that can't make up their
> mind.
>
> Make up your mind, dammit! Don't send me patches that vacillate
> between two standpoints and make the history and the eventual final
> end result really hard to tell.
>
> What will it be tomorrow? Another two patches that decide to go the
> other way and then back?
>
> I'm going to flush this whole madvise patch-set down the toilet,
> because after having this kind of whip-lash looking through it, I
> can't take it any more.
>
> So all of 17-25 are just going in the garbage until people can make up
> their minds.
At next revision, I will merge 18 and 23 into a patch with dropping
21 and 24.
Andrew, I will resend it after rc window is closed.
Thanks.
[patch 18/25] mm/madvise: introduce process_madvise() syscall: an external memory hinting API
[patch 21/25] mm/madvise: support both pid and pidfd for process_madvise
[patch 23/25] mm: support vector address ranges for process_madvise
[patch 24/25] mm: use only pidfd for process_madvise syscall
next prev parent reply other threads:[~2020-06-11 3:10 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-11 1:40 incoming Andrew Morton
2020-06-11 1:41 ` [patch 01/25] khugepaged: selftests: fix timeout condition in wait_for_scan() Andrew Morton
2020-06-11 1:41 ` [patch 02/25] scripts/spelling: add a few more typos Andrew Morton
2020-06-11 1:41 ` [patch 03/25] kcov: check kcov_softirq in kcov_remote_stop() Andrew Morton
2020-06-11 1:41 ` [patch 04/25] lib/lz4/lz4_decompress.c: document deliberate use of `&' Andrew Morton
2020-06-11 1:41 ` [patch 05/25] nilfs2: fix null pointer dereference at nilfs_segctor_do_construct() Andrew Morton
2020-06-11 1:41 ` [patch 06/25] checkpatch: correct check for kernel parameters doc Andrew Morton
2020-06-11 1:41 ` [patch 07/25] lib: fix bitmap_parse() on 64-bit big endian archs Andrew Morton
2020-06-11 1:41 ` [patch 08/25] mm/debug_vm_pgtable: fix kernel crash by checking for THP support Andrew Morton
2020-06-11 1:41 ` [patch 09/25] ocfs2: fix spelling mistake and grammar Andrew Morton
2020-06-11 1:41 ` [patch 10/25] mm: add comments on pglist_data zones Andrew Morton
2020-06-11 1:41 ` [patch 11/25] lib: test get_count_order/long in test_bitops.c Andrew Morton
2020-06-11 1:41 ` [patch 12/25] stacktrace: cleanup inconsistent variable type Andrew Morton
2020-06-11 1:41 ` [patch 13/25] kernel: move use_mm/unuse_mm to kthread.c Andrew Morton
2020-06-11 1:42 ` [patch 14/25] " Andrew Morton
2020-06-11 1:42 ` [patch 15/25] kernel: better document the use_mm/unuse_mm API contract Andrew Morton
2020-06-11 1:42 ` [patch 16/25] kernel: set USER_DS in kthread_use_mm Andrew Morton
2020-06-11 1:42 ` [patch 17/25] mm/madvise: pass task and mm to do_madvise Andrew Morton
2020-06-11 1:42 ` [patch 18/25] mm/madvise: introduce process_madvise() syscall: an external memory hinting API Andrew Morton
2020-06-11 1:42 ` [patch 19/25] mm/madvise: check fatal signal pending of target process Andrew Morton
2020-06-11 1:42 ` [patch 20/25] pid: move pidfd_get_pid() to pid.c Andrew Morton
2020-06-11 1:42 ` [patch 21/25] mm/madvise: support both pid and pidfd for process_madvise Andrew Morton
2020-06-11 1:42 ` [patch 22/25] mm/madvise: allow KSM hints for remote API Andrew Morton
2020-06-11 1:42 ` [patch 23/25] mm: support vector address ranges for process_madvise Andrew Morton
2020-06-11 1:42 ` [patch 24/25] mm: use only pidfd for process_madvise syscall Andrew Morton
2020-06-11 2:09 ` Linus Torvalds
2020-06-11 3:10 ` Minchan Kim [this message]
2020-06-11 1:42 ` [patch 25/25] mm/madvise.c: remove duplicated include Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200611031006.GA137891@google.com \
--to=minchan@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=arjunroy@google.com \
--cc=bgeffon@google.com \
--cc=christian.brauner@ubuntu.com \
--cc=dancol@google.com \
--cc=hannes@cmpxchg.org \
--cc=joaodias@google.com \
--cc=joel@joelfernandes.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=mm-commits@vger.kernel.org \
--cc=oleksandr@redhat.com \
--cc=rientjes@google.com \
--cc=shakeelb@google.com \
--cc=sj38.park@gmail.com \
--cc=sonnyrao@google.com \
--cc=sspatil@google.com \
--cc=surenb@google.com \
--cc=timmurray@google.com \
--cc=torvalds@linux-foundation.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).