* [PATCH] scsi: iscsi: Do not put host in iscsi_set_flashnode_param()
@ 2020-06-15 8:12 Jing Xiangfeng
2020-07-26 5:31 ` Mike Christie
2020-07-29 4:10 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Jing Xiangfeng @ 2020-06-15 8:12 UTC (permalink / raw)
To: lduncan, cleech, jejb, martin.petersen
Cc: open-iscsi, linux-scsi, linux-kernel, linux-mm, jingxiangfeng
If scsi_host_lookup() failes we will jump to put_host, which may
cause panic. Jump to exit_set_fnode to fix it.
Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
---
drivers/scsi/scsi_transport_iscsi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/scsi_transport_iscsi.c b/drivers/scsi/scsi_transport_iscsi.c
index f4cc08e..c5e99f9 100644
--- a/drivers/scsi/scsi_transport_iscsi.c
+++ b/drivers/scsi/scsi_transport_iscsi.c
@@ -3291,7 +3291,7 @@ static int iscsi_set_flashnode_param(struct iscsi_transport *transport,
pr_err("%s could not find host no %u\n",
__func__, ev->u.set_flashnode.host_no);
err = -ENODEV;
- goto put_host;
+ goto exit_set_fnode;
}
idx = ev->u.set_flashnode.flashnode_idx;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: iscsi: Do not put host in iscsi_set_flashnode_param()
2020-06-15 8:12 [PATCH] scsi: iscsi: Do not put host in iscsi_set_flashnode_param() Jing Xiangfeng
@ 2020-07-26 5:31 ` Mike Christie
2020-07-29 4:10 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Mike Christie @ 2020-07-26 5:31 UTC (permalink / raw)
To: Jing Xiangfeng, lduncan, cleech, jejb, martin.petersen
Cc: open-iscsi, linux-scsi, linux-kernel, linux-mm
On 6/15/20 3:12 AM, Jing Xiangfeng wrote:
> If scsi_host_lookup() failes we will jump to put_host, which may
> cause panic. Jump to exit_set_fnode to fix it.
>
> Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
> ---
> drivers/scsi/scsi_transport_iscsi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/scsi_transport_iscsi.c b/drivers/scsi/scsi_transport_iscsi.c
> index f4cc08e..c5e99f9 100644
> --- a/drivers/scsi/scsi_transport_iscsi.c
> +++ b/drivers/scsi/scsi_transport_iscsi.c
> @@ -3291,7 +3291,7 @@ static int iscsi_set_flashnode_param(struct iscsi_transport *transport,
> pr_err("%s could not find host no %u\n",
> __func__, ev->u.set_flashnode.host_no);
> err = -ENODEV;
> - goto put_host;
> + goto exit_set_fnode;
> }
>
> idx = ev->u.set_flashnode.flashnode_idx;
>
Reviewed-by: Mike Christie <michael.christie@oracle.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: iscsi: Do not put host in iscsi_set_flashnode_param()
2020-06-15 8:12 [PATCH] scsi: iscsi: Do not put host in iscsi_set_flashnode_param() Jing Xiangfeng
2020-07-26 5:31 ` Mike Christie
@ 2020-07-29 4:10 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2020-07-29 4:10 UTC (permalink / raw)
To: Jing Xiangfeng, jejb, cleech, lduncan
Cc: Martin K . Petersen, open-iscsi, linux-kernel, linux-scsi, linux-mm
On Mon, 15 Jun 2020 16:12:26 +0800, Jing Xiangfeng wrote:
> If scsi_host_lookup() failes we will jump to put_host, which may
> cause panic. Jump to exit_set_fnode to fix it.
Applied to 5.9/scsi-queue, thanks!
[1/1] scsi: iscsi: Do not put host in iscsi_set_flashnode_param()
https://git.kernel.org/mkp/scsi/c/68e12e5f6135
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-07-29 4:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-15 8:12 [PATCH] scsi: iscsi: Do not put host in iscsi_set_flashnode_param() Jing Xiangfeng
2020-07-26 5:31 ` Mike Christie
2020-07-29 4:10 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).