From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6E33C433E1 for ; Wed, 17 Jun 2020 13:35:12 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5076621556 for ; Wed, 17 Jun 2020 13:35:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cmpxchg-org.20150623.gappssmtp.com header.i=@cmpxchg-org.20150623.gappssmtp.com header.b="Hy1d/ERy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5076621556 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cmpxchg.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6B06D6B0007; Wed, 17 Jun 2020 09:35:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 63B686B000A; Wed, 17 Jun 2020 09:35:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 502AE6B000D; Wed, 17 Jun 2020 09:35:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0126.hostedemail.com [216.40.44.126]) by kanga.kvack.org (Postfix) with ESMTP id 355846B0007 for ; Wed, 17 Jun 2020 09:35:11 -0400 (EDT) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id A79DD824556B for ; Wed, 17 Jun 2020 13:35:10 +0000 (UTC) X-FDA: 76938799980.18.key53_280012526e08 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin18.hostedemail.com (Postfix) with ESMTP id 7546A100EDBDC for ; Wed, 17 Jun 2020 13:35:10 +0000 (UTC) X-HE-Tag: key53_280012526e08 X-Filterd-Recvd-Size: 4406 Received: from mail-qk1-f195.google.com (mail-qk1-f195.google.com [209.85.222.195]) by imf13.hostedemail.com (Postfix) with ESMTP for ; Wed, 17 Jun 2020 13:35:09 +0000 (UTC) Received: by mail-qk1-f195.google.com with SMTP id w1so1980300qkw.5 for ; Wed, 17 Jun 2020 06:35:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=bI+LSwU3WmKQTw3s6Ynrm9kunWR6ux85bO94Rtl9UB8=; b=Hy1d/ERyRuOB+PHm+LELxp1o2YdldrppiRVKFZyx/RbXD3vjo9A0QBXm5PWd4kJKNe IpTqynvSN806MhwnVN8BDl15WWL5qjhtvYjVRcWHgUeRBKvUC/PdE1RBP/rcqSrba/fl gZP/7f3fWYzrqWgetaSNhIiuvxiMDLIRcfQdRga5mURGu115WWvvQ7yf5tu5CNqKKKod U9T2O66BCAeZX+b0MvOCrHEgUPMUuIEuuYHJ5tO/uUP4ZAE8NvbQVjnsCiwIAxlDoU/0 atGiASzPLZ5wAKzHteiMjnyfArxhvqfXuueHlzWvnDsGFMgUpREHhBa0ohJAE1eRnFDR mAig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=bI+LSwU3WmKQTw3s6Ynrm9kunWR6ux85bO94Rtl9UB8=; b=hOgT/hvUdHi7gLlK1RxV8QhzLjtitCaL8AHGo7S9zi2uWkgamKkFQo3E777KWeaTuW 4k01YglCtzKj/B6noXS/kRw+ciY7Jbp6zmQWpns/W1SrRvTfr6Da7lHsAy6fn9HXsbDz uSZdd3l5g0bEQ41bXM/7Z89QVWJcwIKkVlbt88ERgGZDsr4Y/5PL17Y/MIJ7JJ6RsA3o QWF+XH4sbzwXTihLxq5f1+U+XH3dHNFAORmXK5wgbwqB1uo10ISqBWv4YaRZoI52MIT8 h2qI8bT0e0wFm5jlE8VEgmlFUyc3T4wqpGd/mg/SD/+nFpbEHErfvF69gT1y0gJeLX4u E/5Q== X-Gm-Message-State: AOAM530Nzbjsb+64/Ui/FHYlpOlzAID3tErF3jj9s2aLWBiatRf+LHfh QM9mcTiPJNvIyod8hUwd+RlH7A== X-Google-Smtp-Source: ABdhPJyT1KFLnbxsbl7Fl39ylT63qRNdMhgI3eNkeaXzfkVKKdRpwxWQaQtewJRUQT7fLpptdev19Q== X-Received: by 2002:ae9:c10d:: with SMTP id z13mr24307857qki.3.1592400908949; Wed, 17 Jun 2020 06:35:08 -0700 (PDT) Received: from localhost (70.44.39.90.res-cmts.bus.ptd.net. [70.44.39.90]) by smtp.gmail.com with ESMTPSA id c201sm17429402qkg.57.2020.06.17.06.35.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Jun 2020 06:35:07 -0700 (PDT) Date: Wed, 17 Jun 2020 09:34:30 -0400 From: Johannes Weiner To: Michal Hocko Cc: Andrew Morton , Alex Shi , Joonsoo Kim , Shakeel Butt , Hugh Dickins , "Kirill A. Shutemov" , Roman Gushchin , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: [PATCH for 5.8] mm: do_swap_page fix up the error code instantiation Message-ID: <20200617133430.GD616830@cmpxchg.org> References: <20200508183105.225460-1-hannes@cmpxchg.org> <20200508183105.225460-17-hannes@cmpxchg.org> <20200611093523.GB20450@dhcp22.suse.cz> <20200617084927.GK9499@dhcp22.suse.cz> <20200617090238.GL9499@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200617090238.GL9499@dhcp22.suse.cz> X-Rspamd-Queue-Id: 7546A100EDBDC X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam04 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 17, 2020 at 11:02:38AM +0200, Michal Hocko wrote: > Damn, I forgot to commit my last change (s@err@ret@). Sorry about the > noise. > > From 50297dd026ebf71fe901e1945a9ce1e8d8aa083b Mon Sep 17 00:00:00 2001 > From: Michal Hocko > Date: Wed, 17 Jun 2020 10:40:47 +0200 > Subject: [PATCH] mm: do_swap_page fix up the error code > > do_swap_page returns error codes from the VM_FAULT* space. try_charge > might return -ENOMEM, though, and then do_swap_page simply returns 0 > which means a success. > > We almost never return ENOMEM for GFP_KERNEL single page charge. Except > for async OOM handling (oom_disabled v1). So this needs translation to > VM_FAULT_OOM otherwise the the page fault path will not notify the > userspace and wait for an action. > > Fixes: 4c6355b25e8b ("mm: memcontrol: charge swapin pages on instantiation") > Signed-off-by: Michal Hocko Good catch, thanks Michal. Acked-by: Johannes Weiner