From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54775C433E0 for ; Thu, 18 Jun 2020 20:38:11 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0FA4620890 for ; Thu, 18 Jun 2020 20:38:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="obxACDEx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0FA4620890 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 814DF8D005E; Thu, 18 Jun 2020 16:38:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7C5D18D0052; Thu, 18 Jun 2020 16:38:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6DAD78D005E; Thu, 18 Jun 2020 16:38:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0095.hostedemail.com [216.40.44.95]) by kanga.kvack.org (Postfix) with ESMTP id 52BA98D0052 for ; Thu, 18 Jun 2020 16:38:10 -0400 (EDT) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 6584C3B73A4 for ; Thu, 18 Jun 2020 20:38:08 +0000 (UTC) X-FDA: 76943494656.10.home64_0e087c726e13 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin10.hostedemail.com (Postfix) with ESMTP id DE90A3B124A for ; Thu, 18 Jun 2020 20:37:27 +0000 (UTC) X-HE-Tag: home64_0e087c726e13 X-Filterd-Recvd-Size: 3843 Received: from mail-pl1-f194.google.com (mail-pl1-f194.google.com [209.85.214.194]) by imf11.hostedemail.com (Postfix) with ESMTP for ; Thu, 18 Jun 2020 20:37:27 +0000 (UTC) Received: by mail-pl1-f194.google.com with SMTP id y18so2945932plr.4 for ; Thu, 18 Jun 2020 13:37:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=4QQIkRmgHybrTXF8+aaUZbCjNfbygj8GTcvHDxd6YbQ=; b=obxACDExqgeubHQInpfsuwNWX7WTaRZj65frJajCO4yTeyAVpyKn5JKbMYAAM8DzDs tnt9EQdb2nB1YGxgCobU2a6+yS10AMnN/1l9kbUMKJXMltpbB8dM4V+VaVi/yJpv4t5Q f5Q31aCmm+mMkH9G99cOjZbXxdlElGVFZd1wo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=4QQIkRmgHybrTXF8+aaUZbCjNfbygj8GTcvHDxd6YbQ=; b=P+gr9Vlk34pOu/MD+UXNSI3I6zJ/3U5fnrvc71TbnwI54MBAqbN9K3Cqy5RnD+4A9h 1/CcNMtkrYHiIO89xLtqxwI81Z1djwkrdqlYOtI9uSTOOG4utbDbxtTIRgZ90JsGpVrp cKI1hIlLhOIMFQycRNHQtc6sOpjSdrdhjxOB4pvvXyZNGUTXd7uaHL3tdgD/3+Z7szEU fTJPyOfmVFmMpmrdiVpnlTo0VrXXfpNJK+ASKsz74J16ljqb5KViGJcCrg2tQtRmrPE8 RPIzCdcpFsJzvU8omHGAC018IJRS38Eu+NzYPxUg/x1ig7wGkDpOebLVBcsia6riYNHk j5qQ== X-Gm-Message-State: AOAM5339hH8MOxMsJPTQTez+I15rKGPP66wm9h3Y4j7gtO5i+AXMGXoC Ry/pvQ9hVJZz3ThmOXZaFQPsZw== X-Google-Smtp-Source: ABdhPJxf7G59fWv+NZ1bb0k077huOL3svybUSmYEErVS77eiTZSFYthPGZHLN/HYueGaIhq3lFXpwA== X-Received: by 2002:a17:902:d697:: with SMTP id v23mr5432017ply.323.1592512646691; Thu, 18 Jun 2020 13:37:26 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id p30sm3871433pfq.59.2020.06.18.13.37.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Jun 2020 13:37:25 -0700 (PDT) Date: Thu, 18 Jun 2020 13:37:24 -0700 From: Kees Cook To: Matthew Wilcox Cc: Andrew Morton , Vlastimil Babka , Roman Gushchin , Christoph Lameter , Alexander Popov , Pekka Enberg , David Rientjes , Joonsoo Kim , vinmenon@codeaurora.org, Matthew Garrett , Jann Horn , Vijayanand Jitta , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] mm: Expand CONFIG_SLAB_FREELIST_HARDENED to include SLAB and SLOB Message-ID: <202006181330.2FDF47E03D@keescook> References: <20200617195349.3471794-1-keescook@chromium.org> <20200617195349.3471794-2-keescook@chromium.org> <20200617200151.GM8681@bombadil.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200617200151.GM8681@bombadil.infradead.org> X-Rspamd-Queue-Id: DE90A3B124A X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 17, 2020 at 01:01:51PM -0700, Matthew Wilcox wrote: > On Wed, Jun 17, 2020 at 12:53:48PM -0700, Kees Cook wrote: > > Include SLAB and SLOB caches when performing kmem_cache pointer > > ... SLOB? Really? Objects from different kmem caches are mixed together > on the same page with SLOB (at least last time I looked). So how does > this work? Hmm. I'm not sure. I can't even boot a SLOB kernel these days (even without these patches). But, pages are shared between kmem caches on SLOB, then I certainly can't add this check for it. :) I'll adjust this patch. -- Kees Cook