From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47378C433DF for ; Thu, 18 Jun 2020 20:39:02 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 06D4C208C3 for ; Thu, 18 Jun 2020 20:39:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="edEwuhbU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 06D4C208C3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 926B08D005F; Thu, 18 Jun 2020 16:39:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 907938D0052; Thu, 18 Jun 2020 16:39:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 83A8F8D005F; Thu, 18 Jun 2020 16:39:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0003.hostedemail.com [216.40.44.3]) by kanga.kvack.org (Postfix) with ESMTP id 69F818D0052 for ; Thu, 18 Jun 2020 16:39:01 -0400 (EDT) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 0E57D18033A51 for ; Thu, 18 Jun 2020 20:39:01 +0000 (UTC) X-FDA: 76943496882.24.fish04_15107e126e13 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin24.hostedemail.com (Postfix) with ESMTP id 116593B907D for ; Thu, 18 Jun 2020 20:38:23 +0000 (UTC) X-HE-Tag: fish04_15107e126e13 X-Filterd-Recvd-Size: 3085 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf48.hostedemail.com (Postfix) with ESMTP for ; Thu, 18 Jun 2020 20:38:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=5WocLv3zCm4O1IL+nMGo7H1sMvF1lavd5wB71baAHqM=; b=edEwuhbUl9Bbthw+xr8A7tYPh+ iFiUNDguLz/YjmmG+LxrKC2wOt7WUGeXH82zqJhA3xPZ+ByL3hT8Eqig5mwDDvrhPliiUqfD+SFas lIk+PItTBspVGlZyXp7AL5RkbrXPZZbJHQLq+YRXGoP+odN0HALXowb8u4xDZr+gIOAbr8Qa2hkG5 RlknbQiJ2Mxg/Tf0Ou4ID8vfHS2SFglVuO10sJpHftxgO4gbfFN8VBwsRAu//saUv1cyLVcyuLIWd Wv+kfnbZuQe4IbVg1GEA16uhoSjd75bMuVfOW18wM50dzZEEismISD9RPg3so/wfu1kMiA9GI+NQi /We2KN2w==; Received: from willy by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jm1Ij-0007OB-GB; Thu, 18 Jun 2020 20:38:21 +0000 Date: Thu, 18 Jun 2020 13:38:21 -0700 From: Matthew Wilcox To: Uladzislau Rezki Cc: "Paul E. McKenney" , LKML , linux-mm@kvack.org, Andrew Morton , "Theodore Y . Ts'o" , Joel Fernandes , RCU , Oleksiy Avramchenko Subject: Re: [PATCH v2 09/16] rcu/tree: Maintain separate array for vmalloc ptrs Message-ID: <20200618203821.GU8681@bombadil.infradead.org> References: <20200525214800.93072-1-urezki@gmail.com> <20200525214800.93072-10-urezki@gmail.com> <20200617234609.GA10087@paulmck-ThinkPad-P72> <20200618005214.GN8681@bombadil.infradead.org> <20200618031823.GQ2723@paulmck-ThinkPad-P72> <20200618173520.GC14613@pc636> <20200618175719.GT2723@paulmck-ThinkPad-P72> <20200618183448.GA15136@pc636> <20200618190359.GU2723@paulmck-ThinkPad-P72> <20200618203557.GB16976@pc636> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200618203557.GB16976@pc636> X-Rspamd-Queue-Id: 116593B907D X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jun 18, 2020 at 10:35:57PM +0200, Uladzislau Rezki wrote: > On Thu, Jun 18, 2020 at 12:03:59PM -0700, Paul E. McKenney wrote: > but i do not have a strong opinion here, even though i tend to > say that it would be odd. Having just vfree_bulk(), i think > would be enough, as a result the code will look like: > > > trace_rcu_invoke_kfree_bulk_callback( > rcu_state.name, bkvhead[i]->nr_records, > bkvhead[i]->records); > if (i == 0) > kfree_bulk(bkvhead[i]->nr_records, > bkvhead[i]->records); > else > vfree_bulk(bkvhead[i]->nr_records, > bkvhead[i]->records); > > > Matthew, what is your thought? That was my thinking too. If we had a kvfree_bulk(), I would expect it to handle a mixture of vfree and kfree, but you've segregated them already. So I think this is better.