From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8ECA9C433E0 for ; Thu, 18 Jun 2020 21:03:03 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2BCE020CC7 for ; Thu, 18 Jun 2020 21:03:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="U5dQL8ZC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2BCE020CC7 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B19CD8D0061; Thu, 18 Jun 2020 17:03:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AC9668D0052; Thu, 18 Jun 2020 17:03:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9B7DB8D0061; Thu, 18 Jun 2020 17:03:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0023.hostedemail.com [216.40.44.23]) by kanga.kvack.org (Postfix) with ESMTP id 7D2528D0052 for ; Thu, 18 Jun 2020 17:03:01 -0400 (EDT) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id C7A9C8033AC4 for ; Thu, 18 Jun 2020 21:03:00 +0000 (UTC) X-FDA: 76943557320.05.food57_0e0ae4126e13 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin05.hostedemail.com (Postfix) with ESMTP id 1A4811837AE56 for ; Thu, 18 Jun 2020 21:02:54 +0000 (UTC) X-HE-Tag: food57_0e0ae4126e13 X-Filterd-Recvd-Size: 3653 Received: from mail-il1-f174.google.com (mail-il1-f174.google.com [209.85.166.174]) by imf18.hostedemail.com (Postfix) with ESMTP for ; Thu, 18 Jun 2020 21:02:54 +0000 (UTC) Received: by mail-il1-f174.google.com with SMTP id e11so7337160ilr.4 for ; Thu, 18 Jun 2020 14:02:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=QjS3LcfNixF46hdH+DYqJmMMxjwmVhC16phWf6wjxZg=; b=U5dQL8ZCrj7dvpZ0uNFcw99bxuYBA7FvjAgMrt12kycySqw+02+eBdUzFZ2PybD0gk h/Dz/HSxKgZSu9LFJwR8hmQhHvqPbZ3LORP1MyeAmU+RRzjHQn7Q+tXJ75vkj8+e/MLj bLpcgO1rrPlXPZ1PIFK3FvczIGJKB7xN5JtkV15rY0MhE/8OD9XfbQJjoa0kZLRScMl+ KLnF+RxEzMyvfwrVh4EB0MIGEA9i2P4/RbsxpRqGBlMg2oFlVPuWJv142cneKo3qCLbX V8aJ5qzzgV4t4iOFqxK5JOFXQNnLMSx4Cd7OlvKlZkACL8x8j6dhFJ/cClERlTNgWasp 38hA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=QjS3LcfNixF46hdH+DYqJmMMxjwmVhC16phWf6wjxZg=; b=gj2Q0HZdHlxrg+XeomMgO9FCFxZf9RGD/bt8GqlYsVSEq6ifQlHId/31A4e9jM/YE5 pED8oR2G72MP6OWFQjQQ8KTM69oGXTjd1Ti8tf6R1kKIlOFABzWivDSbHUnICCN1EYzn 7QRd/d+HfQVddE7bOF4E2P2T4MItqkTphme1l1xrw9gfNuAP5GcFavuEx66QwCiPhzX2 eBW96oCVoKYzxLd1IULbrq2SCCBi1iGo/AYErmxcgEmHtRtqwyfT80tyFi7ELsuFdanA jg5zWMWsZAj1htp7RWZ/TZ4MsfwMRcgY1hiWaqZsFzH5jadWVArz7uURc/fvIy+g0L6I 7/mQ== X-Gm-Message-State: AOAM533vMuZB4FIUki4E2n/l8Goawd6RIi2q902IkBRNzhx3BeTH2IxW UK2lOUN5ddp9qenJZAw8/A9CSA== X-Google-Smtp-Source: ABdhPJzAwMUSWpuFj3zhwh8eBA4stERkBC3lgM2jpRMxaPbfz3wzGJofZI2PtMh8qjGU8YU68CbWFA== X-Received: by 2002:a92:d1d0:: with SMTP id u16mr390427ilg.7.1592514173633; Thu, 18 Jun 2020 14:02:53 -0700 (PDT) Received: from google.com ([2620:15c:183:0:209:9736:c663:27c3]) by smtp.gmail.com with ESMTPSA id z4sm2042127ilm.72.2020.06.18.14.02.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Jun 2020 14:02:52 -0700 (PDT) Date: Thu, 18 Jun 2020 15:02:48 -0600 From: Yu Zhao To: Christopher Lameter , Sebastian Andrzej Siewior Cc: linux-mm@kvack.org, Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Thomas Gleixner Subject: Re: [RFC] SLUB: list_slab_objects() looks like a miss-merge Message-ID: <20200618210248.GA86479@google.com> References: <20200618094623.ef7wrsyrnrsfm7as@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 1A4811837AE56 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam03 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jun 18, 2020 at 03:03:25PM +0000, Christopher Lameter wrote: > On Thu, 18 Jun 2020, Sebastian Andrzej Siewior wrote: > > > Is this a miss-merge of some kind? I would revert commit > > aa456c7aebb14 ("slub: remove kmalloc under list_lock from list_slab_objects() V2") > > Seems that two fixes to the same problem were merged? Sorry, I assumed the previous fix had been dropped when this one was taken. I'm fine with reverting the previous fix if this one is deemed more appropriate.