From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3832FC433DF for ; Fri, 19 Jun 2020 13:47:19 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C7AC4208C7 for ; Fri, 19 Jun 2020 13:47:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PmUHQxdS" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C7AC4208C7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 116898D009E; Fri, 19 Jun 2020 09:47:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0EDAD6B00AF; Fri, 19 Jun 2020 09:47:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F1DA08D009E; Fri, 19 Jun 2020 09:47:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0156.hostedemail.com [216.40.44.156]) by kanga.kvack.org (Postfix) with ESMTP id DAF6A6B00AE for ; Fri, 19 Jun 2020 09:47:17 -0400 (EDT) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 707338248068 for ; Fri, 19 Jun 2020 13:47:17 +0000 (UTC) X-FDA: 76946088114.09.unit40_4a05f3526e19 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin09.hostedemail.com (Postfix) with ESMTP id 4F0A3180AD806 for ; Fri, 19 Jun 2020 13:47:17 +0000 (UTC) X-HE-Tag: unit40_4a05f3526e19 X-Filterd-Recvd-Size: 7359 Received: from mail-ed1-f66.google.com (mail-ed1-f66.google.com [209.85.208.66]) by imf32.hostedemail.com (Postfix) with ESMTP for ; Fri, 19 Jun 2020 13:47:16 +0000 (UTC) Received: by mail-ed1-f66.google.com with SMTP id y6so7668147edi.3 for ; Fri, 19 Jun 2020 06:47:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:reply-to:references:mime-version :content-disposition:in-reply-to:user-agent; bh=JBVkaRaZWirU7e3k0xkGSUsqcHn/FjRRebjp9wA0kB8=; b=PmUHQxdSVYbxZQbONx6B+oZ8nBWdOmiTadNXvPbf+fTPZOAkpbSDfCM9sjeZVZXvP3 Y9+uHvXg0JAI17x3lFfRaHVAXnv/GKBoFuxDetSL9lhvxueuY6ibQB+SDxiUfM5lyBHo /3ZRVcLHMl2YTDBHw81i3xQLV6wrlGT2yVJZcCz4iMY2T3r7YkX13jkj62NvakjyJO8R Mbru/lhwmz9Sjp7ATaJTPVejdfXGrhrUx4EO9fVFzNJgXI4/892LkgER1CMK4rkkJG66 y9odYkltbdM4Ue2eQmAfxcUQiZN+D9YKew2Lp3Rq6G06WqJ0IcYyXwjuA7ARvkd3QjVg OaFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:reply-to :references:mime-version:content-disposition:in-reply-to:user-agent; bh=JBVkaRaZWirU7e3k0xkGSUsqcHn/FjRRebjp9wA0kB8=; b=OeUnEkCI3+vLpJdxgrBWqm8K5rhZuRCnSuejlXseHMMFEcIQFMpLlEBTauY17+DL2b QdxALSXRZh1BwLX5gvlKQhQC4JU5tEfZmw3K/kWN/hHrhBly5yYxoxTOb+iGuYuGn+Fw QdxZs226hzNSTul+9op6xdw7zdP3ai6RJYB/YbZeoqUR4xI9qJmfJjYVOwA/2JobkdOD TFr1h0d58ztNws4KL127bPGxVNuRAi1KLLekujzaRNsHGq6fVkihPFfyJBo8UahFzjOG W1WJQZfE78VG/1ip/VC1WhzbOJAqEnMQoLJnZGSErQuylWRU6XnTbdaRJj+4lYBpUjmi YOzA== X-Gm-Message-State: AOAM531YOsNp08oI7roVrZJmCYM/ngzHsZMDhYar1BOCloCvQ1k7smkL SVIcMNLOeoll4vBy5pk9uXc= X-Google-Smtp-Source: ABdhPJxsewLRbfv6IzL/Ko1MBXdF0ua15skXMbkoq9vo1+oTuZhfm0tFLfvjflzO1HjqtGHiD7Ukrw== X-Received: by 2002:a05:6402:b5c:: with SMTP id bx28mr3426773edb.145.1592574435622; Fri, 19 Jun 2020 06:47:15 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id o90sm4679511edb.60.2020.06.19.06.47.14 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 19 Jun 2020 06:47:14 -0700 (PDT) Date: Fri, 19 Jun 2020 13:47:14 +0000 From: Wei Yang To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Johannes Weiner , Michal Hocko , Huang Ying , Minchan Kim , Wei Yang Subject: Re: [PATCH v1 1/2] mm: drop vm_total_pages Message-ID: <20200619134714.yaxol5ckemhffgqm@master> Reply-To: Wei Yang References: <20200619132410.23859-1-david@redhat.com> <20200619132410.23859-2-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200619132410.23859-2-david@redhat.com> User-Agent: NeoMutt/20170113 (1.7.2) X-Rspamd-Queue-Id: 4F0A3180AD806 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam03 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jun 19, 2020 at 03:24:09PM +0200, David Hildenbrand wrote: >The global variable "vm_total_pages" is a relict from older days. There >is only a single user that reads the variable - build_all_zonelists() - >and the first thing it does is updating it. Use a local variable in >build_all_zonelists() instead and drop the local variable. > >Cc: Andrew Morton >Cc: Johannes Weiner >Cc: Michal Hocko >Cc: Huang Ying >Cc: Minchan Kim >Cc: Wei Yang >Signed-off-by: David Hildenbrand Reviewed-by: Wei Yang >--- > include/linux/swap.h | 1 - > mm/memory_hotplug.c | 3 --- > mm/page-writeback.c | 6 ++---- > mm/page_alloc.c | 2 ++ > mm/vmscan.c | 5 ----- > 5 files changed, 4 insertions(+), 13 deletions(-) > >diff --git a/include/linux/swap.h b/include/linux/swap.h >index 4c5974bb9ba94..124261acd5d0a 100644 >--- a/include/linux/swap.h >+++ b/include/linux/swap.h >@@ -371,7 +371,6 @@ extern unsigned long mem_cgroup_shrink_node(struct mem_cgroup *mem, > extern unsigned long shrink_all_memory(unsigned long nr_pages); > extern int vm_swappiness; > extern int remove_mapping(struct address_space *mapping, struct page *page); >-extern unsigned long vm_total_pages; > > extern unsigned long reclaim_pages(struct list_head *page_list); > #ifdef CONFIG_NUMA >diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c >index 9b34e03e730a4..d682781cce48d 100644 >--- a/mm/memory_hotplug.c >+++ b/mm/memory_hotplug.c >@@ -835,8 +835,6 @@ int __ref online_pages(unsigned long pfn, unsigned long nr_pages, > kswapd_run(nid); > kcompactd_run(nid); > >- vm_total_pages = nr_free_pagecache_pages(); >- > writeback_set_ratelimit(); > > memory_notify(MEM_ONLINE, &arg); >@@ -1586,7 +1584,6 @@ static int __ref __offline_pages(unsigned long start_pfn, > kcompactd_stop(node); > } > >- vm_total_pages = nr_free_pagecache_pages(); > writeback_set_ratelimit(); > > memory_notify(MEM_OFFLINE, &arg); >diff --git a/mm/page-writeback.c b/mm/page-writeback.c >index 28b3e7a675657..4e4ddd67b71e5 100644 >--- a/mm/page-writeback.c >+++ b/mm/page-writeback.c >@@ -2076,13 +2076,11 @@ static int page_writeback_cpu_online(unsigned int cpu) > * Called early on to tune the page writeback dirty limits. > * > * We used to scale dirty pages according to how total memory >- * related to pages that could be allocated for buffers (by >- * comparing nr_free_buffer_pages() to vm_total_pages. >+ * related to pages that could be allocated for buffers. > * > * However, that was when we used "dirty_ratio" to scale with > * all memory, and we don't do that any more. "dirty_ratio" >- * is now applied to total non-HIGHPAGE memory (by subtracting >- * totalhigh_pages from vm_total_pages), and as such we can't >+ * is now applied to total non-HIGHPAGE memory, and as such we can't > * get into the old insane situation any more where we had > * large amounts of dirty pages compared to a small amount of > * non-HIGHMEM memory. >diff --git a/mm/page_alloc.c b/mm/page_alloc.c >index 0c435b2ed665c..7b0dde69748c1 100644 >--- a/mm/page_alloc.c >+++ b/mm/page_alloc.c >@@ -5903,6 +5903,8 @@ build_all_zonelists_init(void) > */ > void __ref build_all_zonelists(pg_data_t *pgdat) > { >+ unsigned long vm_total_pages; >+ > if (system_state == SYSTEM_BOOTING) { > build_all_zonelists_init(); > } else { >diff --git a/mm/vmscan.c b/mm/vmscan.c >index b6d84326bdf2d..0010859747df2 100644 >--- a/mm/vmscan.c >+++ b/mm/vmscan.c >@@ -170,11 +170,6 @@ struct scan_control { > * From 0 .. 200. Higher means more swappy. > */ > int vm_swappiness = 60; >-/* >- * The total number of pages which are beyond the high watermark within all >- * zones. >- */ >-unsigned long vm_total_pages; > > static void set_task_reclaim_state(struct task_struct *task, > struct reclaim_state *rs) >-- >2.26.2 -- Wei Yang Help you, Help me