From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B18CC433DF for ; Fri, 19 Jun 2020 15:46:59 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C1CFA21532 for ; Fri, 19 Jun 2020 15:46:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jo6wL5xA" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C1CFA21532 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6181B8D00B0; Fri, 19 Jun 2020 11:46:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5C8C08D00AD; Fri, 19 Jun 2020 11:46:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4B82B8D00B0; Fri, 19 Jun 2020 11:46:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0144.hostedemail.com [216.40.44.144]) by kanga.kvack.org (Postfix) with ESMTP id 309698D00AD for ; Fri, 19 Jun 2020 11:46:58 -0400 (EDT) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 8FD0274BDE for ; Fri, 19 Jun 2020 15:46:57 +0000 (UTC) X-FDA: 76946389674.13.cork49_4e0b87426e1a Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin13.hostedemail.com (Postfix) with ESMTP id 66B19181411C1 for ; Fri, 19 Jun 2020 15:46:57 +0000 (UTC) X-HE-Tag: cork49_4e0b87426e1a X-Filterd-Recvd-Size: 4781 Received: from mail-lj1-f195.google.com (mail-lj1-f195.google.com [209.85.208.195]) by imf34.hostedemail.com (Postfix) with ESMTP for ; Fri, 19 Jun 2020 15:46:56 +0000 (UTC) Received: by mail-lj1-f195.google.com with SMTP id c17so11993177lji.11 for ; Fri, 19 Jun 2020 08:46:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=2aeO2u4RtaCPo8nCEgw4qCFKUHWK0LPFLeoI2aW5HPQ=; b=jo6wL5xA6o2oH5Qfa/Iq4GtVdDCLwHsr8D1YOa8ko3zROJAiMn/5bGOz6il/WVub71 sgkOp5yYot9p6XVr6ItkoFtBdxyEetxbA3qJ1aBlqE2UyowCwErx9g0KfuWMbY02+zCX aM+An3sSPzlrRJKkObwEk0GKPbwYYeV7uPOaOrHOU1v72UV0PV1J2xb1Xtsf0Foiurn9 s2mqi/EQ+kM1jYqerwtJhJjsCnpn8C5AZSkHmrKrILzE4485907xY8fZdWSZSHer0v2e SdSy4vj6XHFIPnVV0DS9bk7+A//zYOx/0mWh5yCkAjb3CrfOopT/l/KkiUuTU+ywyy4q PODQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=2aeO2u4RtaCPo8nCEgw4qCFKUHWK0LPFLeoI2aW5HPQ=; b=NyNP9h2Ws8mC1pZWgWGkOb1dT2pWZxjU6Ydg3dKQzbw0t7njkwN4NkflJDnPsFwUQZ mJ3kjQ/JHEnU0YLRXDrJ7ETVn5b28RBpN+EpaKnR5DJE2rP9vgs11UzKx8YMwnIwhXUf d4URwRKQ6Cmt1O/kF0ixk2T9+t/TRWGUJa1TKGr1u6WpCMtWIxRSGBIDGEdN50Lz8rlc X+HbolpavM/ZhOqTe3H9HpK1J+vtL2WmN9Hk5Vor5EONEaWu7HeAa32dczNW6Un4w4LH yzeurdWznc4BdpXmNNAvykHAfFCf4FXskwYw4Z9wKYISyLmWZzl332sQbM2970aXTbaQ DwzA== X-Gm-Message-State: AOAM532TGPXDfhtBKUMXgb2j6sR4PRGQmlDHMV2CBZd8MyU3iPJBXTw6 gKCkA8lZynxcwnDCEssFdTg= X-Google-Smtp-Source: ABdhPJwUhOSSv9Ni5UNYPTcQgeNwmvJEp3WKGXZARh2sfgnjRmYeeL7JRfK5VaDXWSsF2HWXIUVk1w== X-Received: by 2002:a2e:9a55:: with SMTP id k21mr2282446ljj.340.1592581615594; Fri, 19 Jun 2020 08:46:55 -0700 (PDT) Received: from pc636 (h5ef52e31.seluork.dyn.perspektivbredband.net. [94.245.46.49]) by smtp.gmail.com with ESMTPSA id f24sm1222442ljk.125.2020.06.19.08.46.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Jun 2020 08:46:54 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Fri, 19 Jun 2020 17:46:52 +0200 To: "Paul E. McKenney" Cc: Uladzislau Rezki , Matthew Wilcox , LKML , linux-mm@kvack.org, Andrew Morton , "Theodore Y . Ts'o" , Joel Fernandes , RCU , Oleksiy Avramchenko Subject: Re: [PATCH v2 09/16] rcu/tree: Maintain separate array for vmalloc ptrs Message-ID: <20200619154652.GA19990@pc636> References: <20200618005214.GN8681@bombadil.infradead.org> <20200618031823.GQ2723@paulmck-ThinkPad-P72> <20200618173520.GC14613@pc636> <20200618175719.GT2723@paulmck-ThinkPad-P72> <20200618183448.GA15136@pc636> <20200618190359.GU2723@paulmck-ThinkPad-P72> <20200618203557.GB16976@pc636> <20200618203821.GU8681@bombadil.infradead.org> <20200618211709.GA17263@pc636> <20200618213427.GV2723@paulmck-ThinkPad-P72> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200618213427.GV2723@paulmck-ThinkPad-P72> User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspamd-Queue-Id: 66B19181411C1 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jun 18, 2020 at 02:34:27PM -0700, Paul E. McKenney wrote: > On Thu, Jun 18, 2020 at 11:17:09PM +0200, Uladzislau Rezki wrote: > > > > > > > > trace_rcu_invoke_kfree_bulk_callback( > > > > rcu_state.name, bkvhead[i]->nr_records, > > > > bkvhead[i]->records); > > > > if (i == 0) > > > > kfree_bulk(bkvhead[i]->nr_records, > > > > bkvhead[i]->records); > > > > else > > > > vfree_bulk(bkvhead[i]->nr_records, > > > > bkvhead[i]->records); > > > > > > > > > > > > Matthew, what is your thought? > > > > > > That was my thinking too. If we had a kvfree_bulk(), I would expect it to > > > handle a mixture of vfree and kfree, but you've segregated them already. > > > So I think this is better. > > > > > Yes, the segregation is done. Having vfree_bulk() is enough then. > > We are on the same page :) > > Very good. When does kfree_rcu() and friends move out of kernel/rcu? > Do you mean to move the whole logic of kfree_rcu() from top to down to mm/? Thanks! -- Vlad Rezki