From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9D94C433E0 for ; Fri, 19 Jun 2020 19:27:34 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7F2B221548 for ; Fri, 19 Jun 2020 19:27:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="iPITOYSn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7F2B221548 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 06E9A6B00D5; Fri, 19 Jun 2020 15:27:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 01F746B00D6; Fri, 19 Jun 2020 15:27:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E76B86B00D7; Fri, 19 Jun 2020 15:27:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0175.hostedemail.com [216.40.44.175]) by kanga.kvack.org (Postfix) with ESMTP id CCF656B00D5 for ; Fri, 19 Jun 2020 15:27:33 -0400 (EDT) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 7F39C181ACC80 for ; Fri, 19 Jun 2020 19:27:33 +0000 (UTC) X-FDA: 76946945586.11.nose77_560dead26e1b Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin11.hostedemail.com (Postfix) with ESMTP id 59CBF180F8B80 for ; Fri, 19 Jun 2020 19:27:33 +0000 (UTC) X-HE-Tag: nose77_560dead26e1b X-Filterd-Recvd-Size: 4202 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf28.hostedemail.com (Postfix) with ESMTP for ; Fri, 19 Jun 2020 19:27:32 +0000 (UTC) Received: from quaco.ghostprotocols.net (unknown [179.97.37.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C02FD21531; Fri, 19 Jun 2020 19:27:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592594852; bh=rXkm2yZFs8wKNU/+Cn6r1srxIA98fiRUp/CywARoGo4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=iPITOYSnR+qcpPVoMeBIx4vf1JMjRJjq+3vD6az1YTTlV5W5zzvHfjkTqndezCOOF 2dcwSPCk5E128kkAgjGKshlX3geLNdS9/fvHI3g8gkpF1rvPDlhY+9FNGKDaLQMsh0 DeGXEznxg9tVzygsMT9OBAYG41pinu0jBVSpnluQ= Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id D7352405FF; Fri, 19 Jun 2020 16:27:29 -0300 (-03) Date: Fri, 19 Jun 2020 16:27:29 -0300 From: Arnaldo Carvalho de Melo To: Heiko Carstens Cc: Xiaoming Ni , alexander.shishkin@linux.intel.com, arnd@arndb.de, borntraeger@de.ibm.com, catalin.marinas@arm.com, christian@brauner.io, cyphar@cyphar.com, dhowells@redhat.com, ebiederm@xmission.com, fenghua.yu@intel.com, geert@linux-m68k.org, gor@linux.ibm.com, ink@jurassic.park.msu.ru, jolsa@redhat.com, linux@armlinux.org.uk, lkp@intel.com, mark.rutland@arm.com, mattst88@gmail.com, minchan@kernel.org, mingo@redhat.com, monstr@monstr.eu, namhyung@kernel.org, peterz@infradead.org, rth@twiddle.net, sargun@sargun.me, sfr@canb.auug.org.au, tony.luck@intel.com, will@kernel.org, akpm@linux-foundation.org, alex.huangjianhui@huawei.com, zhongjubin@huawei.com, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, clang-built-linux@googlegroups.com, kbuild-all@lists.01.org, linux-mm@kvack.org Subject: Re: [PATCH v2] s390: fix build error for sys_call_table_emu Message-ID: <20200619192729.GA29309@kernel.org> References: <20200618141426.16884-1-nixiaoming@huawei.com> <20200619141717.GB9971@osiris> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200619141717.GB9971@osiris> X-Url: http://acmel.wordpress.com X-Rspamd-Queue-Id: 59CBF180F8B80 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam04 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Em Fri, Jun 19, 2020 at 04:17:17PM +0200, Heiko Carstens escreveu: > On Thu, Jun 18, 2020 at 10:14:26PM +0800, Xiaoming Ni wrote: > > Build error on s390: > > arch/s390/kernel/entry.o: in function `sys_call_table_emu': > > >> (.rodata+0x1288): undefined reference to `__s390_' > > > > In commit ("All arch: remove system call sys_sysctl") > > 148 common fdatasync sys_fdatasync sys_fdatasync > > -149 common _sysctl sys_sysctl compat_sys_sysctl > > +149 common _sysctl sys_ni_syscall > > 150 common mlock sys_mlock sys_mlock > > > > After the patch is integrated, there is a format error in the generated > > arch/s390/include/generated/asm/syscall_table.h: > > SYSCALL(sys_fdatasync, sys_fdatasync) > > SYSCALL(sys_ni_syscall,) /* cause build error */ > > SYSCALL(sys_mlock,sys_mlock) > > > > According to the guidance of Heiko Carstens, use "-" to fill the empty system call > > Similarly, modify tools/perf/arch/s390/entry/syscalls/syscall.tbl. > > > > Fixes: ("All arch: remove system call sys_sysctl") > > Fixes: https://lore.kernel.org/linuxppc-dev/20200616030734.87257-1-nixiaoming@huawei.com/ > > Reported-by: kernel test robot > > Signed-off-by: Xiaoming Ni > > > > changes in v2: > > use "-" to fill the empty system call > > > > v1: https://lore.kernel.org/lkml/20200618110320.104013-1-nixiaoming@huawei.com/ > > --- > > arch/s390/kernel/syscalls/syscall.tbl | 2 +- > > tools/perf/arch/s390/entry/syscalls/syscall.tbl | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > Acked-by: Heiko Carstens I get just copies of that file when it gets out of sync, so I suppose the patch should be just for arch/s390/kernel/syscalls/syscall.tbl and processed by the s/390 maintainer? - Arnaldo