From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 945FFC433DF for ; Fri, 19 Jun 2020 20:23:54 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5B08E20890 for ; Fri, 19 Jun 2020 20:23:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5B08E20890 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A6B7F8D00F9; Fri, 19 Jun 2020 16:23:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A1BFD8D00E9; Fri, 19 Jun 2020 16:23:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8E5278D00F9; Fri, 19 Jun 2020 16:23:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0005.hostedemail.com [216.40.44.5]) by kanga.kvack.org (Postfix) with ESMTP id 72A948D00E9 for ; Fri, 19 Jun 2020 16:23:53 -0400 (EDT) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 18782181AC9C6 for ; Fri, 19 Jun 2020 20:23:53 +0000 (UTC) X-FDA: 76947087546.21.hate59_5a0b14126e1b Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin21.hostedemail.com (Postfix) with ESMTP id E7731180442C3 for ; Fri, 19 Jun 2020 20:23:52 +0000 (UTC) X-HE-Tag: hate59_5a0b14126e1b X-Filterd-Recvd-Size: 3455 Received: from mail-pl1-f193.google.com (mail-pl1-f193.google.com [209.85.214.193]) by imf26.hostedemail.com (Postfix) with ESMTP for ; Fri, 19 Jun 2020 20:23:52 +0000 (UTC) Received: by mail-pl1-f193.google.com with SMTP id d8so4343632plo.12 for ; Fri, 19 Jun 2020 13:23:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=RNk3YYxZgiMdt5E1Q+HAeQPHMt5QiUV6QIFeXf5YA6E=; b=eYICQN3v5yT0Kwqw1ABPgxYlWQbJThGjNOzJFpRZNQd3tmlJC0skEE2UQfgRRPwC/G /Ocm/ZI5ZMiX13zhfv/wOfzZ1H14yki76//vxqXaBs4SaxQUMSqzrWUH3XkoHIDAr077 /EZi9dGyXivLrKDFCFjt4SeOTFs1yLR3TS7AwZ7DdQbdyJ+YNkWC7nRpmf0oWsK1eF6v Lt6N/HsKlHDlomVC3uA/slKjZUi61m5n2Um+QsJvBVBsNQzBTPcZa7lbQuWIPE9sna42 AtRdeX78Cc4qCx2p7FApLGWvb0qBlO/0K1OK5c+Yv4SaXdtsV94wpmsrk9zTdLOP1t6/ 50Ag== X-Gm-Message-State: AOAM5331yy/47K9JC18C6qJ0dyIDiRjfMfN2YRjcAiO4WV2EX8uVAKZZ 7I37B+baLE1HJodo9ZdZtGg= X-Google-Smtp-Source: ABdhPJwyTucVAhYVByutNy/3iB7HUovNaBJeVj/WU7TGkfz1k4YvkICw6ZEx8Vi19BK0QPdR+PbQWw== X-Received: by 2002:a17:902:e989:: with SMTP id f9mr10040039plb.268.1592598231563; Fri, 19 Jun 2020 13:23:51 -0700 (PDT) Received: from 42.do-not-panic.com (42.do-not-panic.com. [157.230.128.187]) by smtp.gmail.com with ESMTPSA id b1sm6738696pfr.89.2020.06.19.13.23.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Jun 2020 13:23:49 -0700 (PDT) Received: by 42.do-not-panic.com (Postfix, from userid 1000) id 9DED34063E; Fri, 19 Jun 2020 20:23:48 +0000 (UTC) Date: Fri, 19 Jun 2020 20:23:48 +0000 From: Luis Chamberlain To: Bart Van Assche Cc: axboe@kernel.dk, viro@zeniv.linux.org.uk, gregkh@linuxfoundation.org, rostedt@goodmis.org, mingo@redhat.com, jack@suse.cz, ming.lei@redhat.com, nstange@suse.de, akpm@linux-foundation.org, mhocko@suse.com, yukuai3@huawei.com, martin.petersen@oracle.com, jejb@linux.ibm.com, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Omar Sandoval , Hannes Reinecke , Michal Hocko , Christoph Hellwig Subject: Re: [PATCH v6 3/6] block: revert back to synchronous request_queue removal Message-ID: <20200619202348.GJ11244@42.do-not-panic.com> References: <20200608170127.20419-1-mcgrof@kernel.org> <20200608170127.20419-4-mcgrof@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspamd-Queue-Id: E7731180442C3 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam04 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jun 12, 2020 at 06:53:40PM -0700, Bart Van Assche wrote: > On 2020-06-08 10:01, Luis Chamberlain wrote: > > + * Drivers exist which depend on the release of the request_queue to be > > + * synchronous, it should not be deferred. > > This sounds mysterious. Which drivers? Why do these depend on this > function being synchronous? Sorry that should be "Userspace can exist". I've fixed that. > Anyway: > > Reviewed-by: Bart Van Assche Luis