From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2C5DC433E1 for ; Sat, 20 Jun 2020 22:50:06 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7BAAD23F28 for ; Sat, 20 Jun 2020 22:50:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="fSXzxzEJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7BAAD23F28 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id DE3E36B0098; Sat, 20 Jun 2020 18:50:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D95886B009A; Sat, 20 Jun 2020 18:50:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CAB626B00AC; Sat, 20 Jun 2020 18:50:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0124.hostedemail.com [216.40.44.124]) by kanga.kvack.org (Postfix) with ESMTP id B55D86B0098 for ; Sat, 20 Jun 2020 18:50:05 -0400 (EDT) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 640D31EE6 for ; Sat, 20 Jun 2020 22:50:05 +0000 (UTC) X-FDA: 76951084770.16.flag24_2202c3526e25 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin16.hostedemail.com (Postfix) with ESMTP id 3C62A100E6903 for ; Sat, 20 Jun 2020 22:50:05 +0000 (UTC) X-HE-Tag: flag24_2202c3526e25 X-Filterd-Recvd-Size: 2124 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf45.hostedemail.com (Postfix) with ESMTP for ; Sat, 20 Jun 2020 22:50:04 +0000 (UTC) Received: from X1 (nat-ab2241.sltdut.senawave.net [162.218.216.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8F6E824733; Sat, 20 Jun 2020 22:50:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592693403; bh=OSard3bu9eS3++LH0j4ZVd6z2ffYcvqxtIa3zeFGYpo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=fSXzxzEJG8Ha90DRN26xtroZknh+hk10BpFT8PRjIC+3S6vPXZu7yhvC0CsVhPWnG QxYwIBKRyRJFfgw9nJNNFE33Cq8UJRiA+OfAWSb7AgaK8bEwlze5x4vmXzgOnohnfz qglC0pZ9XVGrUw95zvMXn51j+Cd630FktWRjyPBc= Date: Sat, 20 Jun 2020 15:50:01 -0700 From: Andrew Morton To: Roman Gushchin Cc: Shakeel Butt , Christoph Lameter , Johannes Weiner , Michal Hocko , Linux MM , Vlastimil Babka , Kernel Team , LKML Subject: Re: [PATCH v6 06/19] mm: memcg/slab: obj_cgroup API Message-Id: <20200620155001.49de01dc8d84379d4557f113@linux-foundation.org> In-Reply-To: <20200619213810.GA237539@carbon.dhcp.thefacebook.com> References: <20200608230654.828134-1-guro@fb.com> <20200608230654.828134-7-guro@fb.com> <20200619213810.GA237539@carbon.dhcp.thefacebook.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 3C62A100E6903 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 19 Jun 2020 14:38:10 -0700 Roman Gushchin wrote: > Andrew, can you, please, squash the following fix based on Shakeel's suggestions? > Thanks! Sure. But a changelog, a signoff and an avoidance of tabs-replaced-by-spaces would still be preferred, please!