From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90DE7C433E0 for ; Sat, 20 Jun 2020 16:08:34 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4C21A23D6A for ; Sat, 20 Jun 2020 16:08:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="HRVCcChd" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4C21A23D6A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A0EEA8D000B; Sat, 20 Jun 2020 12:08:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9BF0E8D0008; Sat, 20 Jun 2020 12:08:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8AD778D000B; Sat, 20 Jun 2020 12:08:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0109.hostedemail.com [216.40.44.109]) by kanga.kvack.org (Postfix) with ESMTP id 741918D0008 for ; Sat, 20 Jun 2020 12:08:33 -0400 (EDT) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 0D14F180AD820 for ; Sat, 20 Jun 2020 16:08:33 +0000 (UTC) X-FDA: 76950072906.21.time27_580401326e22 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin21.hostedemail.com (Postfix) with ESMTP id E0E8D180442C3 for ; Sat, 20 Jun 2020 16:08:32 +0000 (UTC) X-HE-Tag: time27_580401326e22 X-Filterd-Recvd-Size: 5368 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by imf06.hostedemail.com (Postfix) with ESMTP for ; Sat, 20 Jun 2020 16:08:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1592669311; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uAGWGHZX+NRKxPhaQCrHlyIVKqgbsc6xDoomuBD05Hw=; b=HRVCcChduwqCMPn//fe8n8VzggZ0W8IgYjdkVScXl3X1/W5nqiDc2IYGPRsJzUt0dN0GAw mE/AGExA5yWkg2xaJ/YH/1ghph1VlWZ8c5qLrUaj9rDAtugTa4BCyaeURbKFpjLnxuE4bj x0HgIQiNrfcA7KYozxCtUwkHWpBNK9A= Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-322-ZNJccwTPOpmIhJLRwOEN9g-1; Sat, 20 Jun 2020 12:08:29 -0400 X-MC-Unique: ZNJccwTPOpmIhJLRwOEN9g-1 Received: by mail-qt1-f200.google.com with SMTP id y25so9554925qtb.6 for ; Sat, 20 Jun 2020 09:08:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=uAGWGHZX+NRKxPhaQCrHlyIVKqgbsc6xDoomuBD05Hw=; b=KxzDYje6mo/zV7FO5633cUlZhS9c2f1X5RG7s+PuYmVaV13/5U6SyWmvZpl42vUHtM fiFdGtBRJA23oWrh9kyodLuMBtphFLwH5ZeqfBK3Eqa4nYVNIEe5uACjIGkS2JoxdXe8 D4pfjMktjHFqFOgXOcOdGb6lSk1Q50N/yTHJ3AK6T9elRdbj+J+9M4GWjWNRhHFCeCA9 U2t1Wpt2P/nY5/lyj2PwXt0u/F8w6jfqPrAPS9xqW5pbx1t3Tt7CBs1tViXLZRyAgmEb Wn9rjoHW3kcbbnRq+e+s+H5y7E/dqsCgjoUCc+jnGnj9u9Y7sx/Su0bz96CMdHskgO8N sjLw== X-Gm-Message-State: AOAM531P5W+WhgUG6LqW28Aw406F+RFSVtcR2GjK2KRltKA4DFWlorjw 2fIAtwPsyqP+flmwZ6e5vz7XXMtov5QURjhkPWfdYy0otfyuSdy1DvoUgDSFYvcFGDNh02jgFdc TuwcPTd9CbmA= X-Received: by 2002:ac8:2af4:: with SMTP id c49mr7855102qta.42.1592669308735; Sat, 20 Jun 2020 09:08:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzhW6m+v5NAydxoWwY4YCydn/fcpsNSqMLAgkBrIBmXw9vSkjNqmzWLGoF9/VukK2HQYENUBg== X-Received: by 2002:ac8:2af4:: with SMTP id c49mr7855067qta.42.1592669308443; Sat, 20 Jun 2020 09:08:28 -0700 (PDT) Received: from xz-x1 ([2607:9880:19c0:32::2]) by smtp.gmail.com with ESMTPSA id 195sm9432761qkg.74.2020.06.20.09.08.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 20 Jun 2020 09:08:27 -0700 (PDT) Date: Sat, 20 Jun 2020 12:08:25 -0400 From: Peter Xu To: Guo Ren Cc: Linux Kernel Mailing List , linux-mm@kvack.org, Gerald Schaefer , Andrew Morton , Andrea Arcangeli , Will Deacon , Michael Ellerman , Linus Torvalds , linux-csky@vger.kernel.org Subject: Re: [PATCH 06/26] mm/csky: Use general page fault accounting Message-ID: <20200620160825.GC6414@xz-x1> References: <20200619160538.8641-1-peterx@redhat.com> <20200619160538.8641-7-peterx@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Queue-Id: E0E8D180442C3 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Jun 20, 2020 at 09:44:31AM +0800, Guo Ren wrote: > On Sat, Jun 20, 2020 at 12:05 AM Peter Xu wrote: > > > > Use the general page fault accounting by passing regs into handle_mm_= fault(). > > It naturally solve the issue of multiple page fault accounting when p= age fault > > retry happened. > > > > CC: Guo Ren > > CC: linux-csky@vger.kernel.org > > Signed-off-by: Peter Xu > > --- > > arch/csky/mm/fault.c | 12 +----------- > > 1 file changed, 1 insertion(+), 11 deletions(-) > > > > diff --git a/arch/csky/mm/fault.c b/arch/csky/mm/fault.c > > index b14f97d3cb15..a3e0aa3ebb79 100644 > > --- a/arch/csky/mm/fault.c > > +++ b/arch/csky/mm/fault.c > > @@ -151,7 +151,7 @@ asmlinkage void do_page_fault(struct pt_regs *reg= s, unsigned long write, > > * the fault. > > */ > > fault =3D handle_mm_fault(vma, address, write ? FAULT_FLAG_WR= ITE : 0, > > - NULL); > > + regs); > what's your kernel version ? =EF=BC=884th arg exsist ?=EF=BC=89 > /* > * If for any reason at all we couldn't handle the fault, > * make sure we exit gracefully rather than endlessly redo > * the fault. > */ > fault =3D handle_mm_fault(vma, address, write ? FAULT_FLAG_WRIT= E : 0); > if (unlikely(fault & VM_FAULT_ERROR)) { Hi, Guo, Sorry to be unclear. This patch is based on patch 1 in the same series: https://lore.kernel.org/lkml/20200619160538.8641-2-peterx@redhat.com/ Thanks, --=20 Peter Xu