From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13EAFC433E0 for ; Mon, 22 Jun 2020 17:22:47 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C1E942073E for ; Mon, 22 Jun 2020 17:22:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=Mellanox.com header.i=@Mellanox.com header.b="KcZNn7vr" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C1E942073E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mellanox.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 51FD46B0028; Mon, 22 Jun 2020 13:22:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4CF486B0029; Mon, 22 Jun 2020 13:22:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3BD786B002A; Mon, 22 Jun 2020 13:22:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0110.hostedemail.com [216.40.44.110]) by kanga.kvack.org (Postfix) with ESMTP id 22FFA6B0028 for ; Mon, 22 Jun 2020 13:22:46 -0400 (EDT) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id A6F4218045A70 for ; Mon, 22 Jun 2020 17:22:45 +0000 (UTC) X-FDA: 76957517490.07.lake18_32053e326e34 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin07.hostedemail.com (Postfix) with ESMTP id 77E9518046C70 for ; Mon, 22 Jun 2020 17:22:45 +0000 (UTC) X-HE-Tag: lake18_32053e326e34 X-Filterd-Recvd-Size: 7120 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2080.outbound.protection.outlook.com [40.107.22.80]) by imf04.hostedemail.com (Postfix) with ESMTP for ; Mon, 22 Jun 2020 17:22:44 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=b32HDAZmwsH/NLWCZc/Zk6bNZargd3hU2zPWGcLBWCGRvPYZkOIan7/fnJx1rHLL+QNTooNq0swR54m9+zevU450gphPknF4v0CvvJou0sG75G6KVAjV+cj8o5oBlU8c8o8zBaEczoBH3LflZqsKqELwyqGm1+tED23zOBwvvfEWm43fYTLtxeLUJqw+wdPid5sPRhYi/YkRVqZf+M9yqdC7w/K/LJj66/koS1bAlsAtooCi4n5AhxoAANZqZoCn9UmgZBWTvftf2BqpYsY7StDR9qCAqS6Dfp/3iFGHFnr9RpRZzrenZuCLWeldzmMZOyRFTQTCe3nzUpDMuAGtsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZKectm0+qs0cuBJgP3c2OnTQLlbCMRvDxj3UBNyQf/U=; b=nljlTZAxM0J/LpRw+Ft+9xwR/7mL1E17IULqimWDAJauOUSbpJoZKKKWkAzdUSxkwlcLyCZXQ+4+hd1vrYRy1W2LIepkPqMuKQ9kalXJxSNx29/AqkFoLGx1ewyUptdC2+gDi3iJUgXynI9s1Y1/yb6Y1/n4MNIJwq8t7ajyKJDsVAUXxy0ZVBMmu6onuMrdzFQ/K6JJ5MVygyt9de8V1efXeBAGCXNdkMhEB8TG/AeVQGxQn1AHEsq/VMQhZbn/S4NtfxWOVnv6QmLKCasxbvVrAfX18OfgSOeBP67GFFp5/MNnoUWf6LdpOCbvs+s0GgPJQH9lCfeAqqbpcfB2jg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZKectm0+qs0cuBJgP3c2OnTQLlbCMRvDxj3UBNyQf/U=; b=KcZNn7vrUQ/BTAeCGx2kR4KEOqZSxIBX/VgfX6MiQy27+TcKoruyyptu2AXlinm04N3FKkGqP7Re99hbf+aAJ/FarJURJMyvVhbDiyeVz2zbldGXstBDZ+hvuyOUe8IOQCC0gLK0eG99sidAq2MqXkOpDsDTTnwbz88xZfbREB4= Authentication-Results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=mellanox.com; Received: from VI1PR05MB4141.eurprd05.prod.outlook.com (2603:10a6:803:44::15) by VI1PR05MB6494.eurprd05.prod.outlook.com (2603:10a6:803:100::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3109.22; Mon, 22 Jun 2020 17:22:41 +0000 Received: from VI1PR05MB4141.eurprd05.prod.outlook.com ([fe80::848b:fcd0:efe3:189e]) by VI1PR05MB4141.eurprd05.prod.outlook.com ([fe80::848b:fcd0:efe3:189e%7]) with mapi id 15.20.3109.027; Mon, 22 Jun 2020 17:22:41 +0000 Date: Mon, 22 Jun 2020 14:22:33 -0300 From: Jason Gunthorpe To: Ralph Campbell Cc: nouveau@lists.freedesktop.org, linux-rdma@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Jerome Glisse , John Hubbard , Christoph Hellwig , Ben Skeggs , Andrew Morton , Shuah Khan Subject: Re: [PATCH 08/16] nouveau/hmm: fault one page at a time Message-ID: <20200622172233.GA2874652@mellanox.com> References: <20200619215649.32297-1-rcampbell@nvidia.com> <20200619215649.32297-9-rcampbell@nvidia.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200619215649.32297-9-rcampbell@nvidia.com> X-ClientProxiedBy: BL0PR02CA0015.namprd02.prod.outlook.com (2603:10b6:207:3c::28) To VI1PR05MB4141.eurprd05.prod.outlook.com (2603:10a6:803:44::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from mlx.ziepe.ca (193.47.165.251) by BL0PR02CA0015.namprd02.prod.outlook.com (2603:10b6:207:3c::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3109.22 via Frontend Transport; Mon, 22 Jun 2020 17:22:41 +0000 Received: from jgg by mlx with local (Exim 4.93) (envelope-from ) id 1jnQ9R-00C3sG-M6; Mon, 22 Jun 2020 14:22:33 -0300 X-Originating-IP: [193.47.165.251] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 5b2c37c8-af36-454b-70db-08d816d0de49 X-MS-TrafficTypeDiagnostic: VI1PR05MB6494: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4125; X-Forefront-PRVS: 0442E569BC X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: IXvycNDMc5RMGwlYeJ+YnrJ2D7KgM9glamVnejhokPj9xPAbBRcQ3M89m9TBZsQ7rHDPqrs04awCLTPLHLCZSb6PhUL02Czkfi4pMMPhQSsqM858WUuAnaCe6Wz0eoBGuPea15JTPk+A4eYTY9b9oKlm2KGUe+XRB+ymDulbsQUSb++UVAsYL9bBtumX2CfpxyBtBPk8CITWIHtULrPamyK3Poy3uX0cZ7zWgQF7X9T5n7rm4TqW7Mm+YSOvOeqTOUEP3xl1+9AmbATV/11zuVK+Px33RfL2WZfbMK9XyDfI5f9GYrQszHzEaij1bZkoMGcZspyu/6WFx6Wsvc4MLA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR05MB4141.eurprd05.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(39860400002)(396003)(346002)(366004)(376002)(136003)(6916009)(2906002)(8676002)(83380400001)(4744005)(478600001)(5660300002)(1076003)(7416002)(26005)(66946007)(66556008)(66476007)(54906003)(186003)(316002)(33656002)(36756003)(4326008)(86362001)(2616005)(8936002)(426003)(9746002)(9786002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: gvDYLvKbgVwEl33Rn7X5Vj0i9U+FbAJvJ83QtIxWJBG7X4MHCyaGvmiPtUKNxlzNQ+2kNjZ5bkZuuDUvhiqjayML65bWjCxDZWC7feFyxhE2WOa+iPnFTcsjghcPnh2lHYxd8fz5zeZMQrmbASfV+D37O4OBd6pXUseJyxspg3C6Xn+UZnd2sOwc3J7mC7qXSLo9pnbEZBEulJK/YEwqp852mvnXSFnl3HOWTqb3CR2wC8Kf49WrB9WoTWbYF0U5hv6d/BSvf3GEJPsf7sWAXOYjGCHwfuKWc2GuGnvh1N33YfmJD7T23FCAC23r8L5vhh3+ZFJkesHI4NMpDoGFX9RZyP5TiYQhaSSYyNHpkzg6ozlp0v1MYuDbmJr0r/b7uF+/yh+DZcanDg3OtzgrUnVS0KmcL/72vebQU4GSa8BbxAONkDPiTdihFEUm8N3tdwJvDIcXkH80UZHF9XIq1TpKAbLDBlp1ZwmF9cAnENQOrXnzjla7jtOPg4jGR/5S X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5b2c37c8-af36-454b-70db-08d816d0de49 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jun 2020 17:22:41.4756 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ksDzDYTK5UipZwivhJaLjYXw3npL9JnP4FtxxXu4Hc8+RTV4sV2D4QgcPk9P592aaA+WDWxMbSxQ43IZnRJQ9g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB6494 X-Rspamd-Queue-Id: 77E9518046C70 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam03 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jun 19, 2020 at 02:56:41PM -0700, Ralph Campbell wrote: > The SVM page fault handler groups faults into a range of contiguous > virtual addresses and requests hmm_range_fault() to populate and > return the page frame number of system memory mapped by the CPU. > In preparation for supporting large pages to be mapped by the GPU, > process faults one page at a time. In addition, use the hmm_range > default_flags to fix a corner case where the input hmm_pfns array > is not reinitialized after hmm_range_fault() returns -EBUSY and must > be called again. Are you sure? hmm_range_fault is pretty expensive per call.. Jason