From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.8 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5B2BC433E4 for ; Tue, 23 Jun 2020 01:59:10 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A78432075A for ; Tue, 23 Jun 2020 01:59:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qLjxvkNr" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A78432075A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id CF4336B000E; Mon, 22 Jun 2020 21:58:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A9E176B0022; Mon, 22 Jun 2020 21:58:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6DA6E6B000E; Mon, 22 Jun 2020 21:58:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0097.hostedemail.com [216.40.44.97]) by kanga.kvack.org (Postfix) with ESMTP id F30096B0022 for ; Mon, 22 Jun 2020 21:58:56 -0400 (EDT) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id A5E49181AC9CC for ; Tue, 23 Jun 2020 01:58:56 +0000 (UTC) X-FDA: 76958818272.16.dog37_5017b6e26e37 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin16.hostedemail.com (Postfix) with ESMTP id 7ADD7100E6903 for ; Tue, 23 Jun 2020 01:58:56 +0000 (UTC) X-HE-Tag: dog37_5017b6e26e37 X-Filterd-Recvd-Size: 3933 Received: from mail-ot1-f65.google.com (mail-ot1-f65.google.com [209.85.210.65]) by imf11.hostedemail.com (Postfix) with ESMTP for ; Tue, 23 Jun 2020 01:58:56 +0000 (UTC) Received: by mail-ot1-f65.google.com with SMTP id 18so328614otv.6 for ; Mon, 22 Jun 2020 18:58:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=MCboGWFBBNPNJ/zfMw0rp0TzXUHVpcQYHjnFLH8yUdQ=; b=qLjxvkNrlmv9bZtdi41+BLOddpG6V7lZaLJjhq8RArMcRBmAKDvsjPPLJHnV4ydSGn GaKG3kxvVulXCk2am/E9uf+wj4TGhQOdy9bRoiRHovkgPww0KWMxV25tRl3V6aiMWFg1 nY261RRBvZrywjkdsL9j4E4E2JRvqrcfQH214hpYZlYtgcqxTZ3jbZ77AN56RmyuZhhZ pMqtFXd+9nAAWKesiSId/W+EuIDq3oe3sHX3MRnSTyiHNmBlvGGbC9AdTm3zQmwGUf2Y FCe2fBrlaGtzJdGfS2nG5gjePKv3hlP0QdOwxXt6O/WCMmx3lKN5XHZx2AJx3cG7f90Y +4Og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=MCboGWFBBNPNJ/zfMw0rp0TzXUHVpcQYHjnFLH8yUdQ=; b=LLU3GEo4nmNUdB9DVJGxCll10q+sPj0Bko/3prn5uaB1kbGb2+0vXeyA8ib6F+oHh7 TCh/ZjM06TPSir7ImTTb4/CghWTmcDoI/g1bhdbZ5AfniWAzbuWqMqxCc5UqSLiANZir vd2TdUGxLnVARCQOU9AIHyZGGa9myVwlivaILyhunRsyVKFhrvZmBq41G2fhja5UZwgl ab6SuWc++qNZ0LyGTC1Hs798ZoQwK7z378gXn6LI94Wfs8ELp6xVNWPWtVbHEm1LPHD+ bdRj3OQ+btkDArq1z8quK2SVrziz2s4Ejkz+zWDTqGgVJ6qoWzwLUGuy8miA69MbsidS UEBQ== X-Gm-Message-State: AOAM5321TfqDXwZNTN1kauubDH0qgFyQqNcJfVF15N2DWusnTieizx9N Oay4E9L6Hyes/w4dTASvEo0= X-Google-Smtp-Source: ABdhPJxSrcCKKCRUeHD30M3AQeo8rvHO/2WJtjHDNVQeOBS9Zj04/iDKzYH41GdocnqTxlMNektlKA== X-Received: by 2002:a9d:5a12:: with SMTP id v18mr15905043oth.90.1592877535459; Mon, 22 Jun 2020 18:58:55 -0700 (PDT) Received: from localhost.localdomain ([2604:1380:4111:8b00::3]) by smtp.gmail.com with ESMTPSA id c13sm3737990otm.78.2020.06.22.18.58.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Jun 2020 18:58:54 -0700 (PDT) From: Nathan Chancellor To: Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com, Barry Song , Nathan Chancellor Subject: [PATCH] mm: cma: Return cma->name directly in cma_get_name Date: Mon, 22 Jun 2020 18:58:40 -0700 Message-Id: <20200623015840.621964-1-natechancellor@gmail.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 X-Patchwork-Bot: notify X-Rspamd-Queue-Id: 7ADD7100E6903 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000109, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: clang warns: mm/cma.c:55:14: warning: address of array 'cma->name' will always evaluate to 'true' [-Wpointer-bool-conversion] return cma->name ? cma->name : "(undefined)"; ~~~~~^~~~ ~ 1 warning generated. After commit e7f0557d7de9 ("mm: cma: fix the name of CMA areas"), cma->name will be an array with some value worth printing so we do not need to check for NULL. Link: https://github.com/ClangBuiltLinux/linux/issues/1063 Signed-off-by: Nathan Chancellor --- mm/cma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/cma.c b/mm/cma.c index 31a61d410c59..6cf08817bac6 100644 --- a/mm/cma.c +++ b/mm/cma.c @@ -52,7 +52,7 @@ unsigned long cma_get_size(const struct cma *cma) =20 const char *cma_get_name(const struct cma *cma) { - return cma->name ? cma->name : "(undefined)"; + return cma->name; } =20 static unsigned long cma_bitmap_aligned_mask(const struct cma *cma, base-commit: 27f11fea33608cbd321a97cbecfa2ef97dcc1821 --=20 2.27.0