From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97E6AC433DF for ; Tue, 23 Jun 2020 01:58:55 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3046720768 for ; Tue, 23 Jun 2020 01:58:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=fb.com header.i=@fb.com header.b="KHNATK2g" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3046720768 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=fb.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 7B8FA6B0002; Mon, 22 Jun 2020 21:58:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 742906B0005; Mon, 22 Jun 2020 21:58:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5E36B6B0006; Mon, 22 Jun 2020 21:58:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0102.hostedemail.com [216.40.44.102]) by kanga.kvack.org (Postfix) with ESMTP id 3F9646B0002 for ; Mon, 22 Jun 2020 21:58:54 -0400 (EDT) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 9C1902DFA for ; Tue, 23 Jun 2020 01:58:53 +0000 (UTC) X-FDA: 76958818146.11.crib23_5a16e7a26e37 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin11.hostedemail.com (Postfix) with ESMTP id 68FDA180F8B80 for ; Tue, 23 Jun 2020 01:58:53 +0000 (UTC) X-HE-Tag: crib23_5a16e7a26e37 X-Filterd-Recvd-Size: 10576 Received: from mx0a-00082601.pphosted.com (mx0a-00082601.pphosted.com [67.231.145.42]) by imf14.hostedemail.com (Postfix) with ESMTP for ; Tue, 23 Jun 2020 01:58:52 +0000 (UTC) Received: from pps.filterd (m0148461.ppops.net [127.0.0.1]) by mx0a-00082601.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 05N1sn3W008923 for ; Mon, 22 Jun 2020 18:58:51 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding : content-type; s=facebook; bh=1/mu3TKERIlO7OwVc3OGr/yppIik5DuQWmby/WiDYtE=; b=KHNATK2gpp5R2ILy78kV9h8DXyPQrHkiU3FjWXUgaf2Bnal2wlWKrlBGVRIRSaXph41q aMycOQQahnyRaBxt1eLH1pE2R03V3Z93K8bqBKoat/nUMnMl0d2PF1MiOQTj9T4uSOCp RYi9700bm4A803vaIv+vluxMymRjYwq5ABE= Received: from mail.thefacebook.com ([163.114.132.120]) by mx0a-00082601.pphosted.com with ESMTP id 31u09s2bus-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Mon, 22 Jun 2020 18:58:51 -0700 Received: from intmgw002.41.prn1.facebook.com (2620:10d:c085:108::8) by mail.thefacebook.com (2620:10d:c085:21d::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1979.3; Mon, 22 Jun 2020 18:58:50 -0700 Received: by devvm1291.vll0.facebook.com (Postfix, from userid 111017) id 59D6F26DD024; Mon, 22 Jun 2020 18:58:48 -0700 (PDT) Smtp-Origin-Hostprefix: devvm From: Roman Gushchin Smtp-Origin-Hostname: devvm1291.vll0.facebook.com To: Andrew Morton , Christoph Lameter CC: Johannes Weiner , Michal Hocko , Shakeel Butt , , Vlastimil Babka , , , Roman Gushchin Smtp-Origin-Cluster: vll0c01 Subject: [PATCH v7 05/19] mm: memcontrol: decouple reference counting from page accounting Date: Mon, 22 Jun 2020 18:58:32 -0700 Message-ID: <20200623015846.1141975-6-guro@fb.com> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200623015846.1141975-1-guro@fb.com> References: <20200623015846.1141975-1-guro@fb.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-FB-Internal: Safe Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.216,18.0.687 definitions=2020-06-22_16:2020-06-22,2020-06-22 signatures=0 X-Proofpoint-Spam-Details: rule=fb_default_notspam policy=fb_default score=0 impostorscore=0 phishscore=0 mlxscore=0 cotscore=-2147483648 suspectscore=0 adultscore=0 bulkscore=0 priorityscore=1501 lowpriorityscore=0 malwarescore=0 mlxlogscore=999 clxscore=1015 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2004280000 definitions=main-2006230012 X-FB-Internal: deliver X-Rspamd-Queue-Id: 68FDA180F8B80 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam04 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Johannes Weiner The reference counting of a memcg is currently coupled directly to how many 4k pages are charged to it. This doesn't work well with Roman's new slab controller, which maintains pools of objects and doesn't want to kee= p an extra balance sheet for the pages backing those objects. This unusual refcounting design (reference counts usually track pointers to an object) is only for historical reasons: memcg used to not take any css references and simply stalled offlining until all charges had been reparented and the page counters had dropped to zero. When we got rid of the reparenting requirement, the simple mechanical translation was to tak= e a reference for every charge. More historical context can be found in commit e8ea14cc6ead ("mm: memcontrol: take a css reference for each charged page"), commit 64f219938941 ("mm: memcontrol: remove obsolete kmemcg pinning tricks") an= d commit b2052564e66d ("mm: memcontrol: continue cache reclaim from offline= d groups"). The new slab controller exposes the limitations in this scheme, so let's switch it to a more idiomatic reference counting model based on actual kernel pointers to the memcg: - The per-cpu stock holds a reference to the memcg its caching - User pages hold a reference for their page->mem_cgroup. Transparent huge pages will no longer acquire tail references in advance, we'll get them if needed during the split. - Kernel pages hold a reference for their page->mem_cgroup - Pages allocated in the root cgroup will acquire and release css references for simplicity. css_get() and css_put() optimize that. - The current memcg_charge_slab() already hacked around the per-charge references; this change gets rid of that as well. Roman: 1) Rebased on top of the current mm tree: added css_get() in mem_cgroup_charge(), dropped mem_cgroup_try_charge() part 2) I've reformatted commit references in the commit log to make checkpatch.pl happy. Signed-off-by: Johannes Weiner Signed-off-by: Roman Gushchin Acked-by: Roman Gushchin Reviewed-by: Shakeel Butt --- mm/memcontrol.c | 37 +++++++++++++++++++++---------------- mm/slab.h | 2 -- 2 files changed, 21 insertions(+), 18 deletions(-) diff --git a/mm/memcontrol.c b/mm/memcontrol.c index a6216f7369b2..3e5597f8dec5 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -2094,13 +2094,17 @@ static void drain_stock(struct memcg_stock_pcp *s= tock) { struct mem_cgroup *old =3D stock->cached; =20 + if (!old) + return; + if (stock->nr_pages) { page_counter_uncharge(&old->memory, stock->nr_pages); if (do_memsw_account()) page_counter_uncharge(&old->memsw, stock->nr_pages); - css_put_many(&old->css, stock->nr_pages); stock->nr_pages =3D 0; } + + css_put(&old->css); stock->cached =3D NULL; } =20 @@ -2136,6 +2140,7 @@ static void refill_stock(struct mem_cgroup *memcg, = unsigned int nr_pages) stock =3D this_cpu_ptr(&memcg_stock); if (stock->cached !=3D memcg) { /* reset if necessary */ drain_stock(stock); + css_get(&memcg->css); stock->cached =3D memcg; } stock->nr_pages +=3D nr_pages; @@ -2594,12 +2599,10 @@ static int try_charge(struct mem_cgroup *memcg, g= fp_t gfp_mask, page_counter_charge(&memcg->memory, nr_pages); if (do_memsw_account()) page_counter_charge(&memcg->memsw, nr_pages); - css_get_many(&memcg->css, nr_pages); =20 return 0; =20 done_restock: - css_get_many(&memcg->css, batch); if (batch > nr_pages) refill_stock(memcg, batch - nr_pages); =20 @@ -2657,8 +2660,6 @@ static void cancel_charge(struct mem_cgroup *memcg,= unsigned int nr_pages) page_counter_uncharge(&memcg->memory, nr_pages); if (do_memsw_account()) page_counter_uncharge(&memcg->memsw, nr_pages); - - css_put_many(&memcg->css, nr_pages); } #endif =20 @@ -2966,6 +2967,7 @@ int __memcg_kmem_charge_page(struct page *page, gfp= _t gfp, int order) if (!ret) { page->mem_cgroup =3D memcg; __SetPageKmemcg(page); + return 0; } } css_put(&memcg->css); @@ -2988,12 +2990,11 @@ void __memcg_kmem_uncharge_page(struct page *page= , int order) VM_BUG_ON_PAGE(mem_cgroup_is_root(memcg), page); __memcg_kmem_uncharge(memcg, nr_pages); page->mem_cgroup =3D NULL; + css_put(&memcg->css); =20 /* slab pages do not have PageKmemcg flag set */ if (PageKmemcg(page)) __ClearPageKmemcg(page); - - css_put_many(&memcg->css, nr_pages); } #endif /* CONFIG_MEMCG_KMEM */ =20 @@ -3005,13 +3006,16 @@ void __memcg_kmem_uncharge_page(struct page *page= , int order) */ void mem_cgroup_split_huge_fixup(struct page *head) { + struct mem_cgroup *memcg =3D head->mem_cgroup; int i; =20 if (mem_cgroup_disabled()) return; =20 - for (i =3D 1; i < HPAGE_PMD_NR; i++) - head[i].mem_cgroup =3D head->mem_cgroup; + for (i =3D 1; i < HPAGE_PMD_NR; i++) { + css_get(&memcg->css); + head[i].mem_cgroup =3D memcg; + } } #endif /* CONFIG_TRANSPARENT_HUGEPAGE */ =20 @@ -5456,7 +5460,10 @@ static int mem_cgroup_move_account(struct page *pa= ge, */ smp_mb(); =20 - page->mem_cgroup =3D to; /* caller should have done css_get */ + css_get(&to->css); + css_put(&from->css); + + page->mem_cgroup =3D to; =20 __unlock_page_memcg(from); =20 @@ -6506,6 +6513,7 @@ int mem_cgroup_charge(struct page *page, struct mm_= struct *mm, gfp_t gfp_mask) if (ret) goto out_put; =20 + css_get(&memcg->css); commit_charge(page, memcg); =20 local_irq_disable(); @@ -6560,9 +6568,6 @@ static void uncharge_batch(const struct uncharge_ga= ther *ug) __this_cpu_add(ug->memcg->vmstats_percpu->nr_page_events, ug->nr_pages)= ; memcg_check_events(ug->memcg, ug->dummy_page); local_irq_restore(flags); - - if (!mem_cgroup_is_root(ug->memcg)) - css_put_many(&ug->memcg->css, ug->nr_pages); } =20 static void uncharge_page(struct page *page, struct uncharge_gather *ug) @@ -6600,6 +6605,7 @@ static void uncharge_page(struct page *page, struct= uncharge_gather *ug) =20 ug->dummy_page =3D page; page->mem_cgroup =3D NULL; + css_put(&ug->memcg->css); } =20 static void uncharge_list(struct list_head *page_list) @@ -6705,8 +6711,8 @@ void mem_cgroup_migrate(struct page *oldpage, struc= t page *newpage) page_counter_charge(&memcg->memory, nr_pages); if (do_memsw_account()) page_counter_charge(&memcg->memsw, nr_pages); - css_get_many(&memcg->css, nr_pages); =20 + css_get(&memcg->css); commit_charge(newpage, memcg); =20 local_irq_save(flags); @@ -6943,8 +6949,7 @@ void mem_cgroup_swapout(struct page *page, swp_entr= y_t entry) mem_cgroup_charge_statistics(memcg, page, -nr_entries); memcg_check_events(memcg, page); =20 - if (!mem_cgroup_is_root(memcg)) - css_put_many(&memcg->css, nr_entries); + css_put(&memcg->css); } =20 /** diff --git a/mm/slab.h b/mm/slab.h index cc6afddd5632..1e2d80991904 100644 --- a/mm/slab.h +++ b/mm/slab.h @@ -401,9 +401,7 @@ static __always_inline int memcg_charge_slab(struct p= age *page, lruvec =3D mem_cgroup_lruvec(memcg, page_pgdat(page)); mod_lruvec_state(lruvec, cache_vmstat_idx(s), nr_pages << PAGE_SHIFT); =20 - /* transer try_charge() page references to kmem_cache */ percpu_ref_get_many(&s->memcg_params.refcnt, nr_pages); - css_put_many(&memcg->css, nr_pages); out: css_put(&memcg->css); return ret; --=20 2.26.2