From: Wei Yang <richard.weiyang@linux.alibaba.com>
To: akpm@linux-foundation.org, osalvador@suse.de, dan.j.williams@intel.com
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
david@redhat.com, Wei Yang <richard.weiyang@linux.alibaba.com>
Subject: [PATCH] mm/spase: never partially remove memmap for early section
Date: Tue, 23 Jun 2020 17:42:58 +0800 [thread overview]
Message-ID: <20200623094258.6705-1-richard.weiyang@linux.alibaba.com> (raw)
For early sections, we assumes its memmap will never be partially
removed. But current behavior breaks this.
Let's correct it.
Fixes: ba72b4c8cf60 ("mm/sparsemem: support sub-section hotplug")
Signed-off-by: Wei Yang <richard.weiyang@linux.alibaba.com>
---
mm/sparse.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/mm/sparse.c b/mm/sparse.c
index b2b9a3e34696..1a0069f492f5 100644
--- a/mm/sparse.c
+++ b/mm/sparse.c
@@ -825,10 +825,10 @@ static void section_deactivate(unsigned long pfn, unsigned long nr_pages,
ms->section_mem_map &= ~SECTION_HAS_MEM_MAP;
}
- if (section_is_early && memmap)
- free_map_bootmem(memmap);
- else
+ if (!section_is_early)
depopulate_section_memmap(pfn, nr_pages, altmap);
+ else if (memmap)
+ free_map_bootmem(memmap);
if (empty)
ms->section_mem_map = (unsigned long)NULL;
--
2.20.1 (Apple Git-117)
next reply other threads:[~2020-06-23 9:43 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-23 9:42 Wei Yang [this message]
2020-06-23 12:44 ` [PATCH] mm/spase: never partially remove memmap for early section David Hildenbrand
2020-06-23 13:02 ` Wei Yang
2020-06-23 13:16 ` David Hildenbrand
2020-06-23 15:18 ` Michal Hocko
2020-06-23 21:48 ` Wei Yang
2020-06-24 6:13 ` Wei Yang
2020-06-24 16:10 ` Dan Williams
2020-06-24 22:05 ` Wei Yang
2020-06-24 22:20 ` Dan Williams
2020-06-24 22:44 ` Wei Yang
2020-06-24 23:47 ` Dan Williams
2020-06-25 5:53 ` David Hildenbrand
2020-06-25 19:46 ` Dan Williams
2020-06-25 22:29 ` Wei Yang
2020-06-29 8:34 ` Wei Yang
2020-06-29 22:13 ` Dan Williams
2020-06-29 22:58 ` Wei Yang
2020-06-30 7:16 ` David Hildenbrand
2020-06-25 22:39 ` Wei Yang
2020-06-26 4:59 ` David Hildenbrand
2020-06-24 7:48 ` David Hildenbrand
2020-06-24 8:04 ` David Hildenbrand
2020-06-24 8:13 ` Wei Yang
2020-06-24 8:41 ` David Hildenbrand
2020-06-24 8:50 ` Michal Hocko
2020-06-24 22:27 ` Wei Yang
2020-06-24 0:21 ` Dan Williams
2020-06-24 1:11 ` Wei Yang
2020-06-24 1:47 ` Baoquan He
2020-06-24 2:14 ` Baoquan He
2020-06-24 3:46 ` Wei Yang
2020-06-24 3:52 ` Baoquan He
2020-06-24 3:56 ` Wei Yang
2020-06-24 8:51 ` David Hildenbrand
2020-06-24 22:08 ` Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200623094258.6705-1-richard.weiyang@linux.alibaba.com \
--to=richard.weiyang@linux.alibaba.com \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=osalvador@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).