From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 776F4C433E0 for ; Wed, 24 Jun 2020 18:38:17 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2E9B620767 for ; Wed, 24 Jun 2020 18:38:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="H8wIYR6m" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2E9B620767 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id BC92F6B002A; Wed, 24 Jun 2020 14:38:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B79216B002B; Wed, 24 Jun 2020 14:38:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A69C16B002D; Wed, 24 Jun 2020 14:38:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0219.hostedemail.com [216.40.44.219]) by kanga.kvack.org (Postfix) with ESMTP id 8FC4A6B002A for ; Wed, 24 Jun 2020 14:38:16 -0400 (EDT) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 4BA6F181AC9CB for ; Wed, 24 Jun 2020 18:38:16 +0000 (UTC) X-FDA: 76964965392.20.ink50_1917a7726e46 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin20.hostedemail.com (Postfix) with ESMTP id 80AAD180C03B3 for ; Wed, 24 Jun 2020 18:37:48 +0000 (UTC) X-HE-Tag: ink50_1917a7726e46 X-Filterd-Recvd-Size: 3010 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf13.hostedemail.com (Postfix) with ESMTP for ; Wed, 24 Jun 2020 18:37:48 +0000 (UTC) Received: from X1 (nat-ab2241.sltdut.senawave.net [162.218.216.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F204C20724; Wed, 24 Jun 2020 18:37:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593023867; bh=N33U5QaNc/HrhztgGmlLrw0Lcvv3sVffeuhLVRirZ5M=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=H8wIYR6mKQWXAtMhWWdVubpavMoyGBwOsJpZO1R4v/xzEueX9mj0ObtigPlPv+kyh vTuKYFXjEZXz+HYP0Vu7VnF0JZnAB9gHZGRLo4S9EEgyCb56fsHuP0vmG3DSiBQBkB kJas+9InzzomFGeVndN82lMzixZN6KP3tYTzsi94= Date: Wed, 24 Jun 2020 11:37:46 -0700 From: Andrew Morton To: Catalin Marinas Cc: linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, Will Deacon , Dave P Martin , Vincenzo Frascino , Szabolcs Nagy , Kevin Brodsky , Andrey Konovalov , Peter Collingbourne Subject: Re: [PATCH v5 13/25] mm: Introduce arch_validate_flags() Message-Id: <20200624113746.589b6af7779f39eee846ea74@linux-foundation.org> In-Reply-To: <20200624175244.25837-14-catalin.marinas@arm.com> References: <20200624175244.25837-1-catalin.marinas@arm.com> <20200624175244.25837-14-catalin.marinas@arm.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 80AAD180C03B3 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 24 Jun 2020 18:52:32 +0100 Catalin Marinas wrote: > Similarly to arch_validate_prot() called from do_mprotect_pkey(), an > architecture may need to sanity-check the new vm_flags. > > Define a dummy function always returning true. In addition to > do_mprotect_pkey(), also invoke it from mmap_region() prior to updating > vma->vm_page_prot to allow the architecture code to veto potentially > inconsistent vm_flags. > > ... > > --- a/include/linux/mman.h > +++ b/include/linux/mman.h > @@ -103,6 +103,19 @@ static inline bool arch_validate_prot(unsigned long prot, unsigned long addr) > #define arch_validate_prot arch_validate_prot > #endif > > +#ifndef arch_validate_flags > +/* > + * This is called from mmap() and mprotect() with the updated vma->vm_flags. > + * > + * Returns true if the VM_* flags are valid. > + */ > +static inline bool arch_validate_flags(unsigned long flags) > +{ > + return true; > +} > +#define arch_validate_flags arch_validate_flags > +#endif Again, please let's nail down where the arch should define this. Otherwise, Acked-by: Andrew Morton