From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32DA2C433E0 for ; Wed, 24 Jun 2020 17:02:31 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E697E20738 for ; Wed, 24 Jun 2020 17:02:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="FsRK7tXt" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E697E20738 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 50FE66B0023; Wed, 24 Jun 2020 13:02:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4996A6B0024; Wed, 24 Jun 2020 13:02:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 35FFB6B0025; Wed, 24 Jun 2020 13:02:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0251.hostedemail.com [216.40.44.251]) by kanga.kvack.org (Postfix) with ESMTP id 1A37C6B0023 for ; Wed, 24 Jun 2020 13:02:30 -0400 (EDT) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 69E0C180295BA for ; Wed, 24 Jun 2020 17:02:28 +0000 (UTC) X-FDA: 76964723976.07.balls91_320962b26e45 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin07.hostedemail.com (Postfix) with ESMTP id 9F82118024534 for ; Wed, 24 Jun 2020 17:01:53 +0000 (UTC) X-HE-Tag: balls91_320962b26e45 X-Filterd-Recvd-Size: 2465 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf40.hostedemail.com (Postfix) with ESMTP for ; Wed, 24 Jun 2020 17:01:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=1baVfimWLcXjNC1LOBhrvYVgFXcqgjspjMtUDc+uHOg=; b=FsRK7tXtToINS4RWLZ6bldI3ZR svjWT2G3Htdr+57klE8pWMcwOgxpJge+NOntnu1bRGoXiS6VuWzE+JyGgHB9pnR9AqvcR5MF3qZVw g7ZHqtGt2hPHbtqLklJWTUGQJiLC+ph00eHFm4I5tbKi+7RanswXUOFqBQm67uT/unUvGJOkSWcbP XpIk4aVNJ0t8K7iqUjL2/DUVu/UWfkdrn79w3sULpCyBR7IljycqxW64pxfYpYuevFA/ul3bLZucw ayTdO3f54gPtRJAEygoVxwzcWV1T3uyCUD1hEGgOh1Kq++rjNEhQipjwKEQR/VD1bVt6vpsXgDF17 qWTPZvfA==; Received: from willy by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jo8mB-0000An-Aq; Wed, 24 Jun 2020 17:01:31 +0000 Date: Wed, 24 Jun 2020 18:01:31 +0100 From: Matthew Wilcox To: Joel Savitz Cc: linux-kernel@vger.kernel.org, Vlastimil Babka , John Hubbard , Andrew Morton , Rafael Aquini , Fabrizio D'Angelo , linux-mm@kvack.org Subject: Re: [PATCH v2] mm/page_alloc: fix documentation error and remove magic numbers Message-ID: <20200624170131.GQ21350@casper.infradead.org> References: <20200624164943.32048-1-jsavitz@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200624164943.32048-1-jsavitz@redhat.com> X-Rspamd-Queue-Id: 9F82118024534 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam01 X-Bogosity: Ham, tests=bogofilter, spamicity=0.009461, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 24, 2020 at 12:49:43PM -0400, Joel Savitz wrote: > When I increased the upper bound of the min_free_kbytes value in > ee8eb9a5fe863, I forgot to tweak the above comment to reflect > the new value. This patch fixes that mistake. > > In addition, this patch replaces the magic number bounds with symbolic > constants to clarify the logic. > > changes from v1: > - declare constants via enum instead of separate integers > > Suggested-by: John Hubbard > Suggested-by: Vlastimil Babka > Signed-off-by: Joel Savitz NAK. Just fix the documentation. It's bad form to combine two completely different things in one patch anyway.