From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85018C433DF for ; Wed, 24 Jun 2020 18:39:22 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 55DF220724 for ; Wed, 24 Jun 2020 18:39:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 55DF220724 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id F23676B002A; Wed, 24 Jun 2020 14:39:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EAD276B002B; Wed, 24 Jun 2020 14:39:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D74876B002D; Wed, 24 Jun 2020 14:39:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0065.hostedemail.com [216.40.44.65]) by kanga.kvack.org (Postfix) with ESMTP id C068C6B002A for ; Wed, 24 Jun 2020 14:39:21 -0400 (EDT) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 5A6AE1EE6 for ; Wed, 24 Jun 2020 18:39:21 +0000 (UTC) X-FDA: 76964968122.02.beast62_490840c26e46 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin02.hostedemail.com (Postfix) with ESMTP id 3F384100098513C2 for ; Wed, 24 Jun 2020 18:39:21 +0000 (UTC) X-HE-Tag: beast62_490840c26e46 X-Filterd-Recvd-Size: 6290 Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by imf31.hostedemail.com (Postfix) with ESMTP for ; Wed, 24 Jun 2020 18:39:20 +0000 (UTC) Received: by mail-wr1-f68.google.com with SMTP id r12so3236508wrj.13 for ; Wed, 24 Jun 2020 11:39:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=WPLJJBf/lJKRfE0nK6AuawFua6bQlcJVOnPGb3ePz2E=; b=CWyKqMRbBCoaEWRUksa6T8XGKqWiJveqZYIaF8KWaHuU8wASmHPq25vlvDDQr5e2OD ue7Gei+MlqTxhudY6SD15yyioPboca01g8wjg6N1xEGQCp0nqQitMn/MFZkrkej/7zpQ iH3zjAZyg/YuZmsxPLgOY+JMfnxZdlbcQobqOYx6BRat6F0PG8iJ+84kZ7zH2ZGVZ6VA VbAt1IkzWGrzN5ejSZQ4z4dRXkTg8fMi01inQtkOaZRaVyRMBlq4o8sA3iind/CcfS9w Z2Qsv+92yyALOt7nAsiVeu516F1vOt5P7Epn2C+x8jJiJdtlY/B4Tu9WBKRVVGWBVDNf pzcw== X-Gm-Message-State: AOAM533/em/1bSGf1JOUrZ3WHN24AUYtBxypxDTvujd5BIA8MkQDy9QU VN+glGfaENSJFOWIbt/PpVw= X-Google-Smtp-Source: ABdhPJzG1J7UOIbj3D5FegqhdaC4Ed8a/hoCqqo84Wvhgyil9nUm55P13RKaZE3H0wCv+QDB8D5lqg== X-Received: by 2002:a5d:6a01:: with SMTP id m1mr34145363wru.115.1593023959580; Wed, 24 Jun 2020 11:39:19 -0700 (PDT) Received: from localhost (ip-37-188-168-3.eurotel.cz. [37.188.168.3]) by smtp.gmail.com with ESMTPSA id o15sm8950965wmm.31.2020.06.24.11.39.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jun 2020 11:39:18 -0700 (PDT) Date: Wed, 24 Jun 2020 20:39:17 +0200 From: Michal Hocko To: Ben Widawsky Cc: linux-mm , Andi Kleen , Andrew Morton , Christoph Lameter , Dan Williams , Dave Hansen , David Hildenbrand , David Rientjes , Jason Gunthorpe , Johannes Weiner , Jonathan Corbet , Kuppuswamy Sathyanarayanan , Lee Schermerhorn , Li Xinhai , Mel Gorman , Mike Kravetz , Mina Almasry , Tejun Heo , Vlastimil Babka , linux-api@vger.kernel.org Subject: Re: [PATCH 00/18] multiple preferred nodes Message-ID: <20200624183917.GW1320@dhcp22.suse.cz> References: <20200619162425.1052382-1-ben.widawsky@intel.com> <20200622070957.GB31426@dhcp22.suse.cz> <20200623112048.GR31426@dhcp22.suse.cz> <20200623161211.qjup5km5eiisy5wy@intel.com> <20200624075216.GC1320@dhcp22.suse.cz> <20200624161643.75fkkvsxlmp3bf2e@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200624161643.75fkkvsxlmp3bf2e@intel.com> X-Rspamd-Queue-Id: 3F384100098513C2 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed 24-06-20 09:16:43, Ben Widawsky wrote: > On 20-06-24 09:52:16, Michal Hocko wrote: > > On Tue 23-06-20 09:12:11, Ben Widawsky wrote: > > > On 20-06-23 13:20:48, Michal Hocko wrote: > > [...] > > > > It would be also great to provide a high level semantic description > > > > here. I have very quickly glanced through patches and they are not > > > > really trivial to follow with many incremental steps so the higher level > > > > intention is lost easily. > > > > > > > > Do I get it right that the default semantic is essentially > > > > - allocate page from the given nodemask (with __GFP_RETRY_MAYFAIL > > > > semantic) > > > > - fallback to numa unrestricted allocation with the default > > > > numa policy on the failure > > > > > > > > Or are there any usecases to modify how hard to keep the preference over > > > > the fallback? > > > > > > tl;dr is: yes, and no usecases. > > > > OK, then I am wondering why the change has to be so involved. Except for > > syscall plumbing the only real change to the allocator path would be > > something like > > > > static nodemask_t *policy_nodemask(gfp_t gfp, struct mempolicy *policy) > > { > > /* Lower zones don't get a nodemask applied for MPOL_BIND */ > > if (unlikely(policy->mode == MPOL_BIND || > > policy->mode == MPOL_PREFERED_MANY) && > > apply_policy_zone(policy, gfp_zone(gfp)) && > > cpuset_nodemask_valid_mems_allowed(&policy->v.nodes)) > > return &policy->v.nodes; > > > > return NULL; > > } > > > > alloc_pages_current > > > > if (pol->mode == MPOL_INTERLEAVE) > > page = alloc_page_interleave(gfp, order, interleave_nodes(pol)); > > else { > > gfp_t gfp_attempt = gfp; > > > > /* > > * Make sure the first allocation attempt will try hard > > * but eventually fail without OOM killer or other > > * disruption before falling back to the full nodemask > > */ > > if (pol->mode == MPOL_PREFERED_MANY) > > gfp_attempt |= __GFP_RETRY_MAYFAIL; > > > > page = __alloc_pages_nodemask(gfp_attempt, order, > > policy_node(gfp, pol, numa_node_id()), > > policy_nodemask(gfp, pol)); > > if (!page && pol->mode == MPOL_PREFERED_MANY) > > page = __alloc_pages_nodemask(gfp, order, > > numa_node_id(), NULL); > > } > > > > return page; > > > > similar (well slightly more hairy) in alloc_pages_vma > > > > Or do I miss something that really requires more involved approach like > > building custom zonelists and other larger changes to the allocator? > > I think I'm missing how this allows selecting from multiple preferred nodes. In > this case when you try to get the page from the freelist, you'll get the > zonelist of the preferred node, and when you actually scan through on page > allocation, you have no way to filter out the non-preferred nodes. I think the > plumbing of multiple nodes has to go all the way through > __alloc_pages_nodemask(). But it's possible I've missed the point. policy_nodemask() will provide the nodemask which will be used as a filter on the policy_node. -- Michal Hocko SUSE Labs