From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F795C433DF for ; Thu, 25 Jun 2020 08:31:20 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3BAEE20720 for ; Thu, 25 Jun 2020 08:31:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3BAEE20720 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=alpha.franken.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id AB7646B0005; Thu, 25 Jun 2020 04:31:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A681C6B0007; Thu, 25 Jun 2020 04:31:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 97DCB6B000C; Thu, 25 Jun 2020 04:31:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0056.hostedemail.com [216.40.44.56]) by kanga.kvack.org (Postfix) with ESMTP id 8106B6B0005 for ; Thu, 25 Jun 2020 04:31:19 -0400 (EDT) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 0CB372DFD for ; Thu, 25 Jun 2020 08:31:19 +0000 (UTC) X-FDA: 76967064678.18.cub56_03040d226e4b Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin18.hostedemail.com (Postfix) with ESMTP id DA817100EDBEE for ; Thu, 25 Jun 2020 08:31:18 +0000 (UTC) X-HE-Tag: cub56_03040d226e4b X-Filterd-Recvd-Size: 2165 Received: from elvis.franken.de (elvis.franken.de [193.175.24.41]) by imf46.hostedemail.com (Postfix) with ESMTP for ; Thu, 25 Jun 2020 08:31:18 +0000 (UTC) Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1joNHt-0001Gi-04; Thu, 25 Jun 2020 10:31:13 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id C8607C06F9; Thu, 25 Jun 2020 10:28:37 +0200 (CEST) Date: Thu, 25 Jun 2020 10:28:37 +0200 From: Thomas Bogendoerfer To: Peter Xu Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Gerald Schaefer , Andrew Morton , Andrea Arcangeli , Will Deacon , Michael Ellerman , Linus Torvalds , linux-mips@vger.kernel.org Subject: Re: [PATCH 11/26] mm/mips: Use general page fault accounting Message-ID: <20200625082837.GD6319@alpha.franken.de> References: <20200619160538.8641-1-peterx@redhat.com> <20200619160538.8641-12-peterx@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200619160538.8641-12-peterx@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Rspamd-Queue-Id: DA817100EDBEE X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jun 19, 2020 at 12:05:23PM -0400, Peter Xu wrote: > Use the general page fault accounting by passing regs into handle_mm_fault(). > It naturally solve the issue of multiple page fault accounting when page fault > retry happened. > > Fix PERF_COUNT_SW_PAGE_FAULTS perf event manually for page fault retries, by > moving it before taking mmap_sem. > > CC: Thomas Bogendoerfer > CC: linux-mips@vger.kernel.org > Signed-off-by: Peter Xu > --- > arch/mips/mm/fault.c | 14 +++----------- > 1 file changed, 3 insertions(+), 11 deletions(-) Acked-by: Thomas Bogendoerfer Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]